Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Fix ruff being skipped in CI by prefixing destinations with skore/ after #440 #545

Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(ci): Fix ruff being skipped in CI by prefixing destinations with skore/ after #440 #545

merged 1 commit into from
Oct 21, 2024

Conversation

thomass-dev
Copy link
Collaborator

@thomass-dev thomass-dev commented Oct 21, 2024 •
edited
Loading

We can see in #541 that pre-commit doesn't execute ruff:

image

Now:

image

@thomass-dev thomass-dev added the bug Something isn't working label Oct 21, 2024
@thomass-dev thomass-dev marked this pull request as ready for review October 21, 2024 08:54
augustebaum
augustebaum approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@augustebaum augustebaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch

@augustebaum augustebaum changed the title fix(ci): Fix RUFF by prefixing destinations with skore/ after #440 fix(ci): Fix ruff being skipped in CI by prefixing destinations with skore/ after #440 Oct 21, 2024
@augustebaum augustebaum merged commit ef1bfec into main Oct 21, 2024
16 checks passed
@augustebaum augustebaum deleted the fix-ruff branch October 21, 2024 08:57
thomass-dev added a commit that referenced this pull request Dec 2, 2024
@thomass-dev
fix(ci): Fix ruff being skipped in CI by prefixing destinations with …
8a1857c 
…`skore/` after #440 (#545)

We can see in #541 that pre-commit doesn't execute ruff:


![image](https://github.com/user-attachments/assets/3822a0e6-ca08-43a8-934b-0c417d6d7b6e)

Now:


![image](https://github.com/user-attachments/assets/c89394dd-5c8c-49d5-ba67-e05724505608)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@augustebaum augustebaum augustebaum approved these changes

Assignees

@thomass-dev thomass-dev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomass-dev @augustebaum