Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaking test: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedPrematurely #48

Closed
iand opened this issue Oct 4, 2023 · 9 comments · Fixed by #50 or #54
Closed

Flaking test: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedPrematurely #48

iand opened this issue Oct 4, 2023 · 9 comments · Fixed by #50 or #54
Labels
bug Something isn't working

Comments

@iand
Copy link
Contributor

iand commented Oct 4, 2023

This test run failed on a PR with no code changes

https://github.com/plprobelab/zikade/actions/runs/6408785740/job/17398549960?pr=47

--- FAIL: TestDHT_SearchValue_quorum_test_suite (10.79s)
    --- PASS: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedAfterDiscoveryOfBetter (0.27s)
    --- FAIL: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedPrematurely (10.15s)
    --- PASS: TestDHT_SearchValue_quorum_test_suite/TestQuorumUnspecified (0.18s)
    --- PASS: TestDHT_SearchValue_quorum_test_suite/TestQuorumZero (0.17s)
@iand iand added the bug Something isn't working label Oct 4, 2023
@github-project-automation github-project-automation bot moved this to Unplanned in DHT Optimization Oct 4, 2023
@iand iand mentioned this issue Oct 4, 2023
Merged
@dennis-tra
Copy link
Contributor

Still relates to libp2p/go-libp2p#2589 if we extended the test timeout this will work

@iand
Copy link
Contributor Author

iand commented Oct 5, 2023

I will try that

@iand iand mentioned this issue Oct 5, 2023
Merged
@dennis-tra
Copy link
Contributor

I'm just experimenting with #50

@iand
Copy link
Contributor Author

iand commented Oct 5, 2023

I've been unable to reproduce this locally.

I ran go test -count 1000 -failfast -run TestDHT_SearchValue_quorum_test_suite without any failures.

My system:

14:48 $ uname -a
Linux astrolith 6.1.0-10-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.38-1 (2023-07-14) x86_64 GNU/Linux

@dennis-tra
Copy link
Contributor

Yeah, it's also working fine on my machine... I tried to change the local dial timeout in #50. Tests are running currently. Let's see if that helped.

@dennis-tra dennis-tra mentioned this issue Oct 5, 2023
Merged
dennis-tra added a commit that referenced this issue Oct 5, 2023
@dennis-tra
fix: flaky test by decreasing local dial timeout (#50)
4a89594 
fixes: #48
@github-project-automation github-project-automation bot moved this from Unplanned to Done in DHT Optimization Oct 5, 2023
@dennis-tra
Copy link
Contributor

was auto-closed because I mentioned it in the pull request. Can reopen if the problem persists

@iand iand reopened this Oct 5, 2023
@iand
Copy link
Contributor Author

iand commented Oct 5, 2023

Flaked again on this documentation-only PR: https://github.com/plprobelab/zikade/actions/runs/6423207647/job/17441233868?pr=52

This was referenced Oct 6, 2023
Merged
Merged
dennis-tra added a commit that referenced this issue Oct 6, 2023
@dennis-tra
Apply dial timeout globally (#54)
43c7867 
Context:
- libp2p/go-libp2p#2595
- #48
@dennis-tra dennis-tra reopened this Oct 10, 2023
@dennis-tra
Copy link
Contributor

Happened again: https://github.com/plprobelab/zikade/actions/runs/6459054917/job/17534078617?pr=60

This time it's probably a different reason

@iand
Copy link
Contributor Author

iand commented Oct 16, 2023

This hasn't reoccured since we fixed the deadlock in #63

@iand iand closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
DHT Optimization
Archived in project
Milestone
No milestone
2 participants
@iand @dennis-tra