Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test by decreasing local dial timeout #50

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: flaky test by decreasing local dial timeout #50

merged 2 commits into from
Oct 5, 2023

Conversation

dennis-tra
Copy link
Contributor

@dennis-tra dennis-tra commented Oct 5, 2023 •
edited
Loading

fixes: #48

@dennis-tra dennis-tra mentioned this pull request Oct 5, 2023
Closed
@dennis-tra dennis-tra marked this pull request as ready for review October 5, 2023 14:14
dennis-tra
dennis-tra commented Oct 5, 2023
View reviewed changes
topology_test.go Outdated Show resolved Hide resolved
@dennis-tra dennis-tra changed the title fix: flaky test by delaying connections fix: flaky test by decreasing local dial timeout Oct 5, 2023
@dennis-tra dennis-tra merged commit 4a89594 into main Oct 5, 2023
7 checks passed
@dennis-tra dennis-tra deleted the fix-failing-test branch October 5, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iand iand iand approved these changes

@guillaumemichel guillaumemichel Awaiting requested review from guillaumemichel guillaumemichel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
DHT Optimization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaking test: TestDHT_SearchValue_quorum_test_suite/TestQuorumReachedPrematurely
2 participants
@dennis-tra @iand