-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ARIA labels in Toolbar #1537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
ARIA labels in Toolbar #1537
Changes from 21 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2fda172
Minimal Viable Navigation Menu
oruburos 8f90cf7
Minimal Viable Navigation Menu
oruburos fc7e3cd
Translation.json : Changes in translation for new namespace
oruburos 02e6cef
Voice Over Labels in Preferences:index
oruburos 11145cc
Voice Over Labels in Preferences:index
oruburos 11941b7
Voice Over Labels in Preferences:index
oruburos 63d2913
Voice Over Labels in Preferences:index
oruburos b3606c9
translations.json ARIA labels adjacent to respective label
oruburos 3bce95c
Merge remote-tracking branch 'remotes/upstream/develop' into minimal_nav
oruburos 2fc71c1
Update Nav.jsx
oruburos 1e809a9
Update Toolbar.test.jsx
oruburos 118741a
Update in keys
oruburos eca1d3b
Merge branch 'minimal_nav' of https://github.com/oruburos/p5.js-web-e…
oruburos 563f296
Merge branch 'develop' into minimal_nav
andrewn da14c10
Jest test v2
oruburos 8877f5f
Jest test v3
oruburos 6a077d6
Toolbar test entries for Toolbar
oruburos bd0a266
Merge remote-tracking branch 'origin/minimal_nav' into minimal_nav_2
oruburos b1d75f9
Merge remote-tracking branch 'remotes/upstream/develop' into minimal_…
oruburos cfab815
Merge remote-tracking branch 'remotes/upstream/develop' into minimal_…
oruburos 73b314f
Aria labels in toolbar
oruburos 270337e
Toolbar using props t.
oruburos 3253458
Toolbar using props t.
oruburos eb7741f
Merge branch 'develop' into minimal_nav
andrewn 3cb1b9a
Merge branch 'develop' into minimal_nav
andrewn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import i18n from 'i18next'; | ||
| import translationEnglish from '../translations/locales/en-US/translations.json'; | ||
|
|
||
| i18n | ||
| .init({ | ||
| fallbackLng: 'en', | ||
| lng: 'en-US', | ||
| ns: ['translations'], | ||
| defaultNS: ['translations'], | ||
| debug: false, | ||
| saveMissing: false, | ||
| interpolation: { | ||
| escapeValue: false, // react already safes from xss | ||
| }, | ||
| resources: { | ||
| en: { | ||
| translations: translationEnglish | ||
| } | ||
| }, | ||
| react: { | ||
| wait: false, | ||
| nsMode: 'fallback' | ||
| } | ||
| }); | ||
| export default i18n; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,8 @@ | ||
| import React from 'react'; | ||
| import { fireEvent, render, screen, waitFor } from '@testing-library/react'; | ||
| import lodash from 'lodash'; | ||
|
|
||
|
|
||
| import { ToolbarComponent } from './Toolbar'; | ||
| import { i18ntest } from '../../../i18n-test'; | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you're not using the
|
||
|
|
||
| const renderComponent = (extraProps = {}) => { | ||
| const props = lodash.merge({ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use
withTranslation()here. The react-i18next documentation doesn't mention the method you're using here at all which makes me concerned about using it.All of these can be
this.props.t('...')