ARIA labels in Toolbar #1537
Closed
ARIA labels in Toolbar #1537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translation with new namespace I18Next configuration leaning on default separator and namespace Broom: i18n + debug:false
Test entry for Toolbar.test.jsx
About : broom About lines 17-26 Nav component : changes in keys KeyboardShortcutModal.jsx: Key now in Common
Labels included in translations.json
Labels included in translations.json
Labels included in translations.json
Labels included in translations.json Snapshot updated npm run test -- -u
Updated names to call the labels Common namespace without currently used entries
Missing Common.p5logoARIA key
Deleting commented line 78
…nav_2 # Conflicts: # client/modules/IDE/components/Toolbar.jsx
andrewn
suggested changes
Aug 11, 2020
|
|
||
|
|
||
| import { ToolbarComponent } from './Toolbar'; | ||
| import { i18ntest } from '../../../i18n-test'; |
Member
There was a problem hiding this comment.
If you're not using the i18ntest variable, then there's no need to assign it here. You can just do this:
import '../../../i18n-test';
| this.props.setGridOutput(true); | ||
| }} | ||
| aria-label="Play sketch" | ||
| aria-label={i18n.t('Toolbar.PlaySketchARIA')} |
Member
There was a problem hiding this comment.
I think we should use withTranslation() here. The react-i18next documentation doesn't mention the method you're using here at all which makes me concerned about using it.
All of these can be this.props.t('...')
3 tasks
Collaborator
Author
|
@andrewn I made the changes requested, but the tests are failing in toolbar.test, do you have an idea what could fix this? Can you take a look please? |
2 tasks
3 tasks
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint)This pull request: