-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Extract translation keys for Console, Sidebar, FileNode #1549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract translation keys for Console, Sidebar, FileNode #1549
Conversation
- Fixes typo with "Close file contents", should be "folder" - Creates Common.DeleteConfirmation as it's used in many places in the app
|
I think that the check is failing because the FileNode.test have a problem. It is related to #1537 and how to mock the t function in the tests. |
|
@oruburos I've fixed the failing tests by mocking We'll probably want to re-visit this in future and use i18next directly, but I think this is good enough for now as it unblocks the translation work. |
|
Yes, this works! |
Great! Can you approve this PR and I'll merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it works as it is , but placing the following entries in the translation spanish file I'd say that is the next step, I don't know if request a change or wait for a next PR:
"Sidebar": {
"Title": "Archivos del bosquejo",
"ToggleARIA": "Alternar abrir/cerrar opciones del bosquejo",
"AddFolder": "Crear directorio",
"AddFolderARIA": "Crear directorio",
"AddFile": "Agregar archivo",
"AddFileARIA": "agregar archivo",
"UploadFile": "Subir archivo",
"UploadFileARIA": "Subir archivo"
},
"FileNode": {
"OpenFolderARIA": "Abrir contenido del directorio",
"CloseFolderARIA": "Cerrar contenido del directorio",
"ToggleFileOptionsARIA": "Alternar abrir/cerrar opciones del bosquejo",
"AddFolder": "Crear directorio",
"AddFolderARIA": "Crear directorio",
"AddFile": "Agregar archivo",
"AddFileARIA": "agregar archivo",
"UploadFile": "Subir archivo",
"UploadFileARIA": "Subir archivo",
"Rename": "Renombrar",
"Delete": "Borrar"
},
|
This PR is about extracting the English text and getting it ready for Spanish translations. If you approve it, I can then merge it and you can do a follow-up PR with the Spanish translations. |
|
FYI: |
This extracts the UI text for Console, Sidebar and FileNode components in English, ready for Spanish translations.
I extracted
Common.DeleteConfirmationas I know that the same language is used in many places in the app.There's some duplication with the "add file/folder" entries in Sidebar/FileNode. If we want them to share a translation entry in future then they should use a shared component. For now, this is fine.
@oruburos Can you review this please?
--
I have verified that this pull request:
npm run lint)