-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Spanish translation: Editor- Editor Accessibility- Timer #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Translation is partially resolved ( 4/5) due to conflict with date-fns/distance_in_words_to_now
…ranslation # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
|
@andrewn Can you have a look at this, please? |
|
@oruburos Can you fix the merge conflicts please? |
andrewn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
This looks good, just noticed in Editor.jsx: this._cm.on('keyup', () => {
const temp = `line ${parseInt((this._cm.getCursor().line) + 1, 10)}`;
document.getElementById('current-line').innerHTML = temp;
});This inserts "line 6" into the DOM for screenreaders to discover, so this should also be translated. If you'd like to do this in another PR, then can you open an issue so we don't forget. |
…ranslation # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
|
@andrewn, I've merged the conflicts and introduced the code to complete the keyUp functionality regarding #1567 (comment) , I edited this comment, I pushed again my branch and all the checks have passed |
andrewn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I have verified that this pull request:
npm run lint)It also includes the Spanish translation to complete #1549