Spanish Translation Modals for Sketch Menu #1538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translations.json (both languages EN - ES) changes in NewFileForm.jsx and NewFileModal.jsx to link the new keys.
translations.json (both languages EN - ES) changes in NewFileForm.jsx and NewFileModal.jsx to link the new keys.
oruburos
changed the title
andrewn
reviewed
Aug 11, 2020
| id="name" | ||
| type="text" | ||
| placeholder="Name" | ||
| placeholder={i18n.t('NewFileForm.Placeholder')} |
Member
There was a problem hiding this comment.
Same comments as in #1537. In components, let's try and use withTranslation.
The validate() function is a good case for using the i18next.t() function directly but here it should be this.props.t().
Collaborator
Author
|
@andrewn I made the changes requested. The problem was also present in the Folder modal. Can you take a look, please? |
andrewn
approved these changes
Aug 11, 2020
Member
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
npm run lint)