Use translations for all tests #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All tests should import the 'test-utils' file which re-exports all of the @testing-library functions. It wraps render() in a react-i18next instance. It's important that the component being tested is the one returned from withTranslation().
3 tasks
Member
Author
|
@oruburos Can you review this please |
oruburos
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refine's @oruburos' PR #1537 to ensure that all Jest tests using React testing-library can access the
en-UStranslations.This is good because we want to be testing against how user's see the app e.g. "click the button with label Play sketch".
It also uses translated ARIA Labels in the Toolbar (which causes the tests to fail in the first place).
I have verified that this pull request:
npm run lint)