pr05 Typescript Migration #10: Setup Server TS Dependencies & migrate instance of server file #3636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver folder ts extensions after client folder
clairep94
changed the title
khanniie
reviewed
Sep 10, 2025
| @@ -5,12 +5,10 @@ | |||
| * @param {String} string | |||
| * @param {String} replacer (optional) character to replace invalid characters | |||
| */ | |||
| function generateFileSystemSafeName(string, replacer) { | |||
| export function generateFileSystemSafeName(string: string, replacer: string) { | |||
There was a problem hiding this comment.
is there any way we can rename this from string to something else? i assume it's not causing a bug but it just makes me nervous haha
There was a problem hiding this comment.
Maybe "unsafeName" or more general, like "name"?
| window.process.env.UPLOAD_LIMIT = ${process.env.UPLOAD_LIMIT ? `${process.env.UPLOAD_LIMIT}` : undefined}; | ||
| window.process.env.TRANSLATIONS_ENABLED = ${process.env.TRANSLATIONS_ENABLED === 'true' ? true : false}; | ||
| window.process.env.LOGIN_ENABLED = ${ | ||
| process.env.LOGIN_ENABLED !== 'false' |
There was a problem hiding this comment.
no big deal either way but would you want to use the helper utils you wrote for this case & the ones below?
the only thing is you'd have to move the utility file into common/
raclim
reviewed
Sep 11, 2025
| "target": "ES2022", | ||
| "module": "commonjs", | ||
| "lib": ["ES2022"], | ||
| "types": ["node", "jest"], |
There was a problem hiding this comment.
This doesn't need to be changed at all, but just wanted to add a super small style note that the repo’s convention is to skip trailing commas!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr05 Typescript Migration 10: Set up TS dependencies to the server folder & migrate an instance of the server folder.
Changes:
typecheck:serverto package.json commandsOther: