Skip to content

pr05 Typescript Migration #12: Migrate server/mail system #3648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

pr05 Typescript Migration #12: Migrate server/mail system #3648

wants to merge 14 commits into from

Conversation

clairep94
Copy link
Collaborator

@clairep94 clairep94 commented Sep 15, 2025 •
edited
Loading

pr05 Typescript Migration 12: Migrate server files related to emailing/nodemailer

Should be reviewed after #3636

Changes:

  • Migrate /server/views files related to emailing
  • Migrate /server/utils/mail
  • Extract types to /server/types/email.ts from existing logic & nodemailer types

Other:

  • Took a look at /migrations/emailConsolidation, but this requires the User and Project models to be migrated first, which I'll do next

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@clairep94 clairep94 changed the title Pr05/migrate mail system Pr05/migrate server/mail system Sep 15, 2025
@clairep94 clairep94 added the pr05 Grant Projects pr05 Grant Projects label Sep 15, 2025
@clairep94 clairep94 marked this pull request as ready for review September 15, 2025 22:26
@clairep94 clairep94 changed the title Pr05/migrate server/mail system pr05 Typescript Migration #13: Migrate server/mail system Sep 15, 2025
@clairep94 clairep94 changed the title pr05 Typescript Migration #13: Migrate server/mail system pr05 Typescript Migration #12: Migrate server/mail system Sep 15, 2025
@clairep94
Copy link
Collaborator Author

@raclim @khanniie Ready for review after the TS dependencies PR is merged

khanniie
khanniie previously approved these changes Sep 23, 2025
View reviewed changes
Copy link
Member

@khanniie khanniie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work!!

server/utils/renderMjml.ts
} catch (e) {
console.error(e);
// fall through to undefined (null is not valid for nodemailer.SendMailOptions.html)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit but can we explicitly return undefined?

@khanniie khanniie requested a review from raclim September 23, 2025 05:54
@clairep94 clairep94 mentioned this pull request Sep 25, 2025
Merged
7 tasks
@clairep94
Copy link
Collaborator Author

please see rebuilt here:

#3658

@clairep94 clairep94 closed this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanniie khanniie khanniie left review comments

@raclim raclim Awaiting requested review from raclim

Assignees
No one assigned
Labels
pr05 Grant Projects pr05 Grant Projects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clairep94 @khanniie