-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-text search #1018
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Yes! From 2018-12-20 meeting: We need to develop user stories to help guide our implementation:
other ?s
|
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
From 2020-03-19 call: The big bottleneck for creating FTS is generating the textual index object. The pure "Jekyll" way of doing this is to have the user's browser create this index on the fly. However, our texts are too long and numerous - this caused our browsers to hang and crash. We sketched out an alternative solution:
@ZoeLeBlanc will generate 1 and 2 and a mockup of 3 by the next @programminghistorian/technical-team meeting in April for initial feedback. |
For hosting the built index, perhaps we just push it to a separate GH pages site? https://docs.travis-ci.com/user/deployment/pages/ |
Also suggest that we use https://docs.travis-ci.com/user/cron-jobs to periodically re-generate the index |
@mdlincoln pretty much finished 1 & 2 of the list, but ofc a few unforeseen issues that could use your input 👇 So for 1. I need the site to actually build the search json files for en, es, fr (though code is now in branch issue-1018), but that will only happen if my PR gets merged in right? Then for 2. Once I merge in issue-1018, then I need to update the code in the search-index repo to actually read the updated json files (though that should take two minutes to add). Otherwise cron job is setup on travis and search-index repo is working with to deploy the search indexes 🎉 (can see the file here https://github.com/programminghistorian/search-index/tree/master/indices) Thanks for your help 😊 |
@ZoeLeBlanc Sure, open up a PR from the |
https://github.com/programminghistorian/jekyll/compare/issue-1018 did something odd happen to the permissions or something on your files? This comparison shows you've touched every single file! Might be better to open a fresh branch and re-do the JSON :/ |
@mdlincoln super weird that happened but thanks for catching it! I just recreated the branch and files, and made a PR. Thanks!! |
so a bit of a crazy update for you @mdlincoln. I hadn't really looked into List.js at all before this (docs are here https://listjs.com/) and turns out it has some search functionality already built-in. So I decided to try it out with our current structure and it seems to work 😅. I just pushed up branch search-1018 and if you pull that down, you should be able to search on each language-specific lessons page. Right now I'm searching the abstract, title, and contents of each lesson, but we could switch that up with barely any additional logic. Let me know what you think but this might be a lightweight enough solution to use instead of going ahead with Lunr 😄 |
HUH that is... quite impressive! It's like a ctrl-F for the lesson content. Looks like the drawbacks are:
But I like that this keeps the architecture super simple and we wouldn't need to go around building indices with a separate service. It also seems to hook nicely into the existing facet buttons. Make a PR of this so we can all give it a try? |
Link to PR here #1720 I wrote this in the PR note but a few things to consider/test.
Let me know if fuzzySearch works for you and I might test writing out the Lunr example with List.js, just so we can compare 😄 |
I think seeing a comparison using the Lunr code would be very useful for the tech team - would you be able to create a separate PR using Lunr instead? |
This ticket has been open for a while now, are there any pending actions here? The full-text search using listjs ticket is closed, can be close this one too? |
The active PR is #1726 this issue is very much active |
Based off of the Community Survey - we had several readers note that there's no easy way to search the website to find lessons. Is this possible? If so, is it hard? If not, what's the possibility of us implementing search capabilities?
On a related note - improving browsing and filtering. Some folks noted that it's not always easy to find things under specific filter headings.
The text was updated successfully, but these errors were encountered: