Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full-text search using listjs #1720

Closed
wants to merge 2 commits into from
Closed

full-text search using listjs #1720

wants to merge 2 commits into from

Conversation

ZoeLeBlanc
Copy link
Member

@ZoeLeBlanc ZoeLeBlanc commented Mar 22, 2020

Testing out List.js built in search functionality. Try typing in the lessons main page to filter on lesson content (we could also add other fields but figured content made the most sense).

Few notes:

  • I added a comment with the fuzzySearch method, so maybe try that method as well. Though I get fewer hits with it than with the search one 🤔
  • We could also still use Lunr.js or build our own fuzzySearch method, and then use List.js filtering to keep our current architecture.
  • Do we still want keyword in context?

Checklist

If you are having difficulty fixing Travis errors, first consult https://github.com/programminghistorian/jekyll/wiki/Making-Technical-Contributions carefully, especially "Common Travis Errors". Then contact the technical team if you need further help.

@ZoeLeBlanc ZoeLeBlanc self-assigned this Mar 22, 2020
@ZoeLeBlanc ZoeLeBlanc mentioned this pull request Mar 22, 2020
@mdlincoln mdlincoln changed the title Search 1018 full-text search using listjs Mar 23, 2020
@mdlincoln mdlincoln marked this pull request as draft April 12, 2020 17:28
@mdlincoln
Copy link
Contributor

2020-04-13 we decided to use the lunrjs version instead. Closing this!

@mdlincoln mdlincoln closed this Apr 13, 2020
@mdlincoln mdlincoln deleted the search-1018 branch June 3, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants