-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Condense multiple translation links for a lesson into one banner #1738
Comments
This is the relevant code: Lines 186 to 203 in eeb6e18
|
@amsichani I'm going to put you on this since its closely related to #1525 - as you can see, you will just need to edit a tiny bit of HTML for this. Go ahead and make a PR for this now, doesn't need to wait for everything else to be finished. |
@mdlincoln I am not on a race with myself on making you hate me, BUT I am going to suggest something that I believe is easy (on the snippets) and I guess I'll have to change it myself. As the banners are right now, in general, they are fine "this lesson is also: title in x lang". Now, from a language accessibility perspective, you would have "message in x language; title in x lang." I propose:
@amsichani what do you think? does it make sense to you as also a multilingual speaker? |
If you and @amsichani like it then make a PR and let's see what it looks like. |
Hi @jenniferisasi , what you are suggesting makes perfect sense to me and thanks for pointing it out. I am happy to collaborate on this. Just to make it clear , there are two tasks here:
Let's start with 1 and continue with 2. |
Put all of the various translation links into a single banner.
I will now close this as the information and discussion is now on #1767 |
This is a visual change: we would like to put all of the various translation links into a single banner. This will mean editing _layouts/lesson.html to put every "related translation" link into the same
div
The text was updated successfully, but these errors were encountered: