-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place multiple translations into one banner #1738 #1749
Conversation
Put all of the various translation links into a single banner.
I have now edit also the code in order to change the language of the messages (source lesson and translated lesson) in the landing pages. We decided not to change the snippets but instead to slightly amend the syntax of the messages -lets see if it works! |
Right: the translations show in one single banner now.
Wrong: the message is showing twice; the name of the language is in English.
Also, now the message of the original source is not showing on the translated lessons: Also, I think you deleted the banner for donations? Will look at it again with this issues in mind. |
Comment in progress while I solve the issues to avoid doing multiple individual changes and using it as a learning process.
Because in the snippets, |
Thanks for this change and for the work you've put into it. Just thinking ahead a little, this might eventually get quite long (3 possible translations per lesson). Are there visual ways we might consider to make it a bit less text heavy, with that future in mind? I'm thinking using the ES FR EN icons perhaps, but defer to your expertise. |
Right @acrymble, it would eventually have any combination of the following: When a lesson is translated, the user can switch language already using the EN|ES|FR bar above... but with no indication of availability there. Maybe a banner with something like: Original: EN; traducida: ES; traduite: FR; traduzida: PT It's missing the titles, which was a nice touch. Before I procede with any changes now, @amsichani @programminghistorian/global-team what do you think? |
1. Put back the donation banner. 2. change the div tags to attempt to have only one banner for originals and translations. 3. deleted a duplicate that was duplicating messages in banners
Attempt at fixing missing banner and non-matching languages
Hm I am a little confused reading the comments here what the end goal is? Could you draw a little diagram, maybe even a box like this:
to explain your end goal layout? Then it will be easier to figure out how to edit the original template. |
@mdlincoln yes, let me try - and thanks for checking on us: On the original lesson:
On a translated lesson:
Makes better sense? |
Cool. First, get the html working again so everything is in one banner. Then: remember that If you need to close this PR and start over from the base code, that would be preferable to trying to re-commit it. |
sorry I ve missed the late night (for me!) party! thanks @mdlincoln for your magic touch ! As far as I can see @jenniferisasi you ve already made the changes- the only bit we need to amend is to include all the translations into one banner - is that right? |
@mdlincoln yes, exactly. And as you can see, I/we changed in the Now, would that also work on for the original or @amsichani this is the one change missing, to have the sentence about the original language of the lesson in its original language; then yes, only the html to put all in a single banner. |
As I noted in #1751 that hardcoded |
Following up on my message yesterday @amsichani @jenniferisasi - please try to consolidate this, #1751, #1738 (and maybe #1525?) into one issue/PR pair, with the most up-to-date ideas and decisions you two have made. I'm concerned that all these tasks seem to have halted forward progress. Please contact me if you need any direct help! |
thanks for these comments @mdlincoln . I will now close this as the information and discussion is now on #1767 and will eventually open a new PR(s). |
This is mainly a layout issue #1738 - put all of the various translation links of a lesson into a single banner.
Let's wait before we merged it, as its linked to the second part of #1738 : a language accessibility perspective "message in x language; title in x lang." I am also working on it and will make a different PR asap.