Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link checker to ignore blog #2106

Closed
acrymble opened this issue Apr 8, 2021 · 4 comments · Fixed by #2140
Closed

link checker to ignore blog #2106

acrymble opened this issue Apr 8, 2021 · 4 comments · Fixed by #2140

Comments

@acrymble
Copy link

acrymble commented Apr 8, 2021

Can we please have our link checking service that activates on pull requests just ignore broken links in the blog? They aren't really core maintenance priorities and they really slow down simple updates. Asking @programminghistorian/technical-team if this is easy to do?

@walshbr
Copy link
Contributor

walshbr commented Apr 8, 2021

I think that should be possible. Does that make sense for you @ZoeLeBlanc?

@acrymble
Copy link
Author

I think this is becoming a larger issue that needs re-thinking. We've now got problems of retired lessons also being checked, and the burden of fixing these is unequally falling on some people.

It's contributing to a long backlog of pull requests not getting actioned, and it's really part of our lesson maintenance commitment, not our day-to-day updating the website with simple changes workflow.

Can we think about changing this to a monthly task or similar - specifically with regards to broken links, which are 90% of these problems. @programminghistorian/technical-team

@drjwbaker
Copy link
Member

@acrymble See also #2030 There are related issues here.

@ZoeLeBlanc
Copy link
Member

We can have the link checker ignore the blog though we should probably add some documentation somewhere that those links may or may not work. It's also turning out that there's some issues into how we formatted the link checker so trying to fix it now and hopefully that will solve some of this backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants