Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoupdate dependencies #367

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

akri-bot
Copy link
Collaborator

@akri-bot akri-bot commented Sep 1, 2021

Auto-generated pull request.
This pull request is generated by GitHub action based on the provided update commands.

@kate-goldenring
Copy link
Contributor

If none of our .toml files are updated by this run, is it safe to close out the PR? It seems that the next person who puts in changes would automatically cause these lock file changes anyways. @romoh for thoughts?

@jiria
Copy link
Contributor

jiria commented Sep 1, 2021 via email

@romoh
Copy link
Contributor

romoh commented Sep 2, 2021

If some of these minor changes were CVE fixes, would we not good to get these updated so that our build uses the latest? Or are did the build already use the latest, just the lock file was not refreshed in the repo? Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows From: Kate @.> Sent: Wednesday, September 1, 2021 10:35 AM To: @.> Cc: Jiri @.>; Review @.> Subject: Re: [deislabs/akri] Autoupdate dependencies (#367) If none of our .toml files are updated by this run, is it safe to close out the PR? It seems that the next person who puts in changes would automatically cause these lock file changes anyways.

If none of our .toml files are updated by this run, is it safe to close out the PR? It seems that the next person who puts in changes would automatically cause these lock file changes anyways. @romoh for thoughts?

cargo lock version changes don't happen automatically unless someone runs cargo update. @jiria is correct in terms of using the latest versions with bug fixes only when the cargo.lock is updated. cargo update follow semver so it would stay within constraints defined in the cargo.toml files.
If we want our cargo.toml to be also updated and be in sync with cargo.lock, I can update our update command to include toml file changes as well. Opened #369 to track this.

@kate-goldenring
Copy link
Contributor

Should we close this in favor of #370?

@romoh
Copy link
Contributor

romoh commented Sep 2, 2021

Should we close this in favor of #370?

We can keep it and I can manually re-run the task after I check-in #370 to update the toml files too.

@akri-bot akri-bot force-pushed the automated-dependencies-update branch from e9941e4 to ffba061 Compare September 2, 2021 16:03
@romoh
Copy link
Contributor

romoh commented Sep 2, 2021

Should we close this in favor of #370?

We can keep it and I can manually re-run the task after I check-in #370 to update the toml files too.

@kate-goldenring Latest update has the toml files included now as well.

agent/Cargo.toml Outdated Show resolved Hide resolved
@akri-bot akri-bot force-pushed the automated-dependencies-update branch from ffba061 to 04c6291 Compare October 1, 2021 00:18
@romoh romoh self-requested a review October 27, 2021 21:03
@akri-bot akri-bot force-pushed the automated-dependencies-update branch from 04c6291 to b9f592e Compare October 27, 2021 21:09
@kate-goldenring kate-goldenring merged commit 8d74f80 into main Oct 27, 2021
@kate-goldenring kate-goldenring deleted the automated-dependencies-update branch October 27, 2021 21:47
vincepnguyen pushed a commit that referenced this pull request Nov 23, 2021
Co-authored-by: romoh <noreply@github.com>
Signed-off-by: vincepnguyen <70007233+vincepnguyen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants