Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out who is responsible for handling checking #12437

Closed
todo bot opened this issue Dec 1, 2021 · 1 comment · Fixed by #14761
Closed

Figure out who is responsible for handling checking #12437

todo bot opened this issue Dec 1, 2021 · 1 comment · Fixed by #14761
Assignees
@bzbarsky-apple
Labels
Interaction Model Work todo

Comments

@todo
Copy link

todo bot commented Dec 1, 2021

connectedhomeip/src/app/InteractionModelEngine.cpp

Lines 589 to 594 in bd94a78

// TODO: Figure out who is responsible for handling checking
// apCommandObj->IsTimedInvoke() for commands that require a timed
// invoke and have a CommandHandlerInterface handling them.
CommandHandlerInterface::HandlerContext context(apCommandObj, aCommandPath, apPayload);
handler->InvokeCommand(context);

This issue was generated by todo based on a TODO comment in bd94a78 when #12389 was merged. cc @bzbarsky-apple.
@todo todo bot added the todo label Dec 1, 2021
@bzbarsky-apple
Copy link
Contributor

This still needs to be fixed.

@bzbarsky-apple bzbarsky-apple reopened this Feb 3, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 3, 2022
@bzbarsky-apple
Fix checking for required timed invoke for commands.
81160ef 
We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes project-chip#12437
@bzbarsky-apple bzbarsky-apple mentioned this issue Feb 3, 2022
Merged
woody-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 4, 2022
@bzbarsky-apple
Fix checking for required timed invoke for commands.
8d613dc 
We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes project-chip#12437
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 4, 2022
@bzbarsky-apple
Fix checking for required timed invoke for commands.
64eba45 
We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes project-chip#12437
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Feb 4, 2022
@bzbarsky-apple
Fix checking for required timed invoke for commands.
3b0527a 
We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes project-chip#12437
vivien-apple pushed a commit that referenced this issue Feb 4, 2022
@bzbarsky-apple
Fix checking for required timed invoke for commands. (#14761)
b58dc83 
We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes #12437
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
Interaction Model Work todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix checking for required timed invoke for commands. bzbarsky-apple/connectedhomeip
2 participants
@woody-apple @bzbarsky-apple