Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking for required timed invoke for commands. #14761

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Fix checking for required timed invoke for commands. #14761

merged 1 commit into from
Feb 4, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes #12437

Problem

Not doing "is this ok to do untimed?" checks for commands that are not dispatched via codegen.

Change overview

Move the checks into CommandHandler.

Testing

Verified that existing tests for timed invoke pass.

@boring-cyborg boring-cyborg bot added the app label Feb 3, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022 •
edited
Loading

PR #14761: Size comparison from c91cea8 to 81160ef

Increases (29 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c91cea8 81160ef change % change
cyw30739 light cyw930739m2evb_01 (read/write) 586702 586954 252 0.0
.app_xip_area 493300 493552 252 0.1
lock cyw930739m2evb_01 (read/write) 544602 544858 256 0.0
.app_xip_area 452768 453024 256 0.1
ota-requestor cyw930739m2evb_01 (read/write) 569014 569266 252 0.0
.app_xip_area 467860 468112 252 0.1
efr32 lighting-app BRD4161A (read only) 855952 856144 192 0.0
.text 855944 856136 192 0.0
BRD4161A+rpc (read only) 843320 843496 176 0.0
.text 843312 843488 176 0.0
window-app BRD4161A (read only) 828180 828372 192 0.0
.text 828172 828364 192 0.0
esp32 all-clusters-app c3devkit (read only) 934576 934642 66 0.0
.flash.text 934576 934642 66 0.0
m5stack (read only) 982767 982887 120 0.0
.flash.text 977383 977503 120 0.0
k32w light k32w061+release (read/write) 671016 671256 240 0.0
.text 587508 587748 240 0.0
lock k32w061+release (read/write) 672560 672800 240 0.0
.text 588692 588932 240 0.0
linux chip-tool-ipv6only arm64 (read only) 7164788 7165412 624 0.0
.text 6173076 6173700 624 0.0
thermostat-no-ble arm64 (read only) 2121980 2122572 592 0.0
.text 1772912 1773504 592 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2386272 2386400 128 0.0
.text 1348872 1349000 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2347184 2347440 256 0.0
.text 1309784 1310040 256 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2311176 2311432 256 0.0
.text 1273776 1274032 256 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2301508 2301700 192 0.0
.text 1264080 1264272 192 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 994391 994631 240 0.0
text 677892 678136 244 0.0
nrf52840dk_nrf52840+rpc (read/write) 976267 976507 240 0.0
text 672960 673208 248 0.0
nrf52840dongle_nrf52840 (read/write) 1011043 1011299 256 0.0
text 683344 683592 248 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 903830 904070 240 0.0
text 595576 595824 248 0.0
lock-app nrf52840dk_nrf52840 (read/write) 926495 926751 256 0.0
text 623712 623956 244 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 836766 837006 240 0.0
text 542172 542416 244 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929115 929355 240 0.0
text 626048 626296 248 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924079 924319 240 0.0
text 621988 622236 248 0.0
p6 light-app default (read/write) 2352496 2352672 176 0.0
.text 1310760 1310936 176 0.0
lock-app default (read/write) 2317688 2317864 176 0.0
.text 1275952 1276128 176 0.0
qpg lighting-app qpg6105+debug (read only) 579272 579520 248 0.0
.text 573952 574200 248 0.0
lock-app qpg6105+debug (read only) 525312 525560 248 0.0
.text 519992 520240 248 0.0
telink lighting-app tlsr9518adk80d (read/write) 857886 858150 264 0.0
text 601180 601324 144 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c91cea8 81160ef change % change
cyw30739 light cyw930739m2evb_01 (read/write) 586702 586954 252 0.0
.app_xip_area 493300 493552 252 0.1
.bss 76124 76124 0 0.0
.data 620 620 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 544602 544858 256 0.0
.app_xip_area 452768 453024 256 0.1
.bss 74596 74596 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569014 569266 252 0.0
.app_xip_area 467860 468112 252 0.1
.bss 83588 83588 0 0.0
.data 528 528 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 855952 856144 192 0.0
(read/write) 125880 125880 0 0.0
.bss 123960 123960 0 0.0
.data 1920 1920 0 0.0
.text 855944 856136 192 0.0
BRD4161A+rpc (read only) 843320 843496 176 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2020 2020 0 0.0
.text 843312 843488 176 0.0
window-app BRD4161A (read only) 828180 828372 192 0.0
(read/write) 124520 124520 0 0.0
.bss 122644 122644 0 0.0
.data 1876 1876 0 0.0
.text 828172 828364 192 0.0
esp32 all-clusters-app c3devkit (read only) 934576 934642 66 0.0
(read/write) 1401026 1401026 0 0.0
.dram0.bss 70056 70056 0 0.0
.dram0.data 14268 14268 0 0.0
.flash.rodata 197800 197800 0 0.0
.flash.text 934576 934642 66 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 982767 982887 120 0.0
(read/write) 465388 465388 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34024 34024 0 0.0
.flash.rodata 224420 224420 0 0.0
.flash.text 977383 977503 120 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 671016 671256 240 0.0
.bss 75828 75828 0 0.0
.data 1880 1880 0 0.0
.text 587508 587748 240 0.0
lock k32w061+release (read/write) 672560 672800 240 0.0
.bss 76148 76148 0 0.0
.data 1920 1920 0 0.0
.text 588692 588932 240 0.0
linux chip-tool-ipv6only arm64 (read only) 7164788 7165412 624 0.0
(read/write) 283233 283233 0 0.0
.bss 47457 47457 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 185496 185496 0 0.0
.dynamic 560 560 0 0.0
.got 45376 45376 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390460 390460 0 0.0
.text 6173076 6173700 624 0.0
thermostat-no-ble arm64 (read only) 2121980 2122572 592 0.0
(read/write) 140705 140705 0 0.0
.bss 57745 57745 0 0.0
.data 952 952 0 0.0
.data.rel.ro 74880 74880 0 0.0
.dynamic 560 560 0 0.0
.got 4152 4152 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131116 131116 0 0.0
.text 1772912 1773504 592 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386272 2386400 128 0.0
.bss 188964 188964 0 0.0
.data 5280 5280 0 0.0
.text 1348872 1349000 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347184 2347440 256 0.0
.bss 181072 181072 0 0.0
.data 5592 5592 0 0.0
.text 1309784 1310040 256 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2311176 2311432 256 0.0
.bss 180960 180960 0 0.0
.data 5576 5576 0 0.0
.text 1273776 1274032 256 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301508 2301700 192 0.0
.bss 178244 178244 0 0.0
.data 5392 5392 0 0.0
.text 1264080 1264272 192 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 994391 994631 240 0.0
bss 120540 120540 0 0.0
rodata 117092 117092 0 0.0
text 677892 678136 244 0.0
nrf52840dk_nrf52840+rpc (read/write) 976267 976507 240 0.0
bss 116396 116396 0 0.0
rodata 108480 108480 0 0.0
text 672960 673208 248 0.0
nrf52840dongle_nrf52840 (read/write) 1011043 1011299 256 0.0
bss 121904 121904 0 0.0
rodata 115932 115932 0 0.0
text 683344 683592 248 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 903830 904070 240 0.0
bss 117104 117104 0 0.0
rodata 110384 110384 0 0.0
text 595576 595824 248 0.0
lock-app nrf52840dk_nrf52840 (read/write) 926495 926751 256 0.0
bss 118880 118880 0 0.0
rodata 105444 105444 0 0.0
text 623712 623956 244 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 836766 837006 240 0.0
bss 115472 115472 0 0.0
rodata 98648 98648 0 0.0
text 542172 542416 244 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 929115 929355 240 0.0
bss 118632 118632 0 0.0
rodata 105912 105912 0 0.0
text 626048 626296 248 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 924079 924319 240 0.0
bss 118632 118632 0 0.0
rodata 104916 104916 0 0.0
text 621988 622236 248 0.0
shell nrf52840dk_nrf52840 (read/write) 802571 802571 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535544 535544 0 0.0
p6 all-clusters-app default (read/write) 2447200 2447200 0 0.0
.bss 117124 117124 0 0.0
.data 2568 2568 0 0.0
.text 1405464 1405464 0 0.0
light-app default (read/write) 2352496 2352672 176 0.0
.bss 106268 106268 0 0.0
.data 2432 2432 0 0.0
.text 1310760 1310936 176 0.0
lock-app default (read/write) 2317688 2317864 176 0.0
.bss 105980 105980 0 0.0
.data 2392 2392 0 0.0
.text 1275952 1276128 176 0.0
qpg lighting-app qpg6105+debug (read only) 579272 579520 248 0.0
(read/write) 146936 146936 0 0.0
.bss 88120 88120 0 0.0
.data 1084 1084 0 0.0
.text 573952 574200 248 0.0
lock-app qpg6105+debug (read only) 525312 525560 248 0.0
(read/write) 146936 146936 0 0.0
.bss 87560 87560 0 0.0
.data 1020 1020 0 0.0
.text 519992 520240 248 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 857886 858150 264 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 601180 601324 144 0.0

@bzbarsky-apple
Copy link
Contributor Author

/rebase

@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

PR #14761: Size comparison from 44c2895 to 64eba45

Increases (21 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 44c2895 64eba45 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587130 587354 224 0.0
.app_xip_area 493728 493952 224 0.0
lock cyw930739m2evb_01 (read/write) 545046 545266 220 0.0
.app_xip_area 453204 453424 220 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569418 569670 252 0.0
.app_xip_area 468256 468508 252 0.1
efr32 lighting-app BRD4161A (read only) 856792 856936 144 0.0
.text 856784 856928 144 0.0
BRD4161A+rpc (read only) 844168 844296 128 0.0
.text 844160 844288 128 0.0
window-app BRD4161A (read only) 829012 829156 144 0.0
.text 829004 829148 144 0.0
esp32 all-clusters-app c3devkit (read only) 935314 935380 66 0.0
.flash.text 935314 935380 66 0.0
m5stack (read only) 983359 983467 108 0.0
.flash.text 977975 978083 108 0.0
k32w light k32w061+release (read/write) 671632 671888 256 0.0
.text 588120 588376 256 0.0
lock k32w061+release (read/write) 673220 673428 208 0.0
.text 589348 589556 208 0.0
linux chip-tool-ipv6only arm64 (read only) 7171332 7171956 624 0.0
.text 6179092 6179716 624 0.0
thermostat-no-ble arm64 (read only) 2125964 2126428 464 0.0
.text 1776528 1776992 464 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2386968 2387096 128 0.0
.text 1349568 1349696 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2347552 2347808 256 0.0
.text 1310152 1310408 256 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2311552 2311744 192 0.0
.text 1274152 1274344 192 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2301820 2302076 256 0.0
.text 1264392 1264648 256 0.0
p6 light-app default (read/write) 2353104 2353248 144 0.0
.text 1311368 1311512 144 0.0
lock-app default (read/write) 2318288 2318432 144 0.0
.text 1276552 1276696 144 0.0
qpg lighting-app qpg6105+debug (read only) 579900 580116 216 0.0
.text 574580 574796 216 0.0
lock-app qpg6105+debug (read only) 525972 526188 216 0.0
.text 520652 520868 216 0.0
telink lighting-app tlsr9518adk80d (read/write) 858826 859050 224 0.0
text 601994 602098 104 0.0
Decreases (1 build for p6)
platform target config section 44c2895 64eba45 change % change
p6 all-clusters-app default (read/write) 2448200 2448184 -16 -0.0
.text 1406464 1406448 -16 -0.0
Full report (24 builds for cyw30739, efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
platform target config section 44c2895 64eba45 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587130 587354 224 0.0
.app_xip_area 493728 493952 224 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545046 545266 220 0.0
.app_xip_area 453204 453424 220 0.0
.bss 74596 74596 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569418 569670 252 0.0
.app_xip_area 468256 468508 252 0.1
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 856792 856936 144 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 856784 856928 144 0.0
BRD4161A+rpc (read only) 844168 844296 128 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844160 844288 128 0.0
window-app BRD4161A (read only) 829012 829156 144 0.0
(read/write) 124524 124524 0 0.0
.bss 122644 122644 0 0.0
.data 1880 1880 0 0.0
.text 829004 829148 144 0.0
esp32 all-clusters-app c3devkit (read only) 935314 935380 66 0.0
(read/write) 1401162 1401162 0 0.0
.dram0.bss 70056 70056 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 197920 197920 0 0.0
.flash.text 935314 935380 66 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 983359 983467 108 0.0
(read/write) 465516 465516 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224532 224532 0 0.0
.flash.text 977975 978083 108 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 671632 671888 256 0.0
.bss 75828 75828 0 0.0
.data 1884 1884 0 0.0
.text 588120 588376 256 0.0
lock k32w061+release (read/write) 673220 673428 208 0.0
.bss 76148 76148 0 0.0
.data 1924 1924 0 0.0
.text 589348 589556 208 0.0
linux chip-tool-ipv6only arm64 (read only) 7171332 7171956 624 0.0
(read/write) 283441 283441 0 0.0
.bss 47457 47457 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 185656 185656 0 0.0
.dynamic 560 560 0 0.0
.got 45424 45424 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390508 390508 0 0.0
.text 6179092 6179716 624 0.0
thermostat-no-ble arm64 (read only) 2125964 2126428 464 0.0
(read/write) 140785 140785 0 0.0
.bss 57745 57745 0 0.0
.data 976 976 0 0.0
.data.rel.ro 74928 74928 0 0.0
.dynamic 560 560 0 0.0
.got 4160 4160 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131292 131292 0 0.0
.text 1776528 1776992 464 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386968 2387096 128 0.0
.bss 188964 188964 0 0.0
.data 5296 5296 0 0.0
.text 1349568 1349696 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347552 2347808 256 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310152 1310408 256 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2311552 2311744 192 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274152 1274344 192 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301820 2302076 256 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1264392 1264648 256 0.0
p6 all-clusters-app default (read/write) 2448200 2448184 -16 -0.0
.bss 117124 117124 0 0.0
.data 2584 2584 0 0.0
.text 1406464 1406448 -16 -0.0
light-app default (read/write) 2353104 2353248 144 0.0
.bss 106268 106268 0 0.0
.data 2432 2432 0 0.0
.text 1311368 1311512 144 0.0
lock-app default (read/write) 2318288 2318432 144 0.0
.bss 105980 105980 0 0.0
.data 2392 2392 0 0.0
.text 1276552 1276696 144 0.0
qpg lighting-app qpg6105+debug (read only) 579900 580116 216 0.0
(read/write) 146940 146940 0 0.0
.bss 88120 88120 0 0.0
.data 1088 1088 0 0.0
.text 574580 574796 216 0.0
lock-app qpg6105+debug (read only) 525972 526188 216 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 520652 520868 216 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 858826 859050 224 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 601994 602098 104 0.0

@bzbarsky-apple
Fix checking for required timed invoke for commands.
3b0527a 
We weren't checking it for commands implemented via CommandHandlerInterface.

Fixes project-chip#12437
@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

PR #14761: Size comparison from 1fafe32 to 3b0527a

Increases (38 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1fafe32 3b0527a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587118 587342 224 0.0
.app_xip_area 493716 493940 224 0.0
lock cyw930739m2evb_01 (read/write) 545034 545254 220 0.0
.app_xip_area 453192 453412 220 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569406 569658 252 0.0
.app_xip_area 468244 468496 252 0.1
efr32 lighting-app BRD4161A (read only) 856792 856936 144 0.0
.text 856784 856928 144 0.0
BRD4161A+rpc (read only) 844168 844296 128 0.0
.text 844160 844288 128 0.0
window-app BRD4161A (read only) 828996 829156 160 0.0
.text 828988 829148 160 0.0
esp32 all-clusters-app c3devkit (read only) 935310 935376 66 0.0
.flash.text 935310 935376 66 0.0
m5stack (read only) 983335 983443 108 0.0
.flash.text 977951 978059 108 0.0
k32w light k32w061+release (read/write) 671632 671872 240 0.0
.text 588120 588360 240 0.0
lock k32w061+release (read/write) 673204 673428 224 0.0
.text 589332 589556 224 0.0
linux all-clusters-app debug .rodata 204293 204453 160 0.1
bridge-app debug+rpc (read only) 1698853 1699205 352 0.0
.rodata 139252 139412 160 0.1
.text 1443173 1443365 192 0.0
chip-tool debug (read only) 7223157 7223717 560 0.0
.rodata 407701 407861 160 0.0
.text 6447413 6447813 400 0.0
chip-tool-ipv6only arm64 (read only) 7171332 7171956 624 0.0
.text 6179092 6179716 624 0.0
door-lock-app debug .rodata 172060 172188 128 0.1
lighting-app debug+rpc (read only) 1998641 1998977 336 0.0
.rodata 162001 162161 160 0.1
.text 1681970 1682146 176 0.0
ota-provider-app debug (read only) 1694209 1694593 384 0.0
.rodata 149670 149798 128 0.1
.text 1426370 1426626 256 0.0
ota-requestor-app debug (read only) 1699521 1700065 544 0.0
.rodata 144951 145111 160 0.1
.text 1437650 1438034 384 0.0
shell debug .rodata 205042 205202 160 0.1
thermostat-no-ble arm64 (read only) 2125964 2126444 480 0.0
.text 1776528 1777008 480 0.0
tv-app debug (read only) 2517865 2518041 176 0.0
.rodata 193420 193580 160 0.1
.text 2151266 2151282 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2386968 2387096 128 0.0
.text 1349568 1349696 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2347552 2347744 192 0.0
.text 1310152 1310344 192 0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2311552 2311744 192 0.0
.text 1274152 1274344 192 0.0
shell CY8CPROTO_062_4343W+release (read/write) 2301820 2302076 256 0.0
.text 1264392 1264648 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 997571 997779 208 0.0
text 680936 681148 212 0.0
nrf52840dk_nrf52840+rpc (read/write) 979423 979647 224 0.0
text 675992 676208 216 0.0
nrf52840dongle_nrf52840 (read/write) 1014259 1014467 208 0.0
text 686428 686644 216 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904262 904470 208 0.0
text 595948 596164 216 0.0
lock-app nrf52840dk_nrf52840 (read/write) 929711 929919 208 0.0
text 626796 627008 212 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837238 837446 208 0.0
text 542584 542796 212 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932343 932551 208 0.0
text 629132 629348 216 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927283 927507 224 0.0
text 625072 625288 216 0.0
p6 light-app default (read/write) 2353088 2353232 144 0.0
.text 1311352 1311496 144 0.0
lock-app default (read/write) 2318288 2318432 144 0.0
.text 1276552 1276696 144 0.0
qpg lighting-app qpg6105+debug (read only) 579892 580108 216 0.0
.text 574572 574788 216 0.0
lock-app qpg6105+debug (read only) 525964 526180 216 0.0
.text 520644 520860 216 0.0
telink lighting-app tlsr9518adk80d (read/write) 858818 859042 224 0.0
text 601990 602094 104 0.0
Decreases (3 builds for linux)
platform target config section 1fafe32 3b0527a change % change
linux all-clusters-app debug (read only) 2314145 2314097 -48 -0.0
.text 1947650 1947442 -208 -0.0
door-lock-app debug (read only) 1896153 1896121 -32 -0.0
.text 1575698 1575538 -160 -0.0
shell debug (read only) 2287289 2287225 -64 -0.0
.text 1925970 1925746 -224 -0.0
Full report (43 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 1fafe32 3b0527a change % change
cyw30739 light cyw930739m2evb_01 (read/write) 587118 587342 224 0.0
.app_xip_area 493716 493940 224 0.0
.bss 76124 76124 0 0.0
.data 624 624 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 545034 545254 220 0.0
.app_xip_area 453192 453412 220 0.0
.bss 74596 74596 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 569406 569658 252 0.0
.app_xip_area 468244 468496 252 0.1
.bss 83588 83588 0 0.0
.data 532 532 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 856792 856936 144 0.0
(read/write) 125888 125888 0 0.0
.bss 123960 123960 0 0.0
.data 1924 1924 0 0.0
.text 856784 856928 144 0.0
BRD4161A+rpc (read only) 844168 844296 128 0.0
(read/write) 142544 142544 0 0.0
.bss 140520 140520 0 0.0
.data 2024 2024 0 0.0
.text 844160 844288 128 0.0
window-app BRD4161A (read only) 828996 829156 160 0.0
(read/write) 124524 124524 0 0.0
.bss 122644 122644 0 0.0
.data 1880 1880 0 0.0
.text 828988 829148 160 0.0
esp32 all-clusters-app c3devkit (read only) 935310 935376 66 0.0
(read/write) 1401162 1401162 0 0.0
.dram0.bss 70056 70056 0 0.0
.dram0.data 14276 14276 0 0.0
.flash.rodata 197920 197920 0 0.0
.flash.text 935310 935376 66 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 983335 983443 108 0.0
(read/write) 465516 465516 0 0.0
.dram0.bss 74816 74816 0 0.0
.dram0.data 34040 34040 0 0.0
.flash.rodata 224532 224532 0 0.0
.flash.text 977951 978059 108 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 671632 671872 240 0.0
.bss 75828 75828 0 0.0
.data 1884 1884 0 0.0
.text 588120 588360 240 0.0
lock k32w061+release (read/write) 673204 673428 224 0.0
.bss 76148 76148 0 0.0
.data 1924 1924 0 0.0
.text 589332 589556 224 0.0
linux all-clusters-app debug (read only) 2314145 2314097 -48 -0.0
(read/write) 139968 139968 0 0.0
.bss 54592 54592 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 78472 78472 0 0.0
.dynamic 592 592 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 204293 204453 160 0.1
.text 1947650 1947442 -208 -0.0
bridge-app debug+rpc (read only) 1698853 1699205 352 0.0
(read/write) 84536 84536 0 0.0
.bss 39296 39296 0 0.0
.data 1986 1986 0 0.0
.data.rel.ro 38080 38080 0 0.0
.dynamic 592 592 0 0.0
.got 3976 3976 0 0.0
.init 27 27 0 0.0
.init_array 560 560 0 0.0
.rodata 139252 139412 160 0.1
.text 1443173 1443365 192 0.0
chip-tool debug (read only) 7223157 7223717 560 0.0
(read/write) 180584 180584 0 0.0
.bss 29192 29192 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 144304 144304 0 0.0
.dynamic 608 608 0 0.0
.got 4760 4760 0 0.0
.init 27 27 0 0.0
.init_array 600 600 0 0.0
.rodata 407701 407861 160 0.0
.text 6447413 6447813 400 0.0
chip-tool-ipv6only arm64 (read only) 7171332 7171956 624 0.0
(read/write) 283441 283441 0 0.0
.bss 47457 47457 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 185656 185656 0 0.0
.dynamic 560 560 0 0.0
.got 45424 45424 0 0.0
.init 24 24 0 0.0
.init_array 184 184 0 0.0
.rodata 390508 390508 0 0.0
.text 6179092 6179716 624 0.0
door-lock-app debug (read only) 1896153 1896121 -32 -0.0
(read/write) 110728 110728 0 0.0
.bss 42272 42272 0 0.0
.data 962 962 0 0.0
.data.rel.ro 62064 62064 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 172060 172188 128 0.1
.text 1575698 1575538 -160 -0.0
lighting-app debug+rpc (read only) 1998641 1998977 336 0.0
(read/write) 115784 115784 0 0.0
.bss 43224 43224 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 65680 65680 0 0.0
.dynamic 608 608 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 712 712 0 0.0
.rodata 162001 162161 160 0.1
.text 1681970 1682146 176 0.0
ota-provider-app debug (read only) 1694209 1694593 384 0.0
(read/write) 80592 80592 0 0.0
.bss 41152 41152 0 0.0
.data 1096 1096 0 0.0
.data.rel.ro 32824 32824 0 0.0
.dynamic 608 608 0 0.0
.got 4248 4248 0 0.0
.init 27 27 0 0.0
.init_array 616 616 0 0.0
.rodata 149670 149798 128 0.1
.text 1426370 1426626 256 0.0
ota-requestor-app debug (read only) 1699521 1700065 544 0.0
(read/write) 83512 83512 0 0.0
.bss 42464 42464 0 0.0
.data 1128 1128 0 0.0
.data.rel.ro 34632 34632 0 0.0
.dynamic 592 592 0 0.0
.got 4040 4040 0 0.0
.init 27 27 0 0.0
.init_array 624 624 0 0.0
.rodata 144951 145111 160 0.1
.text 1437650 1438034 384 0.0
shell debug (read only) 2287289 2287225 -64 -0.0
(read/write) 141488 141488 0 0.0
.bss 62016 62016 0 0.0
.data 800 800 0 0.0
.data.rel.ro 72976 72976 0 0.0
.dynamic 592 592 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 205042 205202 160 0.1
.text 1925970 1925746 -224 -0.0
thermostat-no-ble arm64 (read only) 2125964 2126444 480 0.0
(read/write) 140785 140785 0 0.0
.bss 57745 57745 0 0.0
.data 976 976 0 0.0
.data.rel.ro 74928 74928 0 0.0
.dynamic 560 560 0 0.0
.got 4160 4160 0 0.0
.init 24 24 0 0.0
.init_array 336 336 0 0.0
.rodata 131292 131292 0 0.0
.text 1776528 1777008 480 0.0
tv-app debug (read only) 2517865 2518041 176 0.0
(read/write) 139640 139640 0 0.0
.bss 57248 57248 0 0.0
.data 3136 3136 0 0.0
.data.rel.ro 73248 73248 0 0.0
.dynamic 592 592 0 0.0
.got 4528 4528 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 193420 193580 160 0.1
.text 2151266 2151282 16 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2386968 2387096 128 0.0
.bss 188964 188964 0 0.0
.data 5296 5296 0 0.0
.text 1349568 1349696 128 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2347552 2347744 192 0.0
.bss 181072 181072 0 0.0
.data 5600 5600 0 0.0
.text 1310152 1310344 192 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2311552 2311744 192 0.0
.bss 180960 180960 0 0.0
.data 5584 5584 0 0.0
.text 1274152 1274344 192 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139712 1139712 0 0.0
.bss 11756 11756 0 0.0
.data 4368 4368 0 0.0
.text 103096 103096 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2301820 2302076 256 0.0
.bss 178244 178244 0 0.0
.data 5400 5400 0 0.0
.text 1264392 1264648 256 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 997571 997779 208 0.0
bss 120540 120540 0 0.0
rodata 117184 117184 0 0.0
text 680936 681148 212 0.0
nrf52840dk_nrf52840+rpc (read/write) 979423 979647 224 0.0
bss 116396 116396 0 0.0
rodata 108572 108572 0 0.0
text 675992 676208 216 0.0
nrf52840dongle_nrf52840 (read/write) 1014259 1014467 208 0.0
bss 121904 121904 0 0.0
rodata 116020 116020 0 0.0
text 686428 686644 216 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 904262 904470 208 0.0
bss 117104 117104 0 0.0
rodata 110440 110440 0 0.0
text 595948 596164 216 0.0
lock-app nrf52840dk_nrf52840 (read/write) 929711 929919 208 0.0
bss 118880 118880 0 0.0
rodata 105532 105532 0 0.0
text 626796 627008 212 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 837238 837446 208 0.0
bss 115472 115472 0 0.0
rodata 98704 98704 0 0.0
text 542584 542796 212 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 541779 541779 0 0.0
bss 52588 52588 0 0.0
rodata 50048 50048 0 0.0
text 376940 376940 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 932343 932551 208 0.0
bss 118632 118632 0 0.0
rodata 106004 106004 0 0.0
text 629132 629348 216 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 927283 927507 224 0.0
bss 118632 118632 0 0.0
rodata 105008 105008 0 0.0
text 625072 625288 216 0.0
shell nrf52840dk_nrf52840 (read/write) 802571 802571 0 0.0
bss 110968 110968 0 0.0
rodata 78480 78480 0 0.0
text 535544 535544 0 0.0
p6 all-clusters-app default (read/write) 2448184 2448184 0 0.0
.bss 117124 117124 0 0.0
.data 2584 2584 0 0.0
.text 1406448 1406448 0 0.0
light-app default (read/write) 2353088 2353232 144 0.0
.bss 106268 106268 0 0.0
.data 2432 2432 0 0.0
.text 1311352 1311496 144 0.0
lock-app default (read/write) 2318288 2318432 144 0.0
.bss 105980 105980 0 0.0
.data 2392 2392 0 0.0
.text 1276552 1276696 144 0.0
qpg lighting-app qpg6105+debug (read only) 579892 580108 216 0.0
(read/write) 146940 146940 0 0.0
.bss 88120 88120 0 0.0
.data 1088 1088 0 0.0
.text 574572 574788 216 0.0
lock-app qpg6105+debug (read only) 525964 526180 216 0.0
(read/write) 146940 146940 0 0.0
.bss 87560 87560 0 0.0
.data 1024 1024 0 0.0
.text 520644 520860 216 0.0
persistent-storage-app qpg6105+debug (read only) 107140 107140 0 0.0
(read/write) 146940 146940 0 0.0
.bss 38504 38504 0 0.0
.data 288 288 0 0.0
.text 101820 101820 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 858818 859042 224 0.0
bss 88476 88476 0 0.0
noinit 37160 37160 0 0.0
text 601990 602094 104 0.0

@vivien-apple vivien-apple merged commit b58dc83 into project-chip:master Feb 4, 2022
@bzbarsky-apple bzbarsky-apple deleted the timed-invoke-checks branch February 4, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out who is responsible for handling checking
4 participants
@bzbarsky-apple @andy31415 @vivien-apple @jmartinez-silabs