Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused code in SecureSessionTable #11041

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Clean up unused code in SecureSessionTable #11041

merged 1 commit into from
Oct 27, 2021
+130 −337

Conversation

kghost
Copy link
Contributor

@kghost kghost commented Oct 27, 2021

Problem

There are several function is not used anymore in SecureSessionTable

Change overview

  • CreateNewSecureSession always take a valid node id
  • Remove function lookup the table using peer address
  • Rename remaining Connection into Session

Testing

Verified by unit-tests

@restyled-io restyled-io bot mentioned this pull request Oct 27, 2021
Closed
@kghost kghost changed the title Clean up unusded code in SecureSessionTable Clean up unused code in SecureSessionTable Oct 27, 2021
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #11041: Size comparison from 3249310 to 2803c50

Increases (1 build for efr32)
platform target config section 3249310 2803c50 change % change
efr32 window-app BRD4161A (read/write) 113584 113588 4 0.0
Decreases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3249310 2803c50 change % change
efr32 lighting-app BRD4161A (read only) 737104 736904 -200 -0.0
.text 737096 736896 -200 -0.0
BRD4161A+rpc (read only) 724536 724332 -204 -0.0
(read/write) 132052 132048 -4 -0.0
.text 724528 724324 -204 -0.0
lock-app BRD4161A (read only) 716368 716168 -200 -0.0
.text 716360 716160 -200 -0.0
window-app BRD4161A (read only) 717276 717072 -204 -0.0
.text 717268 717064 -204 -0.0
esp32 all-clusters-app c3devkit (read only) 875790 875678 -112 -0.0
.flash.text 875790 875678 -112 -0.0
m5stack (read only) 906891 906767 -124 -0.0
.flash.text 906891 906767 -124 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701000 -96 -0.0
.text 614676 614580 -96 -0.0
lock-app k32w061+debug (read/write) 592900 592804 -96 -0.0
.text 516040 515944 -96 -0.0
shell k32w061+debug (read/write) 425236 425140 -96 -0.0
.text 359604 359508 -96 -0.0
linux all-clusters-app debug (read only) 1634209 1633377 -832 -0.1
.rodata 135541 135477 -64 -0.0
.text 1366930 1366162 -768 -0.1
bridge-app debug+rpc (read only) 1275693 1274861 -832 -0.1
.rodata 110684 110620 -64 -0.1
.text 1069669 1068901 -768 -0.1
chip-tool debug (read only) 4146325 4145413 -912 -0.0
.rodata 210224 210128 -96 -0.0
.text 3677813 3676997 -816 -0.0
lighting-app debug+rpc (read only) 1527209 1526345 -864 -0.1
.rodata 127889 127793 -96 -0.1
.text 1267298 1266530 -768 -0.1
ota-provider-app debug (read only) 1234753 1233921 -832 -0.1
.rodata 110984 110920 -64 -0.1
.text 1027810 1027042 -768 -0.1
ota-requestor-app debug (read only) 1292033 1291185 -848 -0.1
.rodata 127904 127808 -96 -0.1
.text 1066530 1065778 -752 -0.1
shell debug (read only) 778361 777465 -896 -0.1
.rodata 76527 76463 -64 -0.1
.text 600706 599874 -832 -0.1
tv-app debug (read only) 1753753 1752889 -864 -0.0
.rodata 152984 152888 -96 -0.1
.text 1459058 1458290 -768 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288664 2288600 -64 -0.0
.text 1251264 1251200 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2255896 2255832 -64 -0.0
.text 1218496 1218432 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2233928 2233864 -64 -0.0
.text 1196528 1196464 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862871 -96 -0.0
text 577704 577612 -92 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823711 -96 -0.0
text 550896 550804 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 787910 -96 -0.0
text 507176 507084 -92 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839815 -96 -0.0
text 559264 559172 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764858 -96 -0.0
text 488728 488636 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844215 -96 -0.0
text 562368 562276 -92 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839535 -96 -0.0
text 559008 558916 -92 -0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776483 -96 -0.0
text 520368 520276 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691538 -96 -0.0
text 440980 440888 -92 -0.0
p6 lock-app default (read/write) 2169104 2168904 -200 -0.0
.text 1127368 1127168 -200 -0.0
qpg lighting-app qpg6100+debug (read only) 491272 491184 -88 -0.0
.text 485952 485864 -88 -0.0
lock-app qpg6100+debug (read only) 467492 467404 -88 -0.0
.text 462172 462084 -88 -0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664566 -112 -0.0
text 458278 458162 -116 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3249310 2803c50 change % change
efr32 lighting-app BRD4161A (read only) 737104 736904 -200 -0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737096 736896 -200 -0.0
BRD4161A+rpc (read only) 724536 724332 -204 -0.0
(read/write) 132052 132048 -4 -0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724528 724324 -204 -0.0
lock-app BRD4161A (read only) 716368 716168 -200 -0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716360 716160 -200 -0.0
window-app BRD4161A (read only) 717276 717072 -204 -0.0
(read/write) 113584 113588 4 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717268 717064 -204 -0.0
esp32 all-clusters-app c3devkit (read only) 875790 875678 -112 -0.0
(read/write) 1306456 1306456 0 0.0
.dram0.bss 58240 58240 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198520 198520 0 0.0
.flash.text 875790 875678 -112 -0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906891 906767 -124 -0.0
(read/write) 426264 426264 0 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207264 207264 0 0.0
.flash.text 906891 906767 -124 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701000 -96 -0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614676 614580 -96 -0.0
lock-app k32w061+debug (read/write) 592900 592804 -96 -0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516040 515944 -96 -0.0
shell k32w061+debug (read/write) 425236 425140 -96 -0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359604 359508 -96 -0.0
linux all-clusters-app debug (read only) 1634209 1633377 -832 -0.1
(read/write) 117408 117408 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60864 60864 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135477 -64 -0.0
.text 1366930 1366162 -768 -0.1
bridge-app debug+rpc (read only) 1275693 1274861 -832 -0.1
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110620 -64 -0.1
.text 1069669 1068901 -768 -0.1
chip-tool debug (read only) 4146325 4145413 -912 -0.0
(read/write) 120184 120184 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 95520 95520 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 210224 210128 -96 -0.0
.text 3677813 3676997 -816 -0.0
lighting-app debug+rpc (read only) 1527209 1526345 -864 -0.1
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127793 -96 -0.1
.text 1267298 1266530 -768 -0.1
ota-provider-app debug (read only) 1234753 1233921 -832 -0.1
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110920 -64 -0.1
.text 1027810 1027042 -768 -0.1
ota-requestor-app debug (read only) 1292033 1291185 -848 -0.1
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127808 -96 -0.1
.text 1066530 1065778 -752 -0.1
shell debug (read only) 778361 777465 -896 -0.1
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76463 -64 -0.1
.text 600706 599874 -832 -0.1
tv-app debug (read only) 1753753 1752889 -864 -0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152888 -96 -0.1
.text 1459058 1458290 -768 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288664 2288600 -64 -0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251264 1251200 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255896 2255832 -64 -0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218496 1218432 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233928 2233864 -64 -0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196528 1196464 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862871 -96 -0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577704 577612 -92 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823711 -96 -0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550896 550804 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 787910 -96 -0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507176 507084 -92 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839815 -96 -0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559264 559172 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764858 -96 -0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488728 488636 -92 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844215 -96 -0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562368 562276 -92 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839535 -96 -0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559008 558916 -92 -0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776483 -96 -0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520368 520276 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691538 -96 -0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440980 440888 -92 -0.0
p6 lock-app default (read/write) 2169104 2168904 -200 -0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127368 1127168 -200 -0.0
qpg lighting-app qpg6100+debug (read only) 491272 491184 -88 -0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485952 485864 -88 -0.0
lock-app qpg6100+debug (read only) 467492 467404 -88 -0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462172 462084 -88 -0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664566 -112 -0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458278 458162 -116 -0.0

@github-actions
Copy link

Size increase report for "esp32-example-build" from 3249310

File Section File VM
chip-all-clusters-app.elf .flash.text -112 -112
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
[Unmapped],0,112
.shstrtab,0,2
.riscv.attributes,0,-1
.debug_frame,0,-16
.strtab,0,-34
.debug_ranges,0,-112
.flash.text,-112,-112
.debug_loc,0,-123
.debug_line,0,-322
.debug_str,0,-1049
.debug_info,0,-1117

@kghost kghost force-pushed the secure-session-table-clean-up branch from 2803c50 to 0051ada Compare October 27, 2021 12:50
andy31415
andy31415 approved these changes Oct 27, 2021
View reviewed changes
src/app/tests/TestCommandInteraction.cpp Outdated Show resolved Hide resolved
src/transport/tests/TestPeerConnections.cpp Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #11041: Size comparison from 22f8115 to 0051ada

Increases (1 build for efr32)
platform target config section 22f8115 0051ada change % change
efr32 window-app BRD4161A (read/write) 113584 113588 4 0.0
Decreases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22f8115 0051ada change % change
efr32 lighting-app BRD4161A (read only) 737104 736904 -200 -0.0
.text 737096 736896 -200 -0.0
BRD4161A+rpc (read only) 724536 724332 -204 -0.0
(read/write) 132052 132048 -4 -0.0
.text 724528 724324 -204 -0.0
lock-app BRD4161A (read only) 716368 716168 -200 -0.0
.text 716360 716160 -200 -0.0
window-app BRD4161A (read only) 717276 717072 -204 -0.0
.text 717268 717064 -204 -0.0
esp32 all-clusters-app c3devkit (read only) 875790 875678 -112 -0.0
.flash.text 875790 875678 -112 -0.0
m5stack (read only) 906891 906767 -124 -0.0
.flash.text 906891 906767 -124 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701000 -96 -0.0
.text 614676 614580 -96 -0.0
lock-app k32w061+debug (read/write) 592900 592804 -96 -0.0
.text 516040 515944 -96 -0.0
shell k32w061+debug (read/write) 425236 425140 -96 -0.0
.text 359604 359508 -96 -0.0
linux all-clusters-app debug (read only) 1634209 1633377 -832 -0.1
.rodata 135541 135477 -64 -0.0
.text 1366930 1366162 -768 -0.1
bridge-app debug+rpc (read only) 1275693 1274861 -832 -0.1
.rodata 110684 110620 -64 -0.1
.text 1069669 1068901 -768 -0.1
chip-tool debug (read only) 4149509 4148597 -912 -0.0
.rodata 210704 210608 -96 -0.0
.text 3680421 3679605 -816 -0.0
lighting-app debug+rpc (read only) 1527209 1526345 -864 -0.1
.rodata 127889 127793 -96 -0.1
.text 1267298 1266530 -768 -0.1
ota-provider-app debug (read only) 1234753 1233921 -832 -0.1
.rodata 110984 110920 -64 -0.1
.text 1027810 1027042 -768 -0.1
ota-requestor-app debug (read only) 1292033 1291185 -848 -0.1
.rodata 127904 127808 -96 -0.1
.text 1066530 1065778 -752 -0.1
shell debug (read only) 778361 777465 -896 -0.1
.rodata 76527 76463 -64 -0.1
.text 600706 599874 -832 -0.1
tv-app debug (read only) 1753753 1752889 -864 -0.0
.rodata 152984 152888 -96 -0.1
.text 1459058 1458290 -768 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288664 2288600 -64 -0.0
.text 1251264 1251200 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2255896 2255832 -64 -0.0
.text 1218496 1218432 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2233928 2233864 -64 -0.0
.text 1196528 1196464 -64 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862871 -96 -0.0
text 577704 577612 -92 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823711 -96 -0.0
text 550896 550804 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 787910 -96 -0.0
text 507176 507084 -92 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839815 -96 -0.0
text 559264 559172 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764858 -96 -0.0
text 488728 488636 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844215 -96 -0.0
text 562368 562276 -92 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839535 -96 -0.0
text 559008 558916 -92 -0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776483 -96 -0.0
text 520368 520276 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691538 -96 -0.0
text 440980 440888 -92 -0.0
p6 lock-app default (read/write) 2169104 2168904 -200 -0.0
.text 1127368 1127168 -200 -0.0
qpg lighting-app qpg6100+debug (read only) 491272 491184 -88 -0.0
.text 485952 485864 -88 -0.0
lock-app qpg6100+debug (read only) 467492 467404 -88 -0.0
.text 462172 462084 -88 -0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664566 -112 -0.0
text 458278 458162 -116 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22f8115 0051ada change % change
efr32 lighting-app BRD4161A (read only) 737104 736904 -200 -0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737096 736896 -200 -0.0
BRD4161A+rpc (read only) 724536 724332 -204 -0.0
(read/write) 132052 132048 -4 -0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724528 724324 -204 -0.0
lock-app BRD4161A (read only) 716368 716168 -200 -0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716360 716160 -200 -0.0
window-app BRD4161A (read only) 717276 717072 -204 -0.0
(read/write) 113584 113588 4 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717268 717064 -204 -0.0
esp32 all-clusters-app c3devkit (read only) 875790 875678 -112 -0.0
(read/write) 1306456 1306456 0 0.0
.dram0.bss 58240 58240 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198520 198520 0 0.0
.flash.text 875790 875678 -112 -0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906891 906767 -124 -0.0
(read/write) 426264 426264 0 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207264 207264 0 0.0
.flash.text 906891 906767 -124 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701000 -96 -0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614676 614580 -96 -0.0
lock-app k32w061+debug (read/write) 592900 592804 -96 -0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516040 515944 -96 -0.0
shell k32w061+debug (read/write) 425236 425140 -96 -0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359604 359508 -96 -0.0
linux all-clusters-app debug (read only) 1634209 1633377 -832 -0.1
(read/write) 117408 117408 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60864 60864 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135477 -64 -0.0
.text 1366930 1366162 -768 -0.1
bridge-app debug+rpc (read only) 1275693 1274861 -832 -0.1
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110620 -64 -0.1
.text 1069669 1068901 -768 -0.1
chip-tool debug (read only) 4149509 4148597 -912 -0.0
(read/write) 120224 120224 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 95552 95552 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 210704 210608 -96 -0.0
.text 3680421 3679605 -816 -0.0
lighting-app debug+rpc (read only) 1527209 1526345 -864 -0.1
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127793 -96 -0.1
.text 1267298 1266530 -768 -0.1
ota-provider-app debug (read only) 1234753 1233921 -832 -0.1
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110920 -64 -0.1
.text 1027810 1027042 -768 -0.1
ota-requestor-app debug (read only) 1292033 1291185 -848 -0.1
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127808 -96 -0.1
.text 1066530 1065778 -752 -0.1
shell debug (read only) 778361 777465 -896 -0.1
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76463 -64 -0.1
.text 600706 599874 -832 -0.1
tv-app debug (read only) 1753753 1752889 -864 -0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152888 -96 -0.1
.text 1459058 1458290 -768 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288664 2288600 -64 -0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251264 1251200 -64 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255896 2255832 -64 -0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218496 1218432 -64 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233928 2233864 -64 -0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196528 1196464 -64 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862871 -96 -0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577704 577612 -92 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823711 -96 -0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550896 550804 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 787910 -96 -0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507176 507084 -92 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839815 -96 -0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559264 559172 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764858 -96 -0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488728 488636 -92 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844215 -96 -0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562368 562276 -92 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839535 -96 -0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559008 558916 -92 -0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776483 -96 -0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520368 520276 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691538 -96 -0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440980 440888 -92 -0.0
p6 lock-app default (read/write) 2169104 2168904 -200 -0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127368 1127168 -200 -0.0
qpg lighting-app qpg6100+debug (read only) 491272 491184 -88 -0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485952 485864 -88 -0.0
lock-app qpg6100+debug (read only) 467492 467404 -88 -0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462172 462084 -88 -0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664566 -112 -0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458278 458162 -116 -0.0

@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 22f8115

File Section File VM
chip-shell.elf device_handles -4 -4
chip-shell.elf text -92 -92
chip-lock.elf device_handles -4 -4
chip-lock.elf text -92 -92
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.shstrtab,0,-2
.debug_frame,0,-4
device_handles,-4,-4
.debug_abbrev,0,-18
.strtab,0,-22
.debug_ranges,0,-88
text,-92,-92
.debug_line,0,-439
.debug_str,0,-1007
.debug_loc,0,-1057
.debug_info,0,-2131

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.shstrtab,0,-2
.debug_frame,0,-4
device_handles,-4,-4
.debug_abbrev,0,-18
.strtab,0,-34
.debug_ranges,0,-88
text,-92,-92
.debug_line,0,-439
.debug_str,0,-1007
.debug_loc,0,-1089
.debug_info,0,-2131

@kghost kghost force-pushed the secure-session-table-clean-up branch from 0051ada to e50c028 Compare October 27, 2021 14:35
@github-actions
Copy link

github-actions bot commented Oct 27, 2021 •
edited
Loading

PR #11041: Size comparison from 3db0d85 to e50c028

Increases (1 build for efr32)
platform target config section 3db0d85 e50c028 change % change
efr32 window-app BRD4161A (read/write) 113584 113588 4 0.0
Decreases (33 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3db0d85 e50c028 change % change
efr32 lighting-app BRD4161A (read only) 737280 737080 -200 -0.0
.text 737272 737072 -200 -0.0
BRD4161A+rpc (read only) 724712 724508 -204 -0.0
(read/write) 132052 132048 -4 -0.0
.text 724704 724500 -204 -0.0
lock-app BRD4161A (read only) 716544 716344 -200 -0.0
.text 716536 716336 -200 -0.0
window-app BRD4161A (read only) 717468 717264 -204 -0.0
.text 717460 717256 -204 -0.0
esp32 all-clusters-app c3devkit (read only) 876062 875950 -112 -0.0
.flash.text 876062 875950 -112 -0.0
m5stack (read only) 907223 907047 -176 -0.0
.flash.text 907223 907047 -176 -0.0
k32w lighting-app k32w061+se05x+release (read/write) 701256 701160 -96 -0.0
.text 614836 614740 -96 -0.0
lock-app k32w061+debug (read/write) 593060 592964 -96 -0.0
.text 516200 516104 -96 -0.0
shell k32w061+debug (read/write) 425348 425252 -96 -0.0
.text 359716 359620 -96 -0.0
linux all-clusters-app debug (read only) 1636385 1635553 -832 -0.1
.rodata 135541 135477 -64 -0.0
.text 1369106 1368338 -768 -0.1
bridge-app debug+rpc (read only) 1277645 1276829 -816 -0.1
.rodata 110684 110620 -64 -0.1
.text 1071621 1070869 -752 -0.1
chip-tool debug (read only) 4174429 4173517 -912 -0.0
.rodata 212496 212400 -96 -0.0
.text 3702037 3701221 -816 -0.0
lighting-app debug+rpc (read only) 1529385 1528521 -864 -0.1
.rodata 127889 127793 -96 -0.1
.text 1269474 1268706 -768 -0.1
ota-provider-app debug (read only) 1236913 1236097 -816 -0.1
.rodata 110984 110920 -64 -0.1
.text 1029970 1029218 -752 -0.1
ota-requestor-app debug (read only) 1294321 1293473 -848 -0.1
.rodata 127904 127808 -96 -0.1
.text 1068818 1068066 -752 -0.1
shell debug (read only) 780809 779929 -880 -0.1
.rodata 76527 76463 -64 -0.1
.text 603154 602338 -816 -0.1
tv-app debug (read only) 1756201 1755353 -848 -0.0
.rodata 152984 152888 -96 -0.1
.text 1461506 1460754 -752 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288904 2288776 -128 -0.0
.text 1251504 1251376 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read/write) 2256088 2255960 -128 -0.0
.text 1218688 1218560 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read/write) 2234120 2233992 -128 -0.0
.text 1196720 1196592 -128 -0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862983 862903 -80 -0.0
text 577724 577632 -92 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823823 823743 -80 -0.0
text 550916 550824 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788022 787926 -96 -0.0
text 507196 507104 -92 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 839927 839847 -80 -0.0
text 559284 559192 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764970 764874 -96 -0.0
text 488748 488656 -92 -0.0
pump-app nrf52840dk_nrf52840 (read/write) 844327 844247 -80 -0.0
text 562388 562296 -92 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839647 839567 -80 -0.0
text 559028 558936 -92 -0.0
shell nrf52840dk_nrf52840 (read/write) 776531 776435 -96 -0.0
text 520324 520232 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691586 691490 -96 -0.0
text 440936 440844 -92 -0.0
p6 lock-app default (read/write) 2169360 2169160 -200 -0.0
.text 1127624 1127424 -200 -0.0
qpg lighting-app qpg6100+debug (read only) 491416 491328 -88 -0.0
.text 486096 486008 -88 -0.0
lock-app qpg6100+debug (read only) 467636 467548 -88 -0.0
.text 462316 462228 -88 -0.0
telink lighting-app tlsr9518adk80d (read/write) 664718 664606 -112 -0.0
text 458320 458202 -118 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 3db0d85 e50c028 change % change
efr32 lighting-app BRD4161A (read only) 737280 737080 -200 -0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737272 737072 -200 -0.0
BRD4161A+rpc (read only) 724712 724508 -204 -0.0
(read/write) 132052 132048 -4 -0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724704 724500 -204 -0.0
lock-app BRD4161A (read only) 716544 716344 -200 -0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716536 716336 -200 -0.0
window-app BRD4161A (read only) 717468 717264 -204 -0.0
(read/write) 113584 113588 4 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717460 717256 -204 -0.0
esp32 all-clusters-app c3devkit (read only) 876062 875950 -112 -0.0
(read/write) 1306520 1306520 0 0.0
.dram0.bss 58248 58248 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198568 198568 0 0.0
.flash.text 876062 875950 -112 -0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 907223 907047 -176 -0.0
(read/write) 426312 426312 0 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207312 207312 0 0.0
.flash.text 907223 907047 -176 -0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701256 701160 -96 -0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614836 614740 -96 -0.0
lock-app k32w061+debug (read/write) 593060 592964 -96 -0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516200 516104 -96 -0.0
shell k32w061+debug (read/write) 425348 425252 -96 -0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359716 359620 -96 -0.0
linux all-clusters-app debug (read only) 1636385 1635553 -832 -0.1
(read/write) 117472 117472 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60928 60928 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135477 -64 -0.0
.text 1369106 1368338 -768 -0.1
bridge-app debug+rpc (read only) 1277645 1276829 -816 -0.1
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110620 -64 -0.1
.text 1071621 1070869 -752 -0.1
chip-tool debug (read only) 4174429 4173517 -912 -0.0
(read/write) 120896 120896 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 96208 96208 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 212496 212400 -96 -0.0
.text 3702037 3701221 -816 -0.0
lighting-app debug+rpc (read only) 1529385 1528521 -864 -0.1
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127793 -96 -0.1
.text 1269474 1268706 -768 -0.1
ota-provider-app debug (read only) 1236913 1236097 -816 -0.1
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110920 -64 -0.1
.text 1029970 1029218 -752 -0.1
ota-requestor-app debug (read only) 1294321 1293473 -848 -0.1
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127808 -96 -0.1
.text 1068818 1068066 -752 -0.1
shell debug (read only) 780809 779929 -880 -0.1
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76463 -64 -0.1
.text 603154 602338 -816 -0.1
tv-app debug (read only) 1756201 1755353 -848 -0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152888 -96 -0.1
.text 1461506 1460754 -752 -0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288904 2288776 -128 -0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251504 1251376 -128 -0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2256088 2255960 -128 -0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218688 1218560 -128 -0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2234120 2233992 -128 -0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196720 1196592 -128 -0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862983 862903 -80 -0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577724 577632 -92 -0.0
nrf52840dk_nrf52840+rpc (read/write) 823823 823743 -80 -0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550916 550824 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788022 787926 -96 -0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507196 507104 -92 -0.0
lock-app nrf52840dk_nrf52840 (read/write) 839927 839847 -80 -0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559284 559192 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764970 764874 -96 -0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488748 488656 -92 -0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844327 844247 -80 -0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562388 562296 -92 -0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839647 839567 -80 -0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559028 558936 -92 -0.0
shell nrf52840dk_nrf52840 (read/write) 776531 776435 -96 -0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520232 -92 -0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691586 691490 -96 -0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440844 -92 -0.0
p6 lock-app default (read/write) 2169360 2169160 -200 -0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127624 1127424 -200 -0.0
qpg lighting-app qpg6100+debug (read only) 491416 491328 -88 -0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 486096 486008 -88 -0.0
lock-app qpg6100+debug (read only) 467636 467548 -88 -0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462316 462228 -88 -0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664718 664606 -112 -0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458320 458202 -118 -0.0

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 3db0d85

File Section File VM
chip-qpg6100-lighting-example.out .text -88 -88
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
[Unmapped],0,88
.shstrtab,0,-2
.debug_frame,0,-4
.debug_abbrev,0,-18
.strtab,0,-34
.text,-88,-88
.debug_ranges,0,-104
.debug_line,0,-458
.debug_loc,0,-821
.debug_str,0,-993
.debug_info,0,-1990

@andy31415 andy31415 merged commit d786c58 into project-chip:master Oct 27, 2021
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@kghost @JasonLiuZhuoCheng
Clean up unusded code in SecureSessionTable (project-chip#11041)
bfbb84a
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@kghost @carol-apple
Clean up unusded code in SecureSessionTable (project-chip#11041)
07ce847
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@kghost
Clean up unusded code in SecureSessionTable (project-chip#11041)
99892f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@msandstedt msandstedt msandstedt approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@pan-apple pan-apple Awaiting requested review from pan-apple

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app review - approved transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kghost @andy31415 @msandstedt @Damian-Nordic