-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added automatic node resolve after first transmission failure. #12263
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
kkasperczyk-no:automatic_node_resolve_pr
Nov 30, 2021
Merged
Added automatic node resolve after first transmission failure. #12263
Damian-Nordic
merged 1 commit into
project-chip:master
from
kkasperczyk-no:automatic_node_resolve_pr
Nov 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
LuDuda,
lzgrablic02,
mlepage-google,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic and
vivien-apple
November 25, 2021 11:28
pullapprove
bot
requested review from
vivien-apple,
wbschiller,
woody-apple and
yunhanw-google
November 25, 2021 11:28
Damian-Nordic
approved these changes
Nov 25, 2021
PR #12263: Size comparison from 914b58e to 38ead1e Increases above 0.2%:
Increases (26 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (28 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
LuDuda
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
kkasperczyk-no
force-pushed
the
automatic_node_resolve_pr
branch
from
November 25, 2021 13:31
38ead1e
to
67adb8b
Compare
investigate why in ReliableMessageMgr::CheckResendApplicationMessageWithPeerExchange unit test released exchangeconnectedhomeip/src/messaging/ReliableMessageMgr.cpp Lines 358 to 368 in 67adb8b
This comment was generated by todo based on a
|
PR #12263: Size comparison from badf2e4 to 67adb8b Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Nov 25, 2021
msandstedt
reviewed
Nov 26, 2021
msandstedt
approved these changes
Nov 29, 2021
woody-apple
approved these changes
Nov 29, 2021
woody-apple
approved these changes
Nov 30, 2021
* Data advertised in the DNS-SD records such as IP address or CRA/CRI values may change in time and it may result in communication failures. * DNS-SD records are cached, so in case of device IP address change and trying to resolve address again the cached value is used instead of the new one. * Added argument that allows to bypass reading DNS-SD services data from cache and force resolving node data. * Added SessionRecoveryDelegate that can be used to notify about the first message transmission failure. * Added CHIPDeviceController implementation of SessionRecoveryDelegate to trigger resolving node data again if communication failure appeared.
kkasperczyk-no
force-pushed
the
automatic_node_resolve_pr
branch
from
November 30, 2021 06:34
67adb8b
to
14c53de
Compare
PR #12263: Size comparison from e1c501d to 14c53de Increases above 0.2%:
Increases (35 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Decreases (6 builds for mbed, p6)
Full report (38 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
in communication failures.
is used instead of the new one.
Change overview
SessionRecoveryDelegate
that can be used to notify about the first message transmission failure.SessionRecoveryDelegate
to trigger resolving node data againif communication failure appeared.
Testing
Tested using nrfconnect platform and Python CHIP controller that after first message delivery failure controller resolves node data once again:
resolve
commandzcl OnOff
command and verified that:Fixes: #11040