-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark all attributes reportable again. #13650
Merged
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:make-everything-reportable-again
Jan 18, 2022
Merged
Mark all attributes reportable again. #13650
andy31415
merged 1 commit into
project-chip:master
from
bzbarsky-apple:make-everything-reportable-again
Jan 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs and
jmartinez-silabs
January 18, 2022 14:28
pullapprove
bot
requested review from
LuDuda,
yunhanw-google,
mlepage-google,
msandstedt,
pan-apple,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
January 18, 2022 14:28
andy31415
approved these changes
Jan 18, 2022
LuDuda
approved these changes
Jan 18, 2022
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
bzbarsky-apple
force-pushed
the
make-everything-reportable-again
branch
from
January 18, 2022 14:47
a3e89cc
to
975cc6c
Compare
fast track: large automated change, zap gen worked and did not cause changes (except expected idl changes) |
PR #13650: Size comparison from 07454af to 975cc6c Increases above 0.2%:
Increases (1 build for linux)
Full report (21 builds for efr32, esp32, k32w, linux, mbed, p6, qpg, telink)
|
selissia
pushed a commit
to selissia/connectedhomeip
that referenced
this pull request
Jan 28, 2022
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
step0035
pushed a commit
to hank820/connectedhomeip
that referenced
this pull request
Feb 8, 2022
Continuing to work around project-chip/zap#318 and project-chip/zap#368 This commit was generated by running: find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing to work around
project-chip/zap#318 and
project-chip/zap#368
This commit was generated by running:
Problem
Attributes not marked reportable when they should be.
Change overview
Mark them reportable.
Testing
Code inspection of the generated code changes.