Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For Matter, reportability is entirely spec-defined, not user-controlled #368

Closed
bzbarsky-apple opened this issue Jan 11, 2022 · 2 comments · Fixed by #375
Closed

For Matter, reportability is entirely spec-defined, not user-controlled #368

bzbarsky-apple opened this issue Jan 11, 2022 · 2 comments · Fixed by #375
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK

Comments

@bzbarsky-apple
Copy link
Contributor

For Matter, reportability should just come from the XML, not from a UI setting. No opinion on whether the UI setting should be ignored or disabled, but it should not be possible to set an attribute non-reportable that the Matter spec requires to be reportable.

This is related to #318 but not identical.

It's possible that this could be addressed by exposing the "default" reportability of the attribute in queries, in addition to whatever was set in the UI, and changing matter templates to use that value.
@bzbarsky-apple bzbarsky-apple added the matter Important to Matter SDK label Jan 11, 2022
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 18, 2022
@bzbarsky-apple
Mark all attributes reportable again.
a3e89cc 
Continuing to work around
project-chip/zap#318 and
project-chip/zap#368

This commit was generated by running:

    find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
@bzbarsky-apple bzbarsky-apple mentioned this issue Jan 18, 2022
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue Jan 18, 2022
@bzbarsky-apple
Mark all attributes reportable again.
975cc6c 
Continuing to work around
project-chip/zap#318 and
project-chip/zap#368

This commit was generated by running:

    find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
andy31415 pushed a commit to project-chip/connectedhomeip that referenced this issue Jan 18, 2022
@bzbarsky-apple
Mark all attributes reportable again. (#13650)
8d4d770 
Continuing to work around
project-chip/zap#318 and
project-chip/zap#368

This commit was generated by running:

    find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
@tecimovic tecimovic added the high priority Tag that shows this as higher priority as other issues. label Jan 18, 2022
@tecimovic tecimovic mentioned this issue Jan 19, 2022
Merged
@tecimovic
Copy link
Collaborator

Should be resolved in #375

@bzbarsky-apple
Copy link
Contributor Author

Not fixed until PR is merged....

@bzbarsky-apple bzbarsky-apple linked a pull request Jan 21, 2022 that will close this issue
Silabs #375
Merged
selissia pushed a commit to selissia/connectedhomeip that referenced this issue Jan 28, 2022
@bzbarsky-apple @selissia
Mark all attributes reportable again. (project-chip#13650)
ea498a4 
Continuing to work around
project-chip/zap#318 and
project-chip/zap#368

This commit was generated by running:

    find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
step0035 pushed a commit to hank820/connectedhomeip that referenced this issue Feb 8, 2022
@bzbarsky-apple @step0035
Mark all attributes reportable again. (project-chip#13650)
d172b1a 
Continuing to work around
project-chip/zap#318 and
project-chip/zap#368

This commit was generated by running:

    find src/ examples -name "*.zap" -print0 | xargs -0 perl -pi -e 's/"reportable": 0/"reportable": 1/'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high priority Tag that shows this as higher priority as other issues. matter Important to Matter SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Silabs tecimovic/zap
3 participants
@tecimovic @jingteng25742 @bzbarsky-apple