Updated Fabric ID Validation in Fabric Table #15920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
holbrookt,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
sagar-apple
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
|
PR #15920: Size comparison from dde4a8f to e77fea9 Increases (11 builds for linux)
Decreases (15 builds for cyw30739, efr32, esp32, k32w, nrfconnect, p6, qpg, telink)
Full report (31 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Mar 8, 2022
bzbarsky-apple
approved these changes
Mar 9, 2022
emargolis
force-pushed
the
emargolis/feature/fabric-id-validity-check
branch
from
648a00a
to
8574e20
Compare
|
PR #15920: Size comparison from b942392 to 8574e20 Increases (3 builds for esp32, linux)
Decreases (13 builds for cyw30739, efr32, esp32, k32w, nrfconnect, p6, telink)
Full report (17 builds for cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
|
-- Updated logic that checks optional fabric id attribute in ICAC and RCAC to match
fabric id attribute in NOC.
-- According to spec there is no need to require fabric id in ICAC if it is present in RCAC.
-- NOTE: validity check for NodeId, FabricId and other DN attributes is performed when
loading certificates for validation (LoadCert()). So there is no need to check validity
again in FabricInfo::VerifyCredentials().
-- Changed return value of ExtractNodeIdFabricIdFromOpCert() and ExtractFabricIdFromCert()
to CHIP_ERROR_NOT_FOUND when requested element is not found in the certificate.
emargolis
force-pushed
the
emargolis/feature/fabric-id-validity-check
branch
from
8574e20
to
afd208e
Compare
|
PR #15920: Size comparison from 4349e22 to afd208e Increases (12 builds for esp32, linux)
Decreases (14 builds for cyw30739, efr32, esp32, k32w, mbed, nrfconnect, p6, telink)
Full report (27 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
tcarmelveilleux
approved these changes
Mar 10, 2022
andrei-menzopol
pushed a commit
to andrei-menzopol/connectedhomeip
that referenced
this pull request
Apr 14, 2022
-- Updated logic that checks optional fabric id attribute in ICAC and RCAC to match
fabric id attribute in NOC.
-- According to spec there is no need to require fabric id in ICAC if it is present in RCAC.
-- NOTE: validity check for NodeId, FabricId and other DN attributes is performed when
loading certificates for validation (LoadCert()). So there is no need to check validity
again in FabricInfo::VerifyCredentials().
-- Changed return value of ExtractNodeIdFabricIdFromOpCert() and ExtractFabricIdFromCert()
to CHIP_ERROR_NOT_FOUND when requested element is not found in the certificate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#15892
This PR follows updates in #15829.
Change overview
-- Updated logic that checks optional fabric id attribute in ICAC and RCAC to match
fabric id attribute in NOC.
-- According to spec there is no need to require fabric id in ICAC if it is present in RCAC.
-- NOTE: validity check for NodeId, FabricId and other DN attributes is performed when
loading certificates for validation (LoadCert()). So there is no need to check validity
again in FabricInfo::VerifyCredentials().
-- Changed return value of ExtractNodeIdFabricIdFromOpCert() and ExtractFabricIdFromCert()
to CHIP_ERROR_NOT_FOUND when requested element is not found in the certificate.
Testing
Existing tests