Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call OnReportBegin in ReadClient for events, and report in OnError callback in Darwin framework #19337

Merged
merged 2 commits into from
Jun 16, 2022
Merged

Call OnReportBegin in ReadClient for events, and report in OnError callback in Darwin framework #19337

merged 2 commits into from
Jun 16, 2022

Conversation

jtung-apple
Copy link
Contributor

Call OnReportBegin before ReadClient calls OnEventData, and report attribute/event in OnError in Darwin framework callback

Issue #18783 - Sort out interaction of OnReportBegin/OnReportEnd with subscriptions in the Darwin framework

Problem

Change overview

  • Combined mIsInitialReport and mSawAttributeReportsInCurrentReport into mIsReporting, in ReadClient, and added NoteReportingData right before actually reporting data, to accurately reflect when reports begin.
  • Added cleanup in BufferedReadCallback for when OnError happens
  • Added logic to Darwin framework to report accumulated attribute/event data when OnError happens.

Testing

How was this tested? (at least one bullet point required)

  • Tested locally with darwin-framework-tool to see that no regressions happen with normal subscription / read flow
  • Tested locally with darwin-framework-tool, with a modified ReadClient to simulate error in the middle of reporting, and see that attributes are indeed

@jtung-apple jtung-apple self-assigned this Jun 8, 2022
@boring-cyborg boring-cyborg bot added the app label Jun 8, 2022
@restyled-io restyled-io bot mentioned this pull request Jun 8, 2022
Closed
bzbarsky-apple
bzbarsky-apple approved these changes Jun 8, 2022
View reviewed changes
src/darwin/Framework/CHIP/CHIPDevice.mm Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 8, 2022 •
edited
Loading

PR #19337: Size comparison from 3bec7f6 to c323d63

Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3bec7f6 c323d63 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 689999 16 0.0
.text 577336 577352 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640591 640615 24 0.0
.text 550896 550920 24 0.0
lock-ftd LP_CC2652R7 (read only) 683487 683503 16 0.0
.text 584812 584828 16 0.0
lock-mtd LP_CC2652R7 (read only) 632895 632919 24 0.0
.text 534324 534348 24 0.0
pump-app LP_CC2652R7 (read only) 664931 664955 24 0.0
.text 578076 578100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 655507 655523 16 0.0
.text 570764 570780 16 0.0
shell LP_CC2652R7 (read only) 682262 682278 16 0.0
.text 573016 573032 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602594 16 0.0
.app_xip_area 461524 461540 16 0.0
lock cyw930739m2evb_01 (read/write) 599662 599678 16 0.0
.app_xip_area 458472 458488 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599478 16 0.0
.app_xip_area 459388 459404 16 0.0
efr32 lighting-app BRD4161A (read only) 915064 915080 16 0.0
.text 915056 915072 16 0.0
BRD4161A+rpc (read only) 949268 949300 32 0.0
.text 949260 949292 32 0.0
BRD4161A+rs911x (read only) 790252 790268 16 0.0
.text 790244 790260 16 0.0
lock-app BRD4161A+wf200 (read only) 958508 958524 16 0.0
.text 958500 958516 16 0.0
window-app BRD4161A (read only) 900136 900152 16 0.0
.text 900128 900144 16 0.0
esp32 all-clusters-app c3devkit (read only) 1007746 1007772 26 0.0
.flash.text 1007746 1007772 26 0.0
m5stack (read only) 1062535 1062567 32 0.0
.flash.text 1057151 1057183 32 0.0
k32w light k32w061+release (read/write) 653792 653824 32 0.0
.text 575944 575976 32 0.0
lock k32w061+release (read/write) 714900 714932 32 0.0
.text 636640 636672 32 0.0
linux all-clusters-app debug (read only) 2892457 2892505 48 0.0
.text 2462450 2462498 48 0.0
all-clusters-minimal-app debug (read only) 2753937 2753985 48 0.0
.text 2324658 2324706 48 0.0
bridge-app debug+rpc (read only) 2198001 2198049 48 0.0
.text 1851250 1851298 48 0.0
chip-tool debug (read only) 9754501 9754565 64 0.0
.text 7835333 7835397 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9499564 9499628 64 0.0
.text 7483284 7483348 64 0.0
lighting-app debug+rpc (read only) 2482385 2482433 48 0.0
.text 2109410 2109458 48 0.0
lock-app debug (read only) 2428353 2428401 48 0.0
.text 2046322 2046370 48 0.0
ota-provider-app debug (read only) 2203785 2203833 48 0.0
.text 1852146 1852194 48 0.0
ota-requestor-app debug (read only) 2265417 2265465 48 0.0
.text 1906386 1906434 48 0.0
shell debug (read only) 2584081 2584129 48 0.0
.text 2197410 2197458 48 0.0
thermostat-no-ble arm64 (read only) 2544028 2544076 48 0.0
.text 2146960 2147008 48 0.0
tv-app debug (read only) 3035985 3036033 48 0.0
.text 2609746 2609794 48 0.0
tv-casting-app debug (read only) 5335041 5335105 64 0.0
.text 4643858 4643922 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2429664 2429728 64 0.0
.text 1392308 1392372 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192107 32 0.0
text 817132 817160 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139815 32 0.0
text 789180 789208 28 0.0
p6 all-clusters-app default (read/write) 2544544 2544576 32 0.0
.text 1502808 1502840 32 0.0
all-clusters-minimal-app default (read/write) 2489416 2489448 32 0.0
.text 1447680 1447712 32 0.0
light-app default (read/write) 2421336 2421352 16 0.0
.text 1379600 1379616 16 0.0
lock-app default (read/write) 2441672 2441688 16 0.0
.text 1399936 1399952 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 781760 32 0.0
text 552596 552628 32 0.0
lighting-app tlsr9518adk80d (read/write) 801740 801772 32 0.0
text 569316 569346 30 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 3bec7f6 c323d63 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161784 161768 -16 -0.0
lock-ftd LP_CC2652R7 (read/write) 159344 159328 -16 -0.0
pump-app LP_CC2652R7 (read/write) 178812 178788 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188340 188324 -16 -0.0
shell LP_CC2652R7 (read/write) 165000 164984 -16 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3bec7f6 c323d63 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 689999 16 0.0
(read/write) 161784 161768 -16 -0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112335 112335 0 0.0
.text 577336 577352 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640591 640615 24 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89375 89375 0 0.0
.text 550896 550920 24 0.0
lock-ftd LP_CC2652R7 (read only) 683487 683503 16 0.0
(read/write) 159344 159328 -16 -0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98191 98191 0 0.0
.text 584812 584828 16 0.0
lock-mtd LP_CC2652R7 (read only) 632895 632919 24 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98079 98079 0 0.0
.text 534324 534348 24 0.0
pump-app LP_CC2652R7 (read only) 664931 664955 24 0.0
(read/write) 178812 178788 -24 -0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86371 86371 0 0.0
.text 578076 578100 24 0.0
pump-controller-app LP_CC2652R7 (read only) 655507 655523 16 0.0
(read/write) 188340 188324 -16 -0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84259 84259 0 0.0
.text 570764 570780 16 0.0
shell LP_CC2652R7 (read only) 682262 682278 16 0.0
(read/write) 165000 164984 -16 -0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108934 108934 0 0.0
.text 573016 573032 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602594 16 0.0
.app_xip_area 461524 461540 16 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599662 599678 16 0.0
.app_xip_area 458472 458488 16 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599478 16 0.0
.app_xip_area 459388 459404 16 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915064 915080 16 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915056 915072 16 0.0
BRD4161A+rpc (read only) 949268 949300 32 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949260 949292 32 0.0
BRD4161A+rs911x (read only) 790252 790268 16 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790244 790260 16 0.0
lock-app BRD4161A+wf200 (read only) 958508 958524 16 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958500 958516 16 0.0
window-app BRD4161A (read only) 900136 900152 16 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900128 900144 16 0.0
esp32 all-clusters-app c3devkit (read only) 1007746 1007772 26 0.0
(read/write) 1481842 1481842 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212592 212592 0 0.0
.flash.text 1007746 1007772 26 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062535 1062567 32 0.0
(read/write) 483976 483976 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243092 243092 0 0.0
.flash.text 1057151 1057183 32 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653792 653824 32 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575944 575976 32 0.0
lock k32w061+release (read/write) 714900 714932 32 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636640 636672 32 0.0
linux all-clusters-app debug (read only) 2892457 2892505 48 0.0
(read/write) 180024 180024 0 0.0
.bss 87840 87840 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255485 255485 0 0.0
.text 2462450 2462498 48 0.0
all-clusters-minimal-app debug (read only) 2753937 2753985 48 0.0
(read/write) 171640 171640 0 0.0
.bss 87008 87008 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256765 256765 0 0.0
.text 2324658 2324706 48 0.0
bridge-app debug+rpc (read only) 2198001 2198049 48 0.0
(read/write) 149528 149528 0 0.0
.bss 74496 74496 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187840 187840 0 0.0
.text 1851250 1851298 48 0.0
chip-tool debug (read only) 9754501 9754565 64 0.0
(read/write) 611840 611840 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579032 579032 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505789 505789 0 0.0
.text 7835333 7835397 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9499564 9499628 64 0.0
(read/write) 678065 678065 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614488 614488 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467884 467884 0 0.0
.text 7483284 7483348 64 0.0
lighting-app debug+rpc (read only) 2482385 2482433 48 0.0
(read/write) 155136 155136 0 0.0
.bss 76320 76320 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205384 205384 0 0.0
.text 2109410 2109458 48 0.0
lock-app debug (read only) 2428353 2428401 48 0.0
(read/write) 150272 150272 0 0.0
.bss 75040 75040 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219432 219432 0 0.0
.text 2046322 2046370 48 0.0
ota-provider-app debug (read only) 2203785 2203833 48 0.0
(read/write) 143264 143264 0 0.0
.bss 74496 74496 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 191960 191960 0 0.0
.text 1852146 1852194 48 0.0
ota-requestor-app debug (read only) 2265417 2265465 48 0.0
(read/write) 146312 146312 0 0.0
.bss 75264 75264 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195296 195296 0 0.0
.text 1906386 1906434 48 0.0
shell debug (read only) 2584081 2584129 48 0.0
(read/write) 203200 203200 0 0.0
.bss 118728 118728 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228050 228050 0 0.0
.text 2197410 2197458 48 0.0
thermostat-no-ble arm64 (read only) 2544028 2544076 48 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160132 160132 0 0.0
.text 2146960 2147008 48 0.0
tv-app debug (read only) 3035985 3036033 48 0.0
(read/write) 281648 281648 0 0.0
.bss 192296 192296 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241056 241056 0 0.0
.text 2609746 2609794 48 0.0
tv-casting-app debug (read only) 5335041 5335105 64 0.0
(read/write) 224032 224032 0 0.0
.bss 80136 80136 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135248 135248 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340512 340512 0 0.0
.text 4643858 4643922 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429664 2429728 64 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392308 1392372 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192107 32 0.0
bss 141362 141362 0 0.0
rodata 154652 154652 0 0.0
text 817132 817160 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139815 32 0.0
bss 140579 140579 0 0.0
rodata 131144 131144 0 0.0
text 789180 789208 28 0.0
p6 all-clusters-app default (read/write) 2544544 2544576 32 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502808 1502840 32 0.0
all-clusters-minimal-app default (read/write) 2489416 2489448 32 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447680 1447712 32 0.0
light-app default (read/write) 2421336 2421352 16 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379600 1379616 16 0.0
lock-app default (read/write) 2441672 2441688 16 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399936 1399952 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 781760 32 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552596 552628 32 0.0
lighting-app tlsr9518adk80d (read/write) 801740 801772 32 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569316 569346 30 0.0

@github-actions
Copy link

github-actions bot commented Jun 9, 2022 •
edited
Loading

PR #19337: Size comparison from 3bec7f6 to 94f0915

Increases (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3bec7f6 94f0915 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 689999 16 0.0
.text 577336 577352 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640591 640615 24 0.0
.text 550896 550920 24 0.0
lock-ftd LP_CC2652R7 (read only) 683487 683495 8 0.0
.text 584812 584820 8 0.0
lock-mtd LP_CC2652R7 (read only) 632895 632919 24 0.0
.text 534324 534348 24 0.0
pump-app LP_CC2652R7 (read only) 664931 664947 16 0.0
.text 578076 578092 16 0.0
pump-controller-app LP_CC2652R7 (read only) 655507 655531 24 0.0
.text 570764 570788 24 0.0
shell LP_CC2652R7 (read only) 682262 682278 16 0.0
.text 573016 573032 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602594 16 0.0
.app_xip_area 461524 461540 16 0.0
lock cyw930739m2evb_01 (read/write) 599662 599678 16 0.0
.app_xip_area 458472 458488 16 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599478 16 0.0
.app_xip_area 459388 459404 16 0.0
efr32 lighting-app BRD4161A (read only) 915064 915080 16 0.0
.text 915056 915072 16 0.0
BRD4161A+rpc (read only) 949268 949300 32 0.0
.text 949260 949292 32 0.0
BRD4161A+rs911x (read only) 790252 790268 16 0.0
.text 790244 790260 16 0.0
lock-app BRD4161A+wf200 (read only) 958508 958524 16 0.0
.text 958500 958516 16 0.0
window-app BRD4161A (read only) 900136 900152 16 0.0
.text 900128 900144 16 0.0
esp32 all-clusters-app c3devkit (read only) 1007746 1007772 26 0.0
.flash.text 1007746 1007772 26 0.0
m5stack (read only) 1062535 1062567 32 0.0
.flash.text 1057151 1057183 32 0.0
k32w light k32w061+release (read/write) 653792 653824 32 0.0
.text 575944 575976 32 0.0
lock k32w061+release (read/write) 714900 714932 32 0.0
.text 636640 636672 32 0.0
linux all-clusters-app debug (read only) 2892457 2892505 48 0.0
.text 2462450 2462498 48 0.0
all-clusters-minimal-app debug (read only) 2753937 2753985 48 0.0
.text 2324658 2324706 48 0.0
bridge-app debug+rpc (read only) 2198001 2198049 48 0.0
.text 1851250 1851298 48 0.0
chip-tool debug (read only) 9754501 9754565 64 0.0
.text 7835333 7835397 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9499564 9499628 64 0.0
.text 7483284 7483348 64 0.0
lighting-app debug+rpc (read only) 2482385 2482433 48 0.0
.text 2109410 2109458 48 0.0
lock-app debug (read only) 2428353 2428401 48 0.0
.text 2046322 2046370 48 0.0
ota-provider-app debug (read only) 2203785 2203833 48 0.0
.text 1852146 1852194 48 0.0
ota-requestor-app debug (read only) 2265417 2265465 48 0.0
.text 1906386 1906434 48 0.0
shell debug (read only) 2584081 2584129 48 0.0
.text 2197410 2197458 48 0.0
thermostat-no-ble arm64 (read only) 2544028 2544076 48 0.0
.text 2146960 2147008 48 0.0
tv-app debug (read only) 3035985 3036033 48 0.0
.text 2609746 2609794 48 0.0
tv-casting-app debug (read only) 5335041 5335105 64 0.0
.text 4643858 4643922 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2429664 2429728 64 0.0
.text 1392308 1392372 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192107 32 0.0
text 817132 817160 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139815 32 0.0
text 789180 789208 28 0.0
p6 all-clusters-app default (read/write) 2544544 2544576 32 0.0
.text 1502808 1502840 32 0.0
all-clusters-minimal-app default (read/write) 2489416 2489448 32 0.0
.text 1447680 1447712 32 0.0
light-app default (read/write) 2421336 2421352 16 0.0
.text 1379600 1379616 16 0.0
lock-app default (read/write) 2441672 2441688 16 0.0
.text 1399936 1399952 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 781760 32 0.0
text 552596 552628 32 0.0
lighting-app tlsr9518adk80d (read/write) 801740 801772 32 0.0
text 569316 569350 34 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section 3bec7f6 94f0915 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 161784 161768 -16 -0.0
lock-ftd LP_CC2652R7 (read/write) 159344 159336 -8 -0.0
pump-app LP_CC2652R7 (read/write) 178812 178796 -16 -0.0
pump-controller-app LP_CC2652R7 (read/write) 188340 188316 -24 -0.0
shell LP_CC2652R7 (read/write) 165000 164984 -16 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 3bec7f6 94f0915 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 689983 689999 16 0.0
(read/write) 161784 161768 -16 -0.0
.bss 74660 74660 0 0.0
.data 3392 3392 0 0.0
.rodata 112335 112335 0 0.0
.text 577336 577352 16 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640591 640615 24 0.0
(read/write) 158132 158132 0 0.0
.bss 73884 73884 0 0.0
.data 3332 3332 0 0.0
.rodata 89375 89375 0 0.0
.text 550896 550920 24 0.0
lock-ftd LP_CC2652R7 (read only) 683487 683495 8 0.0
(read/write) 159344 159336 -8 -0.0
.bss 72612 72612 0 0.0
.data 3256 3256 0 0.0
.rodata 98191 98191 0 0.0
.text 584812 584820 8 0.0
lock-mtd LP_CC2652R7 (read only) 632895 632919 24 0.0
(read/write) 145720 145720 0 0.0
.bss 68348 68348 0 0.0
.data 3256 3256 0 0.0
.rodata 98079 98079 0 0.0
.text 534324 534348 24 0.0
pump-app LP_CC2652R7 (read only) 664931 664947 16 0.0
(read/write) 178812 178796 -16 -0.0
.bss 72756 72756 0 0.0
.data 3292 3292 0 0.0
.rodata 86371 86371 0 0.0
.text 578076 578092 16 0.0
pump-controller-app LP_CC2652R7 (read only) 655507 655531 24 0.0
(read/write) 188340 188316 -24 -0.0
.bss 72860 72860 0 0.0
.data 3252 3252 0 0.0
.rodata 84259 84259 0 0.0
.text 570764 570788 24 0.0
shell LP_CC2652R7 (read only) 682262 682278 16 0.0
(read/write) 165000 164984 -16 -0.0
.bss 76956 76956 0 0.0
.data 3396 3396 0 0.0
.rodata 108934 108934 0 0.0
.text 573016 573032 16 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 602578 602594 16 0.0
.app_xip_area 461524 461540 16 0.0
.bss 84008 84008 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 599662 599678 16 0.0
.app_xip_area 458472 458488 16 0.0
.bss 84176 84176 0 0.0
.data 700 700 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 599462 599478 16 0.0
.app_xip_area 459388 459404 16 0.0
.bss 83140 83140 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915064 915080 16 0.0
(read/write) 133176 133176 0 0.0
.bss 131088 131088 0 0.0
.data 2088 2088 0 0.0
.text 915056 915072 16 0.0
BRD4161A+rpc (read only) 949268 949300 32 0.0
(read/write) 149868 149868 0 0.0
.bss 147576 147576 0 0.0
.data 2292 2292 0 0.0
.text 949260 949292 32 0.0
BRD4161A+rs911x (read only) 790252 790268 16 0.0
(read/write) 129460 129460 0 0.0
.bss 127364 127364 0 0.0
.data 2096 2096 0 0.0
.text 790244 790260 16 0.0
lock-app BRD4161A+wf200 (read only) 958508 958524 16 0.0
(read/write) 128252 128252 0 0.0
.bss 126188 126188 0 0.0
.data 2064 2064 0 0.0
.text 958500 958516 16 0.0
window-app BRD4161A (read only) 900136 900152 16 0.0
(read/write) 133264 133264 0 0.0
.bss 131176 131176 0 0.0
.data 2084 2084 0 0.0
.text 900128 900144 16 0.0
esp32 all-clusters-app c3devkit (read only) 1007746 1007772 26 0.0
(read/write) 1481842 1481842 0 0.0
.dram0.bss 69168 69168 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 212592 212592 0 0.0
.flash.text 1007746 1007772 26 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1062535 1062567 32 0.0
(read/write) 483976 483976 0 0.0
.dram0.bss 74688 74688 0 0.0
.dram0.data 34200 34200 0 0.0
.flash.rodata 243092 243092 0 0.0
.flash.text 1057151 1057183 32 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 653792 653824 32 0.0
.bss 70044 70044 0 0.0
.data 2004 2004 0 0.0
.text 575944 575976 32 0.0
lock k32w061+release (read/write) 714900 714932 32 0.0
.bss 70484 70484 0 0.0
.data 1976 1976 0 0.0
.text 636640 636672 32 0.0
linux all-clusters-app debug (read only) 2892457 2892505 48 0.0
(read/write) 180024 180024 0 0.0
.bss 87840 87840 0 0.0
.data 2016 2016 0 0.0
.data.rel.ro 83960 83960 0 0.0
.dynamic 608 608 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 255485 255485 0 0.0
.text 2462450 2462498 48 0.0
all-clusters-minimal-app debug (read only) 2753937 2753985 48 0.0
(read/write) 171640 171640 0 0.0
.bss 87008 87008 0 0.0
.data 1888 1888 0 0.0
.data.rel.ro 76584 76584 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 256765 256765 0 0.0
.text 2324658 2324706 48 0.0
bridge-app debug+rpc (read only) 2198001 2198049 48 0.0
(read/write) 149528 149528 0 0.0
.bss 74496 74496 0 0.0
.data 3888 3888 0 0.0
.data.rel.ro 65400 65400 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 187840 187840 0 0.0
.text 1851250 1851298 48 0.0
chip-tool debug (read only) 9754501 9754565 64 0.0
(read/write) 611840 611840 0 0.0
.bss 25408 25408 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579032 579032 0 0.0
.dynamic 624 624 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 505789 505789 0 0.0
.text 7835333 7835397 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9499564 9499628 64 0.0
(read/write) 678065 678065 0 0.0
.bss 43681 43681 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614488 614488 0 0.0
.dynamic 528 528 0 0.0
.got 14936 14936 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 467884 467884 0 0.0
.text 7483284 7483348 64 0.0
lighting-app debug+rpc (read only) 2482385 2482433 48 0.0
(read/write) 155136 155136 0 0.0
.bss 76320 76320 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 70888 70888 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 205384 205384 0 0.0
.text 2109410 2109458 48 0.0
lock-app debug (read only) 2428353 2428401 48 0.0
(read/write) 150272 150272 0 0.0
.bss 75040 75040 0 0.0
.data 1520 1520 0 0.0
.data.rel.ro 67848 67848 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 219432 219432 0 0.0
.text 2046322 2046370 48 0.0
ota-provider-app debug (read only) 2203785 2203833 48 0.0
(read/write) 143264 143264 0 0.0
.bss 74496 74496 0 0.0
.data 1752 1752 0 0.0
.data.rel.ro 61208 61208 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 664 664 0 0.0
.rodata 191960 191960 0 0.0
.text 1852146 1852194 48 0.0
ota-requestor-app debug (read only) 2265417 2265465 48 0.0
(read/write) 146312 146312 0 0.0
.bss 75264 75264 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63320 63320 0 0.0
.dynamic 608 608 0 0.0
.got 4456 4456 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 195296 195296 0 0.0
.text 1906386 1906434 48 0.0
shell debug (read only) 2584081 2584129 48 0.0
(read/write) 203200 203200 0 0.0
.bss 118728 118728 0 0.0
.data 1328 1328 0 0.0
.data.rel.ro 77392 77392 0 0.0
.dynamic 608 608 0 0.0
.got 4176 4176 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 228050 228050 0 0.0
.text 2197410 2197458 48 0.0
thermostat-no-ble arm64 (read only) 2544028 2544076 48 0.0
(read/write) 183073 183073 0 0.0
.bss 91409 91409 0 0.0
.data 1512 1512 0 0.0
.data.rel.ro 82144 82144 0 0.0
.dynamic 528 528 0 0.0
.got 4992 4992 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 160132 160132 0 0.0
.text 2146960 2147008 48 0.0
tv-app debug (read only) 3035985 3036033 48 0.0
(read/write) 281648 281648 0 0.0
.bss 192296 192296 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 78232 78232 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 960 960 0 0.0
.rodata 241056 241056 0 0.0
.text 2609746 2609794 48 0.0
tv-casting-app debug (read only) 5335041 5335105 64 0.0
(read/write) 224032 224032 0 0.0
.bss 80136 80136 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 135248 135248 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 880 880 0 0.0
.rodata 340512 340512 0 0.0
.text 4643858 4643922 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2429664 2429728 64 0.0
.bss 202692 202692 0 0.0
.data 5872 5872 0 0.0
.text 1392308 1392372 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1192075 1192107 32 0.0
bss 141362 141362 0 0.0
rodata 154652 154652 0 0.0
text 817132 817160 28 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1139783 1139815 32 0.0
bss 140579 140579 0 0.0
rodata 131144 131144 0 0.0
text 789180 789208 28 0.0
p6 all-clusters-app default (read/write) 2544544 2544576 32 0.0
.bss 137120 137120 0 0.0
.data 2808 2808 0 0.0
.text 1502808 1502840 32 0.0
all-clusters-minimal-app default (read/write) 2489416 2489448 32 0.0
.bss 136328 136328 0 0.0
.data 2752 2752 0 0.0
.text 1447680 1447712 32 0.0
light-app default (read/write) 2421336 2421352 16 0.0
.bss 129432 129432 0 0.0
.data 2600 2600 0 0.0
.text 1379600 1379616 16 0.0
lock-app default (read/write) 2441672 2441688 16 0.0
.bss 129256 129256 0 0.0
.data 2576 2576 0 0.0
.text 1399936 1399952 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 781728 781760 32 0.0
bss 70636 70636 0 0.0
noinit 40416 40416 0 0.0
text 552596 552628 32 0.0
lighting-app tlsr9518adk80d (read/write) 801740 801772 32 0.0
bss 70888 70888 0 0.0
noinit 40416 40416 0 0.0
text 569316 569350 34 0.0

woody-apple
woody-apple approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast tracking platform changes

@yunhanw-google
Copy link
Contributor

/rebase

yunhanw-google
yunhanw-google approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@yunhanw-google yunhanw-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jtung-apple @bzbarsky-apple
Call OnReportBegin before ReadClient calls OnEventData, and report at…
c9e89af 
…tribute/event in OnError in Darwin framework callback

Issue 18783 - Sort out interaction of OnReportBegin/OnReportEnd with subscriptions in the Darwin framework

Update src/darwin/Framework/CHIP/CHIPDevice.mm

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
@jtung-apple jtung-apple force-pushed the issue-18783-event-subscription-onReportBegin branch from 94f0915 to c9e89af Compare June 15, 2022 16:26
@jtung-apple
Copy link
Contributor Author

Rebased and clang-format.

@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19337: Size comparison from a99bed0 to c9e89af

Increases (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a99bed0 c9e89af change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657643 657667 24 0.0
.text 570448 570472 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646159 646183 24 0.0
.text 555680 555704 24 0.0
lock-ftd LP_CC2652R7 (read only) 688487 688519 32 0.0
.text 589092 589124 32 0.0
lock-mtd LP_CC2652R7 (read only) 637903 637927 24 0.0
.text 538620 538644 24 0.0
pump-app LP_CC2652R7 (read only) 669711 669735 24 0.0
.text 582220 582244 24 0.0
pump-controller-app LP_CC2652R7 (read only) 660443 660475 32 0.0
.text 575028 575060 32 0.0
shell LP_CC2652R7 (read only) 686986 687010 24 0.0
.text 577264 577288 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610994 611018 24 0.0
.app_xip_area 467684 467708 24 0.0
lock cyw930739m2evb_01 (read/write) 608094 608118 24 0.0
.app_xip_area 464640 464664 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614098 614122 24 0.0
.app_xip_area 471708 471732 24 0.0
esp32 all-clusters-app c3devkit (read only) 1010584 1010620 36 0.0
.flash.text 1010584 1010620 36 0.0
m5stack (read only) 1064883 1064927 44 0.0
.flash.text 1059499 1059543 44 0.0
k32w light k32w061+release (read/write) 657192 657224 32 0.0
.text 580656 580688 32 0.0
lock k32w061+release (read/write) 718848 718880 32 0.0
.text 641908 641940 32 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9690140 9690204 64 0.0
.text 7753748 7753812 64 0.0
thermostat-no-ble arm64 (read only) 2561300 2561348 48 0.0
.text 2160064 2160112 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2434912 2434976 64 0.0
.text 1397556 1397620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196643 1196675 32 0.0
text 820812 820844 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144691 1144723 32 0.0
text 793128 793160 32 0.0
p6 all-clusters-app default (read/write) 2549952 2549968 16 0.0
.text 1508216 1508232 16 0.0
all-clusters-minimal-app default (read/write) 2495896 2495928 32 0.0
.text 1454160 1454192 32 0.0
light-app default (read/write) 2426776 2426808 32 0.0
.text 1385040 1385072 32 0.0
lock-app default (read/write) 2447192 2447208 16 0.0
.text 1405456 1405472 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786772 40 0.0
text 557632 557670 38 0.0
lighting-app tlsr9518adk80d (read/write) 806720 806760 40 0.0
text 574322 574362 40 0.0
Decreases (5 builds for cc13x2_26x2)
platform target config section a99bed0 c9e89af change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 193172 193148 -24 -0.0
lock-ftd LP_CC2652R7 (read/write) 152432 152400 -32 -0.0
pump-app LP_CC2652R7 (read/write) 172096 172072 -24 -0.0
pump-controller-app LP_CC2652R7 (read/write) 181492 181460 -32 -0.0
shell LP_CC2652R7 (read/write) 159324 159300 -24 -0.0
Full report (25 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a99bed0 c9e89af change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657643 657667 24 0.0
(read/write) 193172 193148 -24 -0.0
.bss 73708 73708 0 0.0
.data 3380 3380 0 0.0
.rodata 86883 86883 0 0.0
.text 570448 570472 24 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 646159 646183 24 0.0
(read/write) 157260 157260 0 0.0
.bss 72988 72988 0 0.0
.data 3356 3356 0 0.0
.rodata 90159 90159 0 0.0
.text 555680 555704 24 0.0
lock-ftd LP_CC2652R7 (read only) 688487 688519 32 0.0
(read/write) 152432 152400 -32 -0.0
.bss 70700 70700 0 0.0
.data 3280 3280 0 0.0
.rodata 98911 98911 0 0.0
.text 589092 589124 32 0.0
lock-mtd LP_CC2652R7 (read only) 637903 637927 24 0.0
(read/write) 143832 143832 0 0.0
.bss 66436 66436 0 0.0
.data 3280 3280 0 0.0
.rodata 98791 98791 0 0.0
.text 538620 538644 24 0.0
pump-app LP_CC2652R7 (read only) 669711 669735 24 0.0
(read/write) 172096 172072 -24 -0.0
.bss 70820 70820 0 0.0
.data 3316 3316 0 0.0
.rodata 87007 87007 0 0.0
.text 582220 582244 24 0.0
pump-controller-app LP_CC2652R7 (read only) 660443 660475 32 0.0
(read/write) 181492 181460 -32 -0.0
.bss 70948 70948 0 0.0
.data 3276 3276 0 0.0
.rodata 84931 84931 0 0.0
.text 575028 575060 32 0.0
shell LP_CC2652R7 (read only) 686986 687010 24 0.0
(read/write) 159324 159300 -24 -0.0
.bss 76004 76004 0 0.0
.data 3384 3384 0 0.0
.rodata 109410 109410 0 0.0
.text 577264 577288 24 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 610994 611018 24 0.0
.app_xip_area 467684 467708 24 0.0
.bss 86232 86232 0 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608094 608118 24 0.0
.app_xip_area 464640 464664 24 0.0
.bss 86408 86408 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614098 614122 24 0.0
.app_xip_area 471708 471732 24 0.0
.bss 85400 85400 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1010584 1010620 36 0.0
(read/write) 1482626 1482626 0 0.0
.dram0.bss 69344 69344 0 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 213200 213200 0 0.0
.flash.text 1010584 1010620 36 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1064883 1064927 44 0.0
(read/write) 484744 484744 0 0.0
.dram0.bss 74864 74864 0 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 243708 243708 0 0.0
.flash.text 1059499 1059543 44 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657192 657224 32 0.0
.bss 68708 68708 0 0.0
.data 2028 2028 0 0.0
.text 580656 580688 32 0.0
lock k32w061+release (read/write) 718848 718880 32 0.0
.bss 69140 69140 0 0.0
.data 2000 2000 0 0.0
.text 641908 641940 32 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9690140 9690204 64 0.0
(read/write) 646001 646001 0 0.0
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 585264 585264 0 0.0
.dynamic 528 528 0 0.0
.got 13152 13152 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466252 466252 0 0.0
.text 7753748 7753812 64 0.0
thermostat-no-ble arm64 (read only) 2561300 2561348 48 0.0
(read/write) 191697 191697 0 0.0
.bss 99393 99393 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82536 82536 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162996 162996 0 0.0
.text 2160064 2160112 48 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434912 2434976 64 0.0
.bss 208148 208148 0 0.0
.data 5864 5864 0 0.0
.text 1397556 1397620 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196643 1196675 32 0.0
bss 141554 141554 0 0.0
rodata 155420 155420 0 0.0
text 820812 820844 32 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144691 1144723 32 0.0
bss 140794 140794 0 0.0
rodata 131948 131948 0 0.0
text 793128 793160 32 0.0
p6 all-clusters-app default (read/write) 2549952 2549968 16 0.0
.bss 143344 143344 0 0.0
.data 2800 2800 0 0.0
.text 1508216 1508232 16 0.0
all-clusters-minimal-app default (read/write) 2495896 2495928 32 0.0
.bss 142608 142608 0 0.0
.data 2776 2776 0 0.0
.text 1454160 1454192 32 0.0
light-app default (read/write) 2426776 2426808 32 0.0
.bss 134688 134688 0 0.0
.data 2624 2624 0 0.0
.text 1385040 1385072 32 0.0
lock-app default (read/write) 2447192 2447208 16 0.0
.bss 134512 134512 0 0.0
.data 2600 2600 0 0.0
.text 1405456 1405472 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 786732 786772 40 0.0
bss 69836 69836 0 0.0
noinit 40416 40416 0 0.0
text 557632 557670 38 0.0
lighting-app tlsr9518adk80d (read/write) 806720 806760 40 0.0
bss 70088 70088 0 0.0
noinit 40416 40416 0 0.0
text 574322 574362 40 0.0

@github-actions
Copy link

github-actions bot commented Jun 15, 2022 •
edited
Loading

PR #19337: Size comparison from a99bed0 to 38bb8b6

Increases above 0.2%:

platform target config section a99bed0 38bb8b6 change % change
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9690140 9823228 133088 1.4
(read/write) 646001 674801 28800 4.5
.data.rel.ro 585264 613824 28560 4.9
.got 13152 13392 240 1.8
.text 7753748 7818068 64320 0.8
Increases (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a99bed0 38bb8b6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657643 657999 356 0.1
.bss 73708 73732 24 0.0
.rodata 86883 86919 36 0.0
.text 570448 570768 320 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 646159 646507 348 0.1
(read/write) 157260 157284 24 0.0
.bss 72988 73012 24 0.0
.rodata 90159 90195 36 0.0
.text 555680 555992 312 0.1
lock-ftd LP_CC2652R7 (read only) 688487 688851 364 0.1
.bss 70700 70724 24 0.0
.rodata 98911 98947 36 0.0
.text 589092 589420 328 0.1
lock-mtd LP_CC2652R7 (read only) 637903 638259 356 0.1
(read/write) 143832 143856 24 0.0
.bss 66436 66460 24 0.0
.rodata 98791 98827 36 0.0
.text 538620 538940 320 0.1
pump-app LP_CC2652R7 (read only) 669711 670075 364 0.1
.bss 70820 70844 24 0.0
.rodata 87007 87043 36 0.0
.text 582220 582548 328 0.1
pump-controller-app LP_CC2652R7 (read only) 660443 660815 372 0.1
.bss 70948 70972 24 0.0
.rodata 84931 84967 36 0.0
.text 575028 575364 336 0.1
shell LP_CC2652R7 (read only) 686986 687334 348 0.1
.bss 76004 76028 24 0.0
.rodata 109410 109446 36 0.0
.text 577264 577576 312 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 610994 611374 380 0.1
.app_xip_area 467684 468040 356 0.1
.bss 86232 86256 24 0.0
lock cyw930739m2evb_01 (read/write) 608094 608458 364 0.1
.app_xip_area 464640 464980 340 0.1
.bss 86408 86432 24 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614098 614478 380 0.1
.app_xip_area 471708 472064 356 0.1
.bss 85400 85424 24 0.0
efr32 lighting-app BRD4161A (read only) 920548 921268 720 0.1
(read/write) 132396 132420 24 0.0
.bss 130280 130304 24 0.0
.text 920540 921260 720 0.1
BRD4161A+rpc (read only) 956204 956932 728 0.1
(read/write) 149272 149296 24 0.0
.bss 146952 146976 24 0.0
.text 956196 956924 728 0.1
BRD4161A+rs911x (read only) 795648 796400 752 0.1
(read/write) 128676 128700 24 0.0
.bss 126548 126572 24 0.0
.text 795640 796392 752 0.1
lock-app BRD4161A+wf200 (read only) 963576 963932 356 0.0
(read/write) 129012 129036 24 0.0
.bss 126924 126948 24 0.0
.text 963568 963924 356 0.0
window-app BRD4161A (read only) 905420 906140 720 0.1
(read/write) 132460 132484 24 0.0
.bss 130352 130376 24 0.0
.text 905412 906132 720 0.1
esp32 all-clusters-app c3devkit (read only) 1010584 1010988 404 0.0
(read/write) 1482626 1482682 56 0.0
.dram0.bss 69344 69368 24 0.0
.flash.rodata 213200 213224 24 0.0
.flash.text 1010584 1010988 404 0.0
m5stack (read only) 1064883 1065267 384 0.0
(read/write) 484744 484808 64 0.0
.dram0.bss 74864 74888 24 0.0
.flash.rodata 243708 243748 40 0.0
.flash.text 1059499 1059883 384 0.0
k32w light k32w061+release (read/write) 657192 657588 396 0.1
.bss 68708 68732 24 0.0
.text 580656 581028 372 0.1
lock k32w061+release (read/write) 718848 719244 396 0.1
.bss 69140 69164 24 0.0
.text 641908 642280 372 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9690140 9823228 133088 1.4
(read/write) 646001 674801 28800 4.5
.data.rel.ro 585264 613824 28560 4.9
.got 13152 13392 240 1.8
.rodata 466252 467340 1088 0.2
.text 7753748 7818068 64320 0.8
thermostat-no-ble arm64 (read only) 2561300 2562684 1384 0.1
(read/write) 191697 191889 192 0.1
.bss 99393 99457 64 0.1
.data.rel.ro 82536 82656 120 0.1
.got 5056 5064 8 0.2
.rodata 162996 163004 8 0.0
.text 2160064 2161200 1136 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2434912 2435952 1040 0.0
.bss 208148 208172 24 0.0
.text 1397556 1398596 1040 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196643 1197127 484 0.0
bss 141554 141578 24 0.0
rodata 155420 155456 36 0.0
text 820812 821132 320 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144691 1145175 484 0.0
bss 140794 140818 24 0.0
rodata 131948 131984 36 0.0
text 793128 793452 324 0.0
p6 all-clusters-app default (read/write) 2549952 2550688 736 0.0
.bss 143344 143368 24 0.0
.text 1508216 1508952 736 0.0
all-clusters-minimal-app default (read/write) 2495896 2496616 720 0.0
.bss 142608 142632 24 0.0
.text 1454160 1454880 720 0.0
light-app default (read/write) 2426776 2427496 720 0.0
.bss 134688 134712 24 0.0
.text 1385040 1385760 720 0.1
lock-app default (read/write) 2447192 2447912 720 0.0
.bss 134512 134536 24 0.0
.text 1405456 1406176 720 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786732 787176 444 0.1
bss 69836 69860 24 0.0
text 557632 558016 384 0.1
lighting-app tlsr9518adk80d (read/write) 806720 807164 444 0.1
bss 70088 70112 24 0.0
text 574322 574712 390 0.1
Decreases (5 builds for cc13x2_26x2)
platform target config section a99bed0 38bb8b6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 193172 192840 -332 -0.2
lock-ftd LP_CC2652R7 (read/write) 152432 152092 -340 -0.2
pump-app LP_CC2652R7 (read/write) 172096 171756 -340 -0.2
pump-controller-app LP_CC2652R7 (read/write) 181492 181144 -348 -0.2
shell LP_CC2652R7 (read/write) 159324 159000 -324 -0.2
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section a99bed0 38bb8b6 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 657643 657999 356 0.1
(read/write) 193172 192840 -332 -0.2
.bss 73708 73732 24 0.0
.data 3380 3380 0 0.0
.rodata 86883 86919 36 0.0
.text 570448 570768 320 0.1
all-clusters-minimal-app LP_CC2652R7 (read only) 646159 646507 348 0.1
(read/write) 157260 157284 24 0.0
.bss 72988 73012 24 0.0
.data 3356 3356 0 0.0
.rodata 90159 90195 36 0.0
.text 555680 555992 312 0.1
lock-ftd LP_CC2652R7 (read only) 688487 688851 364 0.1
(read/write) 152432 152092 -340 -0.2
.bss 70700 70724 24 0.0
.data 3280 3280 0 0.0
.rodata 98911 98947 36 0.0
.text 589092 589420 328 0.1
lock-mtd LP_CC2652R7 (read only) 637903 638259 356 0.1
(read/write) 143832 143856 24 0.0
.bss 66436 66460 24 0.0
.data 3280 3280 0 0.0
.rodata 98791 98827 36 0.0
.text 538620 538940 320 0.1
pump-app LP_CC2652R7 (read only) 669711 670075 364 0.1
(read/write) 172096 171756 -340 -0.2
.bss 70820 70844 24 0.0
.data 3316 3316 0 0.0
.rodata 87007 87043 36 0.0
.text 582220 582548 328 0.1
pump-controller-app LP_CC2652R7 (read only) 660443 660815 372 0.1
(read/write) 181492 181144 -348 -0.2
.bss 70948 70972 24 0.0
.data 3276 3276 0 0.0
.rodata 84931 84967 36 0.0
.text 575028 575364 336 0.1
shell LP_CC2652R7 (read only) 686986 687334 348 0.1
(read/write) 159324 159000 -324 -0.2
.bss 76004 76028 24 0.0
.data 3384 3384 0 0.0
.rodata 109410 109446 36 0.0
.text 577264 577576 312 0.1
cyw30739 light cyw930739m2evb_01 (read/write) 610994 611374 380 0.1
.app_xip_area 467684 468040 356 0.1
.bss 86232 86256 24 0.0
.data 764 764 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 608094 608458 364 0.1
.app_xip_area 464640 464980 340 0.1
.bss 86408 86432 24 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 614098 614478 380 0.1
.app_xip_area 471708 472064 356 0.1
.bss 85400 85424 24 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 920548 921268 720 0.1
(read/write) 132396 132420 24 0.0
.bss 130280 130304 24 0.0
.data 2116 2116 0 0.0
.text 920540 921260 720 0.1
BRD4161A+rpc (read only) 956204 956932 728 0.1
(read/write) 149272 149296 24 0.0
.bss 146952 146976 24 0.0
.data 2320 2320 0 0.0
.text 956196 956924 728 0.1
BRD4161A+rs911x (read only) 795648 796400 752 0.1
(read/write) 128676 128700 24 0.0
.bss 126548 126572 24 0.0
.data 2124 2124 0 0.0
.text 795640 796392 752 0.1
lock-app BRD4161A+wf200 (read only) 963576 963932 356 0.0
(read/write) 129012 129036 24 0.0
.bss 126924 126948 24 0.0
.data 2088 2088 0 0.0
.text 963568 963924 356 0.0
window-app BRD4161A (read only) 905420 906140 720 0.1
(read/write) 132460 132484 24 0.0
.bss 130352 130376 24 0.0
.data 2108 2108 0 0.0
.text 905412 906132 720 0.1
esp32 all-clusters-app c3devkit (read only) 1010584 1010988 404 0.0
(read/write) 1482626 1482682 56 0.0
.dram0.bss 69344 69368 24 0.0
.dram0.data 14656 14656 0 0.0
.flash.rodata 213200 213224 24 0.0
.flash.text 1010584 1010988 404 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1064883 1065267 384 0.0
(read/write) 484744 484808 64 0.0
.dram0.bss 74864 74888 24 0.0
.dram0.data 34176 34176 0 0.0
.flash.rodata 243708 243748 40 0.0
.flash.text 1059499 1059883 384 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 657192 657588 396 0.1
.bss 68708 68732 24 0.0
.data 2028 2028 0 0.0
.text 580656 581028 372 0.1
lock k32w061+release (read/write) 718848 719244 396 0.1
.bss 69140 69164 24 0.0
.data 2000 2000 0 0.0
.text 641908 642280 372 0.1
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9690140 9823228 133088 1.4
(read/write) 646001 674801 28800 4.5
.bss 42625 42625 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 585264 613824 28560 4.9
.dynamic 528 528 0 0.0
.got 13152 13392 240 1.8
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 466252 467340 1088 0.2
.text 7753748 7818068 64320 0.8
thermostat-no-ble arm64 (read only) 2561300 2562684 1384 0.1
(read/write) 191697 191889 192 0.1
.bss 99393 99457 64 0.1
.data 1688 1688 0 0.0
.data.rel.ro 82536 82656 120 0.1
.dynamic 528 528 0 0.0
.got 5056 5064 8 0.2
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 162996 163004 8 0.0
.text 2160064 2161200 1136 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2434912 2435952 1040 0.0
.bss 208148 208172 24 0.0
.data 5864 5864 0 0.0
.text 1397556 1398596 1040 0.1
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1196643 1197127 484 0.0
bss 141554 141578 24 0.0
rodata 155420 155456 36 0.0
text 820812 821132 320 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1144691 1145175 484 0.0
bss 140794 140818 24 0.0
rodata 131948 131984 36 0.0
text 793128 793452 324 0.0
p6 all-clusters-app default (read/write) 2549952 2550688 736 0.0
.bss 143344 143368 24 0.0
.data 2800 2800 0 0.0
.text 1508216 1508952 736 0.0
all-clusters-minimal-app default (read/write) 2495896 2496616 720 0.0
.bss 142608 142632 24 0.0
.data 2776 2776 0 0.0
.text 1454160 1454880 720 0.0
light-app default (read/write) 2426776 2427496 720 0.0
.bss 134688 134712 24 0.0
.data 2624 2624 0 0.0
.text 1385040 1385760 720 0.1
lock-app default (read/write) 2447192 2447912 720 0.0
.bss 134512 134536 24 0.0
.data 2600 2600 0 0.0
.text 1405456 1406176 720 0.1
telink light-switch-app tlsr9518adk80d (read/write) 786732 787176 444 0.1
bss 69836 69860 24 0.0
noinit 40416 40416 0 0.0
text 557632 558016 384 0.1
lighting-app tlsr9518adk80d (read/write) 806720 807164 444 0.1
bss 70088 70112 24 0.0
noinit 40416 40416 0 0.0
text 574322 574712 390 0.1

@woody-apple woody-apple merged commit 75d0257 into project-chip:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhanw-google yunhanw-google yunhanw-google approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees

@jtung-apple jtung-apple

Labels
app darwin fast track review - pending V1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort out interaction of OnReportBegin/OnReportEnd with subscriptions in the Darwin framework
4 participants
@jtung-apple @yunhanw-google @woody-apple @bzbarsky-apple