Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect GenericConnectivityManagerImpl_NoThread<ImplClass>::_WriteThreadNetworkDiagnosticAttributeToTlv code. #20014

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Remove incorrect GenericConnectivityManagerImpl_NoThread<ImplClass>::_WriteThreadNetworkDiagnosticAttributeToTlv code. #20014

merged 1 commit into from
Jun 28, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

We should not be doing anything other than returning error here:
consumers should not enable Thread network diagnostics while not even
compiling in Thread support in the connectivity manager. And this
avoids the codesize hit for platforms that in fact do not support
Thread.

Problem

Codesize increase we don't want.

Change overview

Don't increase codesize.

Testing

Should be tested by normal tests.

@bzbarsky-apple
Remove incorrect GenericConnectivityManagerImpl_NoThread<ImplClass>::…
fd831d5 
…_WriteThreadNetworkDiagnosticAttributeToTlv code.

We should not be doing anything other than returning error here:
consumers should not enable Thread network diagnostics while not even
compiling in Thread support in the connectivity manager.  And this
avoids the codesize hit for platforms that in fact do not support
Thread.
@github-actions
Copy link

github-actions bot commented Jun 27, 2022 •
edited
Loading

PR #20014: Size comparison from e80724e to fd831d5

Increases (1 build for telink)
platform target config section e80724e fd831d5 change % change
telink light-switch-app tlsr9518adk80d text 564996 564998 2 0.0
Decreases (9 builds for efr32, esp32, mbed, p6)
platform target config section e80724e fd831d5 change % change
efr32 lighting-app BRD4161A+rs911x (read/write) 947544 944904 -2640 -0.3
.text 804988 802348 -2640 -0.3
lock-app BRD4161A+wf200 (read/write) 1122096 1121872 -224 -0.0
.text 979080 978856 -224 -0.0
esp32 all-clusters-app c3devkit (read only) 1019304 1018792 -512 -0.1
.flash.text 1019304 1018792 -512 -0.1
m5stack (read only) 1073495 1072919 -576 -0.1
.flash.text 1068111 1067535 -576 -0.1
mbed lock-app CY8CPROTO_062_4343W+release (read/write) 2447696 2447440 -256 -0.0
.text 1410340 1410084 -256 -0.0
p6 all-clusters-app default (read/write) 2566416 2563776 -2640 -0.1
.text 1524680 1522040 -2640 -0.2
all-clusters-minimal-app default (read/write) 2512280 2509624 -2656 -0.1
.text 1470544 1467888 -2656 -0.2
light-app default (read/write) 2442416 2439760 -2656 -0.1
.text 1400680 1398024 -2656 -0.2
lock-app default (read/write) 2468680 2466040 -2640 -0.1
.text 1426944 1424304 -2640 -0.2
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section e80724e fd831d5 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665115 665115 0 0.0
(read/write) 187884 187884 0 0.0
.bss 75892 75892 0 0.0
.data 3356 3356 0 0.0
.rodata 87891 87891 0 0.0
.text 576908 576908 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653911 653911 0 0.0
(read/write) 198384 198384 0 0.0
.bss 75188 75188 0 0.0
.data 3356 3356 0 0.0
.rodata 91399 91399 0 0.0
.text 562196 562196 0 0.0
lock-ftd LP_CC2652R7 (read only) 667655 667655 0 0.0
(read/write) 175488 175488 0 0.0
.bss 72924 72924 0 0.0
.data 3280 3280 0 0.0
.rodata 75983 75983 0 0.0
.text 591192 591192 0 0.0
lock-mtd LP_CC2652R7 (read only) 617071 617071 0 0.0
(read/write) 146040 146040 0 0.0
.bss 68644 68644 0 0.0
.data 3280 3280 0 0.0
.rodata 75863 75863 0 0.0
.text 540720 540720 0 0.0
pump-app LP_CC2652R7 (read only) 677455 677455 0 0.0
(read/write) 166544 166544 0 0.0
.bss 73012 73012 0 0.0
.data 3280 3280 0 0.0
.rodata 88543 88543 0 0.0
.text 588428 588428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 663351 663351 0 0.0
(read/write) 180768 180768 0 0.0
.bss 73132 73132 0 0.0
.data 3276 3276 0 0.0
.rodata 84391 84391 0 0.0
.text 578480 578480 0 0.0
shell LP_CC2652R7 (read only) 657570 657570 0 0.0
(read/write) 190932 190932 0 0.0
.bss 78196 78196 0 0.0
.data 3360 3360 0 0.0
.rodata 84650 84650 0 0.0
.text 572604 572604 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 580646 580646 0 0.0
.app_xip_area 457640 457640 0 0.0
.bss 65968 65968 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 582222 582222 0 0.0
.app_xip_area 459024 459024 0 0.0
.bss 66160 66160 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 583894 583894 0 0.0
.app_xip_area 461736 461736 0 0.0
.bss 65176 65176 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1082196 1082196 0 0.0
.bss 134772 134772 0 0.0
.data 2048 2048 0 0.0
.text 945356 945356 0 0.0
BRD4161A+rpc (read/write) 1136508 1136508 0 0.0
.bss 151460 151460 0 0.0
.data 2260 2260 0 0.0
.text 982768 982768 0 0.0
BRD4161A+rs911x (read/write) 947544 944904 -2640 -0.3
.bss 140488 140488 0 0.0
.data 2048 2048 0 0.0
.text 804988 802348 -2640 -0.3
lock-app BRD4161A+wf200 (read/write) 1122096 1121872 -224 -0.0
.bss 140936 140936 0 0.0
.data 2060 2060 0 0.0
.text 979080 978856 -224 -0.0
window-app BRD4161A (read/write) 1067476 1067476 0 0.0
.bss 134852 134852 0 0.0
.data 2076 2076 0 0.0
.text 930524 930524 0 0.0
esp32 all-clusters-app c3devkit (read only) 1019304 1018792 -512 -0.1
(read/write) 1486850 1486850 0 0.0
.dram0.bss 71840 71840 0 0.0
.dram0.data 14624 14624 0 0.0
.flash.rodata 214960 214960 0 0.0
.flash.text 1019304 1018792 -512 -0.1
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1073495 1072919 -576 -0.1
(read/write) 488944 488944 0 0.0
.dram0.bss 77360 77360 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245444 245444 0 0.0
.flash.text 1068111 1067535 -576 -0.1
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659992 659992 0 0.0
.bss 71292 71292 0 0.0
.data 1992 1992 0 0.0
.text 580908 580908 0 0.0
lock k32w061+release (read/write) 686200 686200 0 0.0
.bss 71764 71764 0 0.0
.data 2004 2004 0 0.0
.text 606632 606632 0 0.0
linux all-clusters-app debug (read only) 2958697 2958697 0 0.0
(read/write) 178200 178200 0 0.0
.bss 85024 85024 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84936 84936 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263837 263837 0 0.0
.text 2517794 2517794 0 0.0
all-clusters-minimal-app debug (read only) 2812809 2812809 0 0.0
(read/write) 170136 170136 0 0.0
.bss 84352 84352 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77576 77576 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 265501 265501 0 0.0
.text 2372418 2372418 0 0.0
bridge-app debug+rpc (read only) 2315217 2315217 0 0.0
(read/write) 148928 148928 0 0.0
.bss 72384 72384 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66952 66952 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 198432 198432 0 0.0
.text 1955170 1955170 0 0.0
chip-tool debug (read only) 10192165 10192165 0 0.0
(read/write) 610856 610856 0 0.0
.bss 24416 24416 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 579064 579064 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 509957 509957 0 0.0
.text 8273429 8273429 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9926388 9926388 0 0.0
(read/write) 675697 675697 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 614632 614632 0 0.0
.dynamic 528 528 0 0.0
.got 13456 13456 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 472980 472980 0 0.0
.text 7913732 7913732 0 0.0
lighting-app debug+rpc (read only) 2552137 2552137 0 0.0
(read/write) 152984 152984 0 0.0
.bss 72928 72928 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 214216 214216 0 0.0
.text 2167714 2167714 0 0.0
lock-app debug (read only) 2513993 2513993 0 0.0
(read/write) 147928 147928 0 0.0
.bss 71296 71296 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228936 228936 0 0.0
.text 2120034 2120034 0 0.0
ota-provider-app debug (read only) 2323049 2323049 0 0.0
(read/write) 141768 141768 0 0.0
.bss 70976 70976 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63064 63064 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 204024 204024 0 0.0
.text 1956370 1956370 0 0.0
ota-requestor-app debug (read only) 2440281 2440281 0 0.0
(read/write) 148640 148640 0 0.0
.bss 73312 73312 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67240 67240 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 208032 208032 0 0.0
.text 2061218 2061218 0 0.0
shell debug (read only) 2548793 2548793 0 0.0
(read/write) 164520 164520 0 0.0
.bss 80936 80936 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 228050 228050 0 0.0
.text 2164450 2164450 0 0.0
thermostat-no-ble arm64 (read only) 2595012 2595012 0 0.0
(read/write) 181793 181793 0 0.0
.bss 88721 88721 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83256 83256 0 0.0
.dynamic 528 528 0 0.0
.got 5088 5088 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165748 165748 0 0.0
.text 2189488 2189488 0 0.0
tv-app debug (read only) 3106193 3106193 0 0.0
(read/write) 279304 279304 0 0.0
.bss 188648 188648 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249920 249920 0 0.0
.text 2668466 2668466 0 0.0
tv-casting-app debug (read only) 5590865 5590865 0 0.0
(read/write) 185136 185136 0 0.0
.bss 73704 73704 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 344201 344201 0 0.0
.text 4969810 4969810 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447696 2447440 -256 -0.0
.bss 215732 215732 0 0.0
.data 5872 5872 0 0.0
.text 1410340 1410084 -256 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1175167 1175167 0 0.0
bss 144666 144666 0 0.0
rodata 141520 141520 0 0.0
text 810060 810060 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1156035 1156035 0 0.0
bss 143902 143902 0 0.0
rodata 133452 133452 0 0.0
text 799768 799768 0 0.0
p6 all-clusters-app default (read/write) 2566416 2563776 -2640 -0.1
.bss 150912 150912 0 0.0
.data 2776 2776 0 0.0
.text 1524680 1522040 -2640 -0.2
all-clusters-minimal-app default (read/write) 2512280 2509624 -2656 -0.1
.bss 150192 150192 0 0.0
.data 2776 2776 0 0.0
.text 1470544 1467888 -2656 -0.2
light-app default (read/write) 2442416 2439760 -2656 -0.1
.bss 142248 142248 0 0.0
.data 2592 2592 0 0.0
.text 1400680 1398024 -2656 -0.2
lock-app default (read/write) 2468680 2466040 -2640 -0.1
.bss 142096 142096 0 0.0
.data 2600 2600 0 0.0
.text 1426944 1424304 -2640 -0.2
telink light-switch-app tlsr9518adk80d (read/write) 798364 798364 0 0.0
bss 72360 72360 0 0.0
noinit 40416 40416 0 0.0
text 564996 564998 2 0.0
lighting-app tlsr9518adk80d (read/write) 818320 818320 0 0.0
bss 73180 73180 0 0.0
noinit 40416 40416 0 0.0
text 581430 581430 0 0.0

@Damian-Nordic Damian-Nordic merged commit 0861153 into project-chip:master Jun 28, 2022
@bzbarsky-apple bzbarsky-apple deleted the no-thread-means-no-threaddiagnostics branch June 28, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@andy31415 andy31415 andy31415 approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @tcarmelveilleux @andy31415 @Damian-Nordic