Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect GenericConnectivityManagerImpl_NoThread<ImplClass>::_WriteThreadNetworkDiagnosticAttributeToTlv code. #20014

Merged
merged 1 commit into from
Jun 28, 2022
Merged

Remove incorrect GenericConnectivityManagerImpl_NoThread<ImplClass>::_WriteThreadNetworkDiagnosticAttributeToTlv code. #20014

merged 1 commit into from
Jun 28, 2022

Commits on Jun 27, 2022

  1. Remove incorrect GenericConnectivityManagerImpl_NoThread<ImplClass>::… 

    …_WriteThreadNetworkDiagnosticAttributeToTlv code.

We should not be doing anything other than returning error here:
consumers should not enable Thread network diagnostics while not even
compiling in Thread support in the connectivity manager.  And this
avoids the codesize hit for platforms that in fact do not support
Thread.
    @bzbarsky-apple
    bzbarsky-apple committed Jun 27, 2022
    Configuration menu
    Copy the full SHA
    fd831d5 View commit details
    Browse the repository at this point in the history