[Android] Implement Event path command #20198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yunhanw-google I request to update about event path (#19437 ). Please check about this. |
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs and
jmartinez-silabs
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #20198: Size comparison from 6c6dca3 to 44026cf Increases (4 builds for cc13x2_26x2, telink)
Decreases (3 builds for cc13x2_26x2, cyw30739)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
PR #20198: Size comparison from 6c6dca3 to d9e3539 Increases (3 builds for cc13x2_26x2, telink)
Decreases (4 builds for cc13x2_26x2, cyw30739, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
|
Fast tracking platform changes. |
| readerForJavaTLV.Init(*apData); | ||
| readerForJson.Init(*apData); | ||
|
|
||
| jobject value = DecodeEventValue(aEventHeader.mPath, readerForJavaObject, &err); |
There was a problem hiding this comment.
I think we should pass the whole eventHeader to android application where it not only has the path, but it has event meta data info, like EventNumber, Priority. Timestamp=timestamp, TimestampType. for example, we may receive a burst of open-close events with short period, which has the same event path, and they have different event number and timestamp, the application would be able to consume/parse them.
There was a problem hiding this comment.
one python event header example is here, https://github.com/project-chip/connectedhomeip/blob/master/src/controller/python/chip/clusters/Attribute.py#L819
please follow-up this @joonhaengHeo, thanks
| @@ -0,0 +1,77 @@ | |||
| /* | |||
There was a problem hiding this comment.
For the file naming, please consider to remove Chip Prefix since current project is called matter.
| private ChipEventPath(ChipPathId endpointId, ChipPathId clusterId, ChipPathId eventId) { | ||
| this.endpointId = endpointId; | ||
| this.clusterId = clusterId; | ||
| this.eventId = eventId; |
There was a problem hiding this comment.
Please have urgent boolean here. in spec, we have record the urgent flag inside path.
https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/data_model/Encoding-Specification.adoc#encoding-EventPathIB
| listOf(attributePath), | ||
| minInterval, | ||
| maxInterval) | ||
| } else if (type == EVENT) { |
There was a problem hiding this comment.
we really should consider to support event and attribute at the same time, in real situation, the chance is to subscribe/read wildcard attribute and event path. Particularly the number of supported subscription for each device is very limited.
| Platform::New<app::ReadClient>(app::InteractionModelEngine::GetInstance(), device->GetExchangeManager(), | ||
| callback->mBufferedReadAdapter, app::ReadClient::InteractionType::Subscribe); | ||
|
|
||
| err = readClient->SendAutoResubscribeRequest(std::move(params)); |
There was a problem hiding this comment.
please also consider to update attribute with SendAutoResubscribeRequest
| jobject eventIdObj = env->CallObjectMethod(eventPath, getEventIdMethod); | ||
| VerifyOrReturnError(eventIdObj != nullptr, CHIP_ERROR_INCORRECT_STATE); | ||
|
|
||
| uint32_t endpointId = 0; |
There was a problem hiding this comment.
endpointid is uint16_t
This was referenced Sep 9, 2022
| } | ||
|
|
||
| // This will overwrite previous events. | ||
| clusterState.getEventStates().put(eventId, eventStateToAdd); |
There was a problem hiding this comment.
events should be stored in array. in real user scenario, you may receive a burst of events, for example, lock/unlock, we would like to record all events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
#19665
Change overview
Add subscribeToEventPath and readEventPath API in Android Platform.
Testing
How was this tested? (at least one bullet point required)