[Android] Support isUrgent variable in Event Path #22356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel and
lazarkov
pullapprove
bot
requested review from
LuDuda,
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #22356: Size comparison from e56afce to 7f94275 Increases (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Sep 2, 2022
| @@ -289,6 +289,7 @@ CHIP_ERROR EventManagement::ConstructEvent(EventLoadOutContext * apContext, Even | |||
| eventPathBuilder.Endpoint(apOptions->mPath.mEndpointId) | |||
| .Cluster(apOptions->mPath.mClusterId) | |||
| .Event(apOptions->mPath.mEventId) | |||
| .IsUrgent(apOptions->mPath.mIsUrgentEvent) | |||
There was a problem hiding this comment.
Why this change? This does not make sense.
There was a problem hiding this comment.
isUrgent is used for requested path for subscribe, and should not be used in event Path builder when constructing event in event management.
| @@ -242,6 +242,8 @@ CHIP_ERROR EventDataIB::Parser::ProcessEventPath(EventPathIB::Parser & aEventPat | |||
| err = aEventPath.GetEvent(&(aConcreteEventPath.mEventId)); | |||
| VerifyOrReturnError(err == CHIP_NO_ERROR, CHIP_ERROR_IM_MALFORMED_EVENT_PATH_IB); | |||
|
|
|||
| err = aEventPath.GetIsUrgent(&(aConcreteEventPath.mIsUrgentEvent)); | |||
There was a problem hiding this comment.
Why do we want to do this? The spec is not very clear on this, but IsUrgent is an input, not an output; EventDataIB should never have it present...
Filed https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/5596 to get this clarified.
There was a problem hiding this comment.
agree, it should be input
yunhanw-google
requested changes
Sep 9, 2022
| @@ -1326,7 +1332,7 @@ CHIP_ERROR ParseEventPath(jobject eventPath, EndpointId & outEndpointId, Cluster | |||
| outEndpointId = static_cast<EndpointId>(endpointId); | |||
| outClusterId = static_cast<ClusterId>(clusterId); | |||
| outEventId = static_cast<EventId>(eventId); | |||
|
|
|||
| outIsUrgentId = isUrgentEvent; | |||
There was a problem hiding this comment.
there is no need to parse the urgent flag when reading event from report.
|
as I point out in this PR, you should just modify java event path, #20198 (comment), then modify subscribe request with optional urgent event path in WildcardFragment. when receiving report, there is no need to parse urgent flag in report |
|
I will check comments and spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed?
issue #22526
Change overview
Add isUrgent in EventPath class.
Testing
How was this tested? (at least one bullet point required)