-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf5-demo] Add simple service discovery code for nrf5 example app #2211
Conversation
Enable openthread
6eb01a0
to
f4e9869
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! LGTM 👍
Just a nit:
Size increase report for "gn_nrf-example-build"
Full report output
|
Size increase report for "gn_linux-example-build"
Full report output
|
Size increase report for "nrf-example-build"
Full report output
|
Size increase report for "nrfconnect-example-build"
Full report output
|
Size increase report for "linux-example-build"
Full report output
|
Size increase report for "esp32-example-build"
Full report output
|
#include <platform/OpenThread/OpenThreadUtils.h> | ||
#include <platform/ThreadStackManager.h> | ||
#include <platform/internal/DeviceNetworkInfo.h> | ||
#include <platform/nRF5/ThreadStackManagerImpl.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're eventually going to have to push this further down into the stack. Having apps/examples be aware of this level of detail feels not great...
This pre-SRP advertisement is not based on anything in the specification. It dates back to 0561e68 ("[nrf5-demo] Add simple service discovery code for nrf5 example app (project-chip#2211)") to allow discovery prior to all of the dependencies of SRP being in place and since then been copied to various other samples. We have SRP now, time to remove it.
This pre-SRP advertisement is not based on anything in the specification. It dates back to 0561e68 ("[nrf5-demo] Add simple service discovery code for nrf5 example app (project-chip#2211)") to allow discovery prior to all of the dependencies of SRP being in place and since then been copied to various other samples. We have SRP now, time to remove it.
This pre-SRP advertisement is not based on anything in the specification. It dates back to 0561e68 ("[nrf5-demo] Add simple service discovery code for nrf5 example app (project-chip#2211)") to allow discovery prior to all of the dependencies of SRP being in place and since then been copied to various other samples. We have SRP now, time to remove it.
This pre-SRP advertisement is not based on anything in the specification. It dates back to 0561e68 ("[nrf5-demo] Add simple service discovery code for nrf5 example app (#2211)") to allow discovery prior to all of the dependencies of SRP being in place and since then been copied to various other samples. We have SRP now, time to remove it.
This pre-SRP advertisement is not based on anything in the specification. It dates back to 0561e68 ("[nrf5-demo] Add simple service discovery code for nrf5 example app (project-chip#2211)") to allow discovery prior to all of the dependencies of SRP being in place and since then been copied to various other samples. We have SRP now, time to remove it.
This PR adds a temporary solution for device discovery by sending UDP broadcasts to port 23367 (just a random port) via thread.