Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf5-demo] Add simple service discovery code for nrf5 example app #2211

Merged
merged 4 commits into from
Aug 18, 2020

Conversation

erjiaqing
Copy link
Contributor

This PR adds a temporary solution for device discovery by sending UDP broadcasts to port 23367 (just a random port) via thread.

Copy link
Contributor

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM 👍

Just a nit:

examples/lock-app/nrf5/main/AppTask.cpp Outdated Show resolved Hide resolved
@github-actions
Copy link

Size increase report for "gn_nrf-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "gn_linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv


@github-actions
Copy link

Size increase report for "nrf-example-build"

File Section File VM
chip-nrf52840-lock-example.out .text 508 508
chip-nrf52840-lock-example.out .bss 0 152
chip-nrf52840-lock-example.out [LOAD #2 [RW]] 0 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.out and ./pull_artifact/chip-nrf52840-lock-example.out:

sections,vmsize,filesize
.debug_info,0,16194
.debug_line,0,668
.text,508,508
.debug_str,0,450
.debug_abbrev,0,320
.debug_loc,0,318
.strtab,0,211
.symtab,0,208
.bss,152,0
.debug_ranges,0,128
.debug_frame,0,64
.debug_aranges,0,16
[LOAD #2 [RW]],-4,0
.debug_macro,0,-145
[Unmapped],0,-508


@github-actions
Copy link

Size increase report for "nrfconnect-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-nrf52840-lock-example.elf and ./pull_artifact/chip-nrf52840-lock-example.elf:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "linux-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-standalone-demo.out and ./pull_artifact/chip-standalone-demo.out:

sections,vmsize,filesize


@github-actions
Copy link

Size increase report for "esp32-example-build"

File Section File VM
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-wifi-echo.elf and ./pull_artifact/chip-wifi-echo.elf:

sections,vmsize,filesize


#include <platform/OpenThread/OpenThreadUtils.h>
#include <platform/ThreadStackManager.h>
#include <platform/internal/DeviceNetworkInfo.h>
#include <platform/nRF5/ThreadStackManagerImpl.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're eventually going to have to push this further down into the stack. Having apps/examples be aware of this level of detail feels not great...

@woody-apple woody-apple merged commit 0561e68 into project-chip:master Aug 18, 2020
mspang added a commit to mspang/connectedhomeip that referenced this pull request Jul 14, 2021
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (project-chip#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Jul 14, 2021
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (project-chip#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
mspang added a commit to mspang/connectedhomeip that referenced this pull request Jul 14, 2021
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (project-chip#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
bzbarsky-apple pushed a commit that referenced this pull request Jul 15, 2021
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (project-chip#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants