Remove demo UDP advertisement from Thread samples #8354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
it has been copied to various other samples.
Change overview
We have SRP now, time to remove it.
Testing
Built all of the samples.
Ran nrfconnect samples & observed lack of traffic @ 5Hz.