Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove demo UDP advertisement from Thread samples #8354

Merged
merged 1 commit into from
Jul 15, 2021

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 14, 2021

Problem

This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
it has been copied to various other samples.

Change overview

We have SRP now, time to remove it.

Testing

Built all of the samples.
Ran nrfconnect samples & observed lack of traffic @ 5Hz.

This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (project-chip#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

Size increase report for "esp32-example-build" from ba12594

File Section File VM
chip-temperature-measurement-app.elf .flash.text -56 -56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,56
.flash.text,-56,-56


@bzbarsky-apple bzbarsky-apple merged commit eeefd22 into project-chip:master Jul 15, 2021
@mspang mspang deleted the for-chip/remove-udp-adv branch July 15, 2021 07:02
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
This pre-SRP advertisement is not based on anything in the
specification. It dates back to 0561e68 ("[nrf5-demo] Add simple
service discovery code for nrf5 example app (project-chip#2211)") to allow discovery
prior to all of the dependencies of SRP being in place and since then
been copied to various other samples.

We have SRP now, time to remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants