Darwin API review fixes for MTRSetupPayload and MTROptionalQRCodeInfo #22566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mrjerryjohns,
msandstedt and
rgoliver
pullapprove
bot
requested review from
selissia,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
pullapprove
bot
added
review - pending
darwin
examples
and removed
examples
darwin
labels
|
PR #22566: Size comparison from 6a45e43 to 51da493 Increases (6 builds for cc13x2_26x2, efr32, esp32, qpg)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Sep 12, 2022
* Rename MTRDiscoveryCapabilitiesNone to MTRDiscoveryCapabilitiesUnknown to indicate capabilities unknown (e.g. manual setup code). * In MTROptionalQRCodeInfo mark integerValue and stringValue as nullable and document they are mutually exclusive. * In MTROptionalQRCodeInfo switch infoType to MTROptionalQRCodeInfoType, not NSNumber. * Change rendezvousInformation to just be a MTRDiscoveryCapabilities value, not nullable NSNumber, with MTRDiscoveryCapabilitiesNone meaning unknown. When parsing QR code, if the value ends up as 0, reset it to MTRDiscoveryCapabilitiesOnNetwork. * Rename setUpPINCode to setupPasscode. * Mark serialNumber as nullable. * Add setupPayloadWithOnboardingPayload class method on MTRSetupPayload. * Stop exposing the various payload parser APIs from the framework; consumers should use setupPayloadWithOnboardingPayload. Fixes project-chip#22543 Fixes project-chip#22539 Addresses part of project-chip#22420
bzbarsky-apple
force-pushed
the
darwin-setup-payload-api
branch
from
51da493
to
e66b672
Compare
|
Fast-tracking platform-specific fix reviewed by platform owner. |
|
PR #22566: Size comparison from 6a45e43 to e66b672 Increases (1 build for qpg)
Decreases (5 builds for bl702, telink)
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Sep 12, 2022
…project-chip#22566) * Rename MTRDiscoveryCapabilitiesNone to MTRDiscoveryCapabilitiesUnknown to indicate capabilities unknown (e.g. manual setup code). * In MTROptionalQRCodeInfo mark integerValue and stringValue as nullable and document they are mutually exclusive. * In MTROptionalQRCodeInfo switch infoType to MTROptionalQRCodeInfoType, not NSNumber. * Change rendezvousInformation to just be a MTRDiscoveryCapabilities value, not nullable NSNumber, with MTRDiscoveryCapabilitiesNone meaning unknown. When parsing QR code, if the value ends up as 0, reset it to MTRDiscoveryCapabilitiesOnNetwork. * Rename setUpPINCode to setupPasscode. * Mark serialNumber as nullable. * Add setupPayloadWithOnboardingPayload class method on MTRSetupPayload. * Stop exposing the various payload parser APIs from the framework; consumers should use setupPayloadWithOnboardingPayload. Fixes project-chip#22543 Fixes project-chip#22539 Addresses part of project-chip#22420
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…project-chip#22566) * Rename MTRDiscoveryCapabilitiesNone to MTRDiscoveryCapabilitiesUnknown to indicate capabilities unknown (e.g. manual setup code). * In MTROptionalQRCodeInfo mark integerValue and stringValue as nullable and document they are mutually exclusive. * In MTROptionalQRCodeInfo switch infoType to MTROptionalQRCodeInfoType, not NSNumber. * Change rendezvousInformation to just be a MTRDiscoveryCapabilities value, not nullable NSNumber, with MTRDiscoveryCapabilitiesNone meaning unknown. When parsing QR code, if the value ends up as 0, reset it to MTRDiscoveryCapabilitiesOnNetwork. * Rename setUpPINCode to setupPasscode. * Mark serialNumber as nullable. * Add setupPayloadWithOnboardingPayload class method on MTRSetupPayload. * Stop exposing the various payload parser APIs from the framework; consumers should use setupPayloadWithOnboardingPayload. Fixes project-chip#22543 Fixes project-chip#22539 Addresses part of project-chip#22420
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…oller. This is a re-landing of some of the API addition parts of project-chip#22596 and project-chip#22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in project-chip#23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 13, 2022
…oller. This is a re-landing of some of the API addition parts of project-chip#22596 and project-chip#22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in project-chip#23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
bzbarsky-apple
added a commit
that referenced
this pull request
Oct 13, 2022
…oller. (#23159) This is a re-landing of some of the API addition parts of #22596 and #22566, without including any of the API changes/removals. The code is nearly identical to what was on master before Darwin framework changes were reverted in #23155; the differences have to do with the different type and name of MTRSetupPayload's rendezvousInformation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #22420
Issue Being Resolved
Change overview
See above.