Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin API review fixes for MTRSetupPayload and MTROptionalQRCodeInfo #22566

Merged

Commits on Sep 12, 2022

  1. Darwin API review fixes for MTRSetupPayload and MTROptionalQRCodeInfo

    * Rename MTRDiscoveryCapabilitiesNone to MTRDiscoveryCapabilitiesUnknown to
      indicate capabilities unknown (e.g. manual setup code).
    * In MTROptionalQRCodeInfo mark integerValue and stringValue as nullable and
      document they are mutually exclusive.
    * In MTROptionalQRCodeInfo switch infoType to MTROptionalQRCodeInfoType, not
      NSNumber.
    * Change rendezvousInformation to just be a MTRDiscoveryCapabilities value, not
      nullable NSNumber, with MTRDiscoveryCapabilitiesNone meaning unknown. When
      parsing QR code, if the value ends up as 0, reset it to
      MTRDiscoveryCapabilitiesOnNetwork.
    * Rename setUpPINCode to setupPasscode.
    * Mark serialNumber as nullable.
    * Add setupPayloadWithOnboardingPayload class method on MTRSetupPayload.
    * Stop exposing the various payload parser APIs from the framework;
      consumers should use setupPayloadWithOnboardingPayload.
    
    Fixes project-chip#22543
    
    Fixes project-chip#22539
    
    Addresses part of project-chip#22420
    bzbarsky-apple committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    e66b672 View commit details
    Browse the repository at this point in the history