Use CopyString() Instead of strncpy() #22708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
controller
efr32
esp32
examples
inet
lib
linux
platform
setup payload
tests
tools
zephyr
labels
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran and
hawk248
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
emargolis
changed the title
|
PR #22708: Size comparison from 989ad8e to cb86607 Increases (14 builds for bl702, cc13x2_26x2, esp32, k32w, nrfconnect)
Decreases (26 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, qpg, telink)
Full report (30 builds for bl702, cc13x2_26x2, esp32, k32w, linux, nrfconnect, qpg, telink)
|
emargolis
force-pushed
the
emargolis/feature/security-replace-strncpy-to-copystring
branch
from
cb86607
to
696276e
Compare
|
PR #22708: Size comparison from 989ad8e to 696276e Increases (20 builds for bl702, cc13x2_26x2, esp32, k32w, mbed, nrfconnect, psoc6)
Decreases (39 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 19, 2022
emargolis
force-pushed
the
emargolis/feature/security-replace-strncpy-to-copystring
branch
from
696276e
to
b997c23
Compare
|
PR #22708: Size comparison from 0cf7694 to b997c23 Increases (20 builds for bl702, cc13x2_26x2, esp32, k32w, mbed, nrfconnect, psoc6)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #22708: Size comparison from 847f450 to 1dca688 Increases (16 builds for bl702, cc13x2_26x2, k32w, nrfconnect, psoc6)
Decreases (32 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, qpg, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, nrfconnect, psoc6, qpg, telink)
|
emargolis
force-pushed
the
emargolis/feature/security-replace-strncpy-to-copystring
branch
from
1dca688
to
31b4541
Compare
|
PR #22708: Size comparison from 3aa138f to 31b4541 Increases (20 builds for bl702, cc13x2_26x2, esp32, k32w, linux, mbed, nrfconnect, psoc6)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, qpg, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
| @@ -195,7 +196,7 @@ class ComplexArgumentParser | |||
|
|
|||
| size_t size = strlen(value.asCString()); | |||
| auto buffer = static_cast<char *>(chip::Platform::MemoryCalloc(size, sizeof(char))); | |||
| strncpy(buffer, value.asCString(), size); | |||
| chip::Platform::CopyString(buffer, size, value.asCString()); | |||
There was a problem hiding this comment.
This is causing a problem since strncpy does not null terminate while CopyString does
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Oct 17, 2022
…::CopyString to memcpy (it previously uses to be strncpy which was confusing)
andy31415
pushed a commit
that referenced
this pull request
Oct 17, 2022
… to memcpy (it previously uses to be strncpy which was confusing) (#23231)
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…::CopyString to memcpy (it previously uses to be strncpy which was confusing) (project-chip#23231)
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…::CopyString to memcpy (it previously uses to be strncpy which was confusing) (project-chip#23231)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
strncpyMax Copy Length Does Not Always Copy Null Terminator #19339Change overview
Replaced strncpy() with CopyString()