Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the explicit request to generate eventList and eventCount #25316

Merged

Conversation

tecimovic
Copy link
Contributor

Recent changes to ZAP and the Matter template have broken backwards compatibility: latest zap was no longer able to operate against older versions of Matter SDK code.

This change addresses this problem:

  1. It puts the elements of endpoint config cluster struct under control of the template.
  2. It sets the default (inside Zap), to how it was before any of these changes happened.

This allows template creator to change the order of the fields or add new fields without breaking backwards compatibility, and at the same time allows older SDKs to be used with newest zap.

This should go hand it hand with the PR:
project-chip/zap#948

If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in. Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.

…erated struct.

Previous change just added them directly in the generation code, which promptly
destroyed all backwards compatibility. With this approach, the default zap
generates as it "always did", but you can request an override to do things
like add new elements, or reorder them.

This should go hand it hand with the PR:
  project-chip/zap#948

If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in.
Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.
@github-actions
Copy link

PR #25316: Size comparison from 31da720 to 5d4da70

Decreases (1 build for cc32xx)
platform target config section 31da720 5d4da70 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20256908 20256906 -2 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section 31da720 5d4da70 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 642681 642681 0 0.0
(read/write) 203672 203672 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197072 197072 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930077 930077 0 0.0
.debug_aranges 87280 87280 0 0.0
.debug_frame 299816 299816 0 0.0
.debug_info 20256908 20256906 -2 -0.0
.debug_line 2656086 2656086 0 0.0
.debug_loc 2797535 2797535 0 0.0
.debug_ranges 281768 281768 0 0.0
.debug_str 3023369 3023369 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105769 105769 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377825 377825 0 0.0
.symtab 256256 256256 0 0.0
.text 534788 534788 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2467168 2467168 0 0.0
.bss 215788 215788 0 0.0
.data 5880 5880 0 0.0
.text 1429812 1429812 0 0.0

@andy31415 andy31415 merged commit cc2546f into project-chip:master Feb 25, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
…erated struct. (project-chip#25316)

Previous change just added them directly in the generation code, which promptly
destroyed all backwards compatibility. With this approach, the default zap
generates as it "always did", but you can request an override to do things
like add new elements, or reorder them.

This should go hand it hand with the PR:
  project-chip/zap#948

If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in.
Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants