Restore matter unit tests and fix backwards compatibility. #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
==========================================
- Coverage 62.13% 62.01% -0.12%
==========================================
Files 155 155
Lines 16624 16661 +37
Branches 3674 3687 +13
==========================================
+ Hits 10330 10333 +3
- Misses 5596 5627 +31
- Partials 698 701 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This work also uncovered the fact that |
tecimovic
added a commit
to tecimovic/matter
that referenced
this pull request
Feb 24, 2023
…erated struct. Previous change just added them directly in the generation code, which promptly destroyed all backwards compatibility. With this approach, the default zap generates as it "always did", but you can request an override to do things like add new elements, or reorder them. This should go hand it hand with the PR: project-chip/zap#948 If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in. Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.
brdandu
approved these changes
Feb 24, 2023
andy31415
pushed a commit
to project-chip/connectedhomeip
that referenced
this pull request
Feb 25, 2023
…erated struct. (#25316) Previous change just added them directly in the generation code, which promptly destroyed all backwards compatibility. With this approach, the default zap generates as it "always did", but you can request an override to do things like add new elements, or reorder them. This should go hand it hand with the PR: project-chip/zap#948 If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in. Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this pull request
Mar 15, 2023
…erated struct. (#25316) Previous change just added them directly in the generation code, which promptly destroyed all backwards compatibility. With this approach, the default zap generates as it "always did", but you can request an override to do things like add new elements, or reorder them. This should go hand it hand with the PR: project-chip/zap#948 If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in. Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…erated struct. (project-chip#25316) Previous change just added them directly in the generation code, which promptly destroyed all backwards compatibility. With this approach, the default zap generates as it "always did", but you can request an override to do things like add new elements, or reorder them. This should go hand it hand with the PR: project-chip/zap#948 If ZAP PR gets merged first, Matter will stay broken with latest zap until this commit is merge in. Matter, however, can merge this commit first without ill effect, and use older zap if it chooses.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.