Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

andy31415 · 2023-03-27T21:04:48Z

For client-code generation, switch logic to pick up all cluster commands and request/response structures.

github-actions · 2023-03-27T21:55:46Z

PR #25853: Size comparison from def9802 to 71b6a80

Increases (2 builds for nrfconnect, qpg)

platform	target	config	section	`def9802`	`71b6a80`	change
nrfconnect	all-clusters-app	nrf7002dk_nrf5340_cpuapp	text	776040	776044	4
qpg	lock-app	qpg6105+debug	(read/write)	1121496	1121504	8
			.text	568596	568604	8

Decreases (1 build for cc32xx)

platform	target	config	section	`def9802`	`71b6a80`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20309907	20309905	-2	-0.0

Full report (11 builds for bl602, bl702, cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`def9802`	`71b6a80`	change	% change
bl602	lighting-app	bl602	(read/write)	1360194	1360194	0	0.0
			.bss	94834	94834	0	0.0
			.data	9776	9776	0	0.0
			.text	1031990	1031990	0	0.0
		bl602+rpc	(read/write)	`1405634`	`1405634`	0	0.0
			.bss	102882	102882	0	0.0
			.data	10168	10168	0	0.0
			.text	1062924	1062924	0	0.0
bl702	lighting-app	bl702		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1192423	1192423	0	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	292	292	0	0.0
			.bss	70113	70113	0	0.0
			.bss_psram	26064	26064	0	0.0
			.comment	48	48	0	0.0
			.data	4096	4096	0	0.0
			.debug_abbrev	1563203	1563203	0	0.0
			.debug_aranges	135440	135440	0	0.0
			.debug_frame	496668	496668	0	0.0
			.debug_info	41081560	41081560	0	0.0
			.debug_line	5328877	5328877	0	0.0
			.debug_loc	3454049	3454049	0	0.0
			.debug_ranges	377504	377504	0	0.0
			.debug_str	3615496	3615496	0	0.0
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	148	148	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	108528	108528	0	0.0
			.rsvd	2960	2960	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	582163	582163	0	0.0
			.symtab	175280	175280	0	0.0
			.tcm_data	36	36	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	962490	962490	0	0.0
		bl702+rpc		0	0	0	0.0
			(read only)	3358	3358	0	0.0
			(read/write)	1283963	1283963	0	0.0
			.bleromro	6342	6342	0	0.0
			.bleromrw	124	124	0	0.0
			.boot2	292	292	0	0.0
			.bss	78161	78161	0	0.0
			.bss_psram	26464	26464	0	0.0
			.comment	48	48	0	0.0
			.data	4648	4648	0	0.0
			.debug_abbrev	1715269	1715269	0	0.0
			.debug_aranges	143800	143800	0	0.0
			.debug_frame	524836	524836	0	0.0
			.debug_info	45734893	45734893	0	0.0
			.debug_line	5735331	5735331	0	0.0
			.debug_loc	`3653051`	`3653051`	0	0.0
			.debug_ranges	401504	401504	0	0.0
			.debug_str	4020163	4020163	0	0.0
			.hbn	536	536	0	0.0
			.hbn_noinit	260	260	0	0.0
			.init	342	342	0	0.0
			.init_array	164	164	0	0.0
			.psram	0	0	0	0.0
			.riscv.attributes	47	47	0	0.0
			.rodata	122832	122832	0	0.0
			.rsvd	2960	2960	0	0.0
			.sha_ocram	72	72	0	0.0
			.shstrtab	304	304	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	643973	643973	0	0.0
			.symtab	193904	193904	0	0.0
			.tcm_data	36	36	0	0.0
			.tcmcode	3358	3358	0	0.0
			.text	`1038508`	`1038508`	0	0.0
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	645745	645745	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933102	933102	0	0.0
			.debug_aranges	87704	87704	0	0.0
			.debug_frame	301604	301604	0	0.0
			.debug_info	20309907	20309905	-2	-0.0
			.debug_line	2680953	2680953	0	0.0
			.debug_loc	`2827596`	`2827596`	0	0.0
			.debug_ranges	286376	286376	0	0.0
			.debug_str	3041114	3041114	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105953	105953	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	380555	380555	0	0.0
			.symtab	257456	257456	0	0.0
			.text	537672	537672	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2466536	2466536	0	0.0
			.bss	215964	215964	0	0.0
			.data	5880	5880	0	0.0
			.text	1429180	1429180	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	`1174080`	`1174080`	0	0.0
			bss	155557	155557	0	0.0
			rodata	132640	132640	0	0.0
			text	805124	805124	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1119152	1119152	0	0.0
			bss	154713	154713	0	0.0
			rodata	109456	109456	0	0.0
			text	774336	774336	0	0.0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1434116	1434116	0	0.0
			bss	135297	135297	0	0.0
			rodata	228692	228692	0	0.0
			text	776040	776044	4	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1152920	1152920	0	0.0
			.bss	96036	96036	0	0.0
			.data	852	852	0	0.0
			.text	600016	600016	0	0.0
	lock-app	qpg6105+debug	(read/write)	1121496	1121504	8	0.0
			.bss	91172	91172	0	0.0
			.data	856	856	0	0.0
			.text	568596	568604	8	0.0

github-actions · 2023-03-27T23:51:32Z

PR #25853: Size comparison from def9802 to d57f557

Increases (3 builds for nrfconnect, qpg)

platform	target	config	section	`def9802`	`d57f557`	change
nrfconnect	all-clusters-app	nrf7002dk_nrf5340_cpuapp	text	776040	776044	4
qpg	lighting-app	qpg6105+debug	(read/write)	1152920	1152928	8
			.text	600016	600024	8
	lock-app	qpg6105+debug	(read/write)	1121496	1121504	8
			.text	568596	568604	8

Decreases (1 build for cc32xx)

platform	target	config	section	`def9802`	`d57f557`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL	.debug_info	20309907	20309906	-1	-0.0

Full report (7 builds for cc32xx, mbed, nrfconnect, qpg)

platform	target	config	section	`def9802`	`d57f557`	change	% change
cc32xx	lock	CC3235SF_LAUNCHXL		0	0	0	0.0
			(read only)	645745	645745	0	0.0
			(read/write)	203848	203848	0	0.0
			.ARM.attributes	44	44	0	0.0
			.ARM.exidx	8	8	0	0.0
			.bss	197248	197248	0	0.0
			.comment	194	194	0	0.0
			.data	1480	1480	0	0.0
			.debug_abbrev	933102	933102	0	0.0
			.debug_aranges	87704	87704	0	0.0
			.debug_frame	301604	301604	0	0.0
			.debug_info	20309907	20309906	-1	-0.0
			.debug_line	2680953	2680953	0	0.0
			.debug_loc	`2827596`	`2827596`	0	0.0
			.debug_ranges	286376	286376	0	0.0
			.debug_str	3041114	3041114	0	0.0
			.ramVecs	780	780	0	0.0
			.resetVecs	64	64	0	0.0
			.rodata	105953	105953	0	0.0
			.shstrtab	232	232	0	0.0
			.stab	204	204	0	0.0
			.stabstr	441	441	0	0.0
			.stack	2048	2048	0	0.0
			.strtab	380555	380555	0	0.0
			.symtab	257456	257456	0	0.0
			.text	537672	537672	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2466536	2466536	0	0.0
			.bss	215964	215964	0	0.0
			.data	5880	5880	0	0.0
			.text	1429180	1429180	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	`1174080`	`1174080`	0	0.0
			bss	155557	155557	0	0.0
			rodata	132640	132640	0	0.0
			text	805124	805124	0	0.0
	all-clusters-minimal-app	nrf52840dk_nrf52840	(read only)	4	4	0	0.0
			(read/write)	1119152	1119152	0	0.0
			bss	154713	154713	0	0.0
			rodata	109456	109456	0	0.0
			text	774336	774336	0	0.0
	all-clusters-app	nrf7002dk_nrf5340_cpuapp	(read only)	4	4	0	0.0
			(read/write)	1434116	1434116	0	0.0
			bss	135297	135297	0	0.0
			rodata	228692	228692	0	0.0
			text	776040	776044	4	0.0
qpg	lighting-app	qpg6105+debug	(read/write)	1152920	1152928	8	0.0
			.bss	96036	96036	0	0.0
			.data	852	852	0	0.0
			.text	600016	600024	8	0.0
	lock-app	qpg6105+debug	(read/write)	1121496	1121504	8	0.0
			.bss	91172	91172	0	0.0
			.data	856	856	0	0.0
			.text	568596	568604	8	0.0

github-actions · 2023-03-28T18:42:22Z

PR #25853: Size comparison from 2bcac10 to 5563fff

Full report (1 build for cc32xx)

platform	target	config	section	`2bcac10`	`5563fff`
cc32xx	lock	CC3235SF_LAUNCHXL		0	0
			(read only)	645745	645745
			(read/write)	203848	203848
			.ARM.attributes	44	44
			.ARM.exidx	8	8
			.bss	197248	197248
			.comment	194	194
			.data	1480	1480
			.debug_abbrev	933102	933102
			.debug_aranges	87704	87704
			.debug_frame	301604	301604
			.debug_info	20309907	20309907
			.debug_line	2680953	2680953
			.debug_loc	`2827596`	`2827596`
			.debug_ranges	286376	286376
			.debug_str	3041114	3041114
			.ramVecs	780	780
			.resetVecs	64	64
			.rodata	105953	105953
			.shstrtab	232	232
			.stab	204	204
			.stabstr	441	441
			.stack	2048	2048
			.strtab	380555	380555
			.symtab	257456	257456
			.text	537672	537672

andy31415 added 4 commits March 27, 2023 12:30

Generate all client-side commands and structures. This requires zap u…

bfc7f26

…pdates after project-chip/zap#981

ZAP regen all

125b9fc

Merge branch 'master' into generate_all_commands_idl_client

dfcfe33

Merge branch 'master' into generate_all_commands_idl_client

7fcf37f

github-actions bot added app controller examples labels Mar 27, 2023

pullapprove bot requested review from tecimovic, turon, vijs, vivien-apple, woody-apple, xylophone21, younghak-hwang, yufengwangca and yunhanw-google March 27, 2023 21:05

andy31415 changed the title ~~Ensure all commands are generated in .matter IDL files~~ Ensure all ccommands are generated for client cluster definitions in .matter IDL files Mar 27, 2023

Use zap 2023.03.27 to pick up clusterName and responseName access

71b6a80

github-actions bot added integrations scripts labels Mar 27, 2023

bzbarsky-apple approved these changes Mar 27, 2023

View reviewed changes

Update minimum zap version

d57f557

andy31415 changed the title ~~Ensure all ccommands are generated for client cluster definitions in .matter IDL files~~ Ensure all commands are generated for client cluster definitions in .matter IDL files Mar 28, 2023

Merge branch 'master' into generate_all_commands_idl_client

9fffbf5

andy31415 mentioned this pull request Mar 28, 2023

Move CHIPReadCallbacks.h in java codegen from zap to jinja #25865

Merged

andreilitvin added 4 commits March 28, 2023 13:20

Start using zcl_commands_source_client instead of chip_cluster_responses

d6339af

Update invoke callbacks too to use updated stateless loop methods

d40e451

Noop update: switch loop method and conditional that is not needed

4996268

Switch to source_server instead of source_client

5563fff

tehampson approved these changes Mar 28, 2023

View reviewed changes

pullapprove bot added review - approved and removed review - pending labels Mar 28, 2023

chrisdecenzo approved these changes Mar 28, 2023

View reviewed changes

andy31415 merged commit 040c65d into project-chip:master Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

andy31415 commented Mar 27, 2023

github-actions bot commented Mar 27, 2023

github-actions bot commented Mar 27, 2023

github-actions bot commented Mar 28, 2023

Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

Conversation

andy31415 commented Mar 27, 2023

github-actions bot commented Mar 27, 2023

github-actions bot commented Mar 27, 2023

github-actions bot commented Mar 28, 2023