Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

Merged
merged 11 commits into from
Mar 28, 2023
Merged

Ensure all commands are generated for client cluster definitions in .matter IDL files #25853

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
bfc7f26
Generate all client-side commands and structures. This requires zap u…
andy31415 Mar 27, 2023
125b9fc
ZAP regen all
andy31415 Mar 27, 2023
dfcfe33
Merge branch 'master' into generate_all_commands_idl_client
andy31415 Mar 27, 2023
7fcf37f
Merge branch 'master' into generate_all_commands_idl_client
andy31415 Mar 27, 2023
71b6a80
Use zap 2023.03.27 to pick up clusterName and responseName access
andy31415 Mar 27, 2023
d57f557
Update minimum zap version
andy31415 Mar 27, 2023
9fffbf5
Merge branch 'master' into generate_all_commands_idl_client
andreilitvin Mar 28, 2023
d6339af
Start using zcl_commands_source_client instead of chip_cluster_responses
andreilitvin Mar 28, 2023
d40e451
Update invoke callbacks too to use updated stateless loop methods
andreilitvin Mar 28, 2023
4996268
Noop update: switch loop method and conditional that is not needed
andreilitvin Mar 28, 2023
5563fff
Switch to source_server instead of source_client
andreilitvin Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Noop update: switch loop method and conditional that is not needed
  • Loading branch information
@andreilitvin
andreilitvin committed Mar 28, 2023
commit 4996268070deb72dedf8f300580212e451d2f4a0
7 changes: 2 additions & 5 deletions src/controller/java/templates/CHIPReadCallbacks.zapt
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{{> header}}
{{#if (chip_has_client_clusters)}}
#include <jni/CHIPCallbackTypes.h>

#include <controller/java/AndroidCallbacks.h>
@@ -36,7 +35,7 @@ private:
{{/unless}}
{{/chip_server_global_responses}}

{{#chip_client_clusters}}
{{#all_user_clusters}}
{{#zcl_attributes_server removeKeys='isOptional'}}
{{#if_unsupported_attribute_callback type isArray ../id}}
{{else}}
@@ -70,6 +69,4 @@ private:

{{/if_unsupported_attribute_callback}}
{{/zcl_attributes_server}}
{{/chip_client_clusters}}

{{/if}}
{{/all_user_clusters}}