[ReadHandler] Removed Scheduling of report from OnReadHandlerCreated #28536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d immediate scheduling before the intervals are negotiated
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
…d accessors for clarity
lpbeliveau-silabs
force-pushed
the
bugfix/remove_emission_on_readhandler_created
branch
from
09db523
to
39156c7
Compare
|
PR #28536: Size comparison from 732f797 to 39156c7 Increases (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #28536: Size comparison from 732f797 to 61100df Increases (13 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, qpg)
Full report (14 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, qpg)
|
…ReadReport() method for readhandler for read request. Fixed call order in TestReportScheduler tests
|
PR #28536: Size comparison from 732f797 to ad530a1 Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for cc32xx, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…dded comment for OnReadHandlerSubscribed and modified reporting condition for Read reports to be sent independently from the report scheduler
|
PR #28536: Size comparison from 732f797 to dec8006 Increases above 0.2%:
Increases (12 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect, qpg)
Full report (12 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect, qpg)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
lpbeliveau-silabs
force-pushed
the
bugfix/remove_emission_on_readhandler_created
branch
from
e9a084d
to
6a6806f
Compare
|
PR #28536: Size comparison from 7353fd6 to 6a6806f Increases (12 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Full report (12 builds for cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
|
PR #28536: Size comparison from 7353fd6 to 3f33bc0 Increases (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
Full report (17 builds for bl602, bl702, bl702l, cc32xx, k32w, linux, mbed, nrfconnect, qpg)
|
bzbarsky-apple
approved these changes
Aug 10, 2023
|
PR #28536: Size comparison from 7353fd6 to 0802082 Increases (59 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Aug 10, 2023
This was referenced Aug 10, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 15, 2023
…roject-chip#28536) * Removed Scheduling of report from OnReadHandlerCreated since it caused immediate scheduling before the intervals are negotiated * Separated Read reports from Subscription reports and renamed flags and accessors for clarity * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Put back rescheduling in the OnReadHandlerSubscribed, added a CanEmitReadReport() method for readhandler for read request. Fixed call order in TestReportScheduler tests * Removed redundancy by removing un-necessary OnSubscriptionAction(), added comment for OnReadHandlerSubscribed and modified reporting condition for Read reports to be sent independently from the report scheduler * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Appplied change to method name and fixe condition in SetStateFlag * Update src/app/ReadHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Removed un-necessary check in SetStateFlag --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
s07641069
pushed a commit
to s07641069/connectedhomeip
that referenced
this pull request
Aug 22, 2023
…roject-chip#28536) * Removed Scheduling of report from OnReadHandlerCreated since it caused immediate scheduling before the intervals are negotiated * Separated Read reports from Subscription reports and renamed flags and accessors for clarity * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Put back rescheduling in the OnReadHandlerSubscribed, added a CanEmitReadReport() method for readhandler for read request. Fixed call order in TestReportScheduler tests * Removed redundancy by removing un-necessary OnSubscriptionAction(), added comment for OnReadHandlerSubscribed and modified reporting condition for Read reports to be sent independently from the report scheduler * Apply suggestions from code review Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Appplied change to method name and fixe condition in SetStateFlag * Update src/app/ReadHandler.h Co-authored-by: Boris Zbarsky <bzbarsky@apple.com> * Removed un-necessary check in SetStateFlag --------- Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scheduling in OnReadHandlerCreated method triggered the immediate scheduling before the intervals are negotiated.
This might be the root cause of the issue: #28434