Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReadHandler] Removed Scheduling of report from OnReadHandlerCreated #28536

Merged
merged 9 commits into from
Aug 10, 2023
Merged

[ReadHandler] Removed Scheduling of report from OnReadHandlerCreated #28536

merged 9 commits into from
Aug 10, 2023

Commits on Aug 4, 2023

  1. Removed Scheduling of report from OnReadHandlerCreated since it cause… 

    …d immediate scheduling before the intervals are negotiated
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3dfc095 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Separated Read reports from Subscription reports and renamed flags an… 

    …d accessors for clarity
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    39156c7 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    @lpbeliveau-silabs @bzbarsky-apple
    lpbeliveau-silabs and bzbarsky-apple authored Aug 8, 2023
    Configuration menu
    Copy the full SHA
    61100df View commit details
    Browse the repository at this point in the history

  3. Put back rescheduling in the OnReadHandlerSubscribed, added a CanEmit… 

    …ReadReport() method for readhandler for read request. Fixed call order in TestReportScheduler tests
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 8, 2023
    Configuration menu
    Copy the full SHA
    ad530a1 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Removed redundancy by removing un-necessary OnSubscriptionAction(), a… 

    …dded comment for OnReadHandlerSubscribed and modified reporting condition for Read reports to be sent independently from the report scheduler
    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    dec8006 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    @lpbeliveau-silabs @bzbarsky-apple
    lpbeliveau-silabs and bzbarsky-apple authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9b177eb View commit details
    Browse the repository at this point in the history

  3. Appplied change to method name and fixe condition in SetStateFlag

    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    6a6806f View commit details
    Browse the repository at this point in the history

  4. Update src/app/ReadHandler.h 

    Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
    @lpbeliveau-silabs @bzbarsky-apple
    lpbeliveau-silabs and bzbarsky-apple authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3f33bc0 View commit details
    Browse the repository at this point in the history

  5. Removed un-necessary check in SetStateFlag

    @lpbeliveau-silabs
    lpbeliveau-silabs committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    0802082 View commit details
    Browse the repository at this point in the history