-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that MTRDevice invokes provide a timed invoke timeout when needed. #29855
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:timed-invoke-defaulting
Oct 19, 2023
Merged
Ensure that MTRDevice invokes provide a timed invoke timeout when needed. #29855
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:timed-invoke-defaulting
Oct 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
October 18, 2023 22:57
pullapprove
bot
requested review from
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang and
yufengwangca
October 18, 2023 22:58
PR #29855: Size comparison from f47aed4 to f07b8a5 Full report (17 builds for cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg)
|
…ded. If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.
bzbarsky-apple
force-pushed
the
timed-invoke-defaulting
branch
from
October 18, 2023 23:50
f07b8a5
to
e3e11b9
Compare
woody-apple
approved these changes
Oct 18, 2023
PR #29855: Size comparison from f47aed4 to e3e11b9 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Oct 19, 2023
…ded. (project-chip#29855) If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ded. (project-chip#29855) If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ded. (project-chip#29855) (project-chip#29871) If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…ded. (project-chip#29855) If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.
shripad621git
pushed a commit
to shripad621git/connectedhomeip
that referenced
this pull request
Oct 31, 2023
…ded. (project-chip#29855) (project-chip#29871) If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we know the command being invoked needs a timed invoke, and the caller did not provide a timed invoke timeout, go ahead and use a default one.