Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Ensure that MTRDevice invokes provide a timed invoke timeout when needed." #29869

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Revert "Ensure that MTRDevice invokes provide a timed invoke timeout when needed." #29869

merged 1 commit into from
Oct 19, 2023

Conversation

woody-apple
Copy link
Contributor

Reverts #29855

@woody-apple woody-apple merged commit a5b74eb into master Oct 19, 2023
47 of 49 checks passed
@woody-apple woody-apple deleted the revert-29855-timed-invoke-defaulting branch October 19, 2023 18:14
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited
Loading

PR #29869: Size comparison from b9d525e to c8b79f1

Full report (36 builds for bl602, bl702, bl702l, k32w, mbed, nrfconnect, telink)
platform target config section b9d525e c8b79f1 change % change
bl602 lighting-app bl602 (read/write) 1388654 1388654 0 0.0
.bss 88168 88168 0 0.0
.data 9368 9368 0 0.0
.text 1065242 1065242 0 0.0
bl602+mfd (read/write) 1402990 1402990 0 0.0
.bss 88336 88336 0 0.0
.data 9344 9344 0 0.0
.text 1080474 1080474 0 0.0
bl602+rpc (read/write) 1435666 1435666 0 0.0
.bss 96200 96200 0 0.0
.data 9744 9744 0 0.0
.text 1096718 1096718 0 0.0
bl702 lighting-app bl702 (read/write) 1210159 1210159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 32573 32573 0 0.0
.bss_psram 65728 65728 0 0.0
.comment 48 48 0 0.0
.data 3576 3576 0 0.0
.debug_abbrev 1540091 1540091 0 0.0
.debug_aranges 138736 138736 0 0.0
.debug_frame 508336 508336 0 0.0
.debug_info 41458377 41458377 0 0.0
.debug_line 5437405 5437405 0 0.0
.debug_loc 3651606 3651606 0 0.0
.debug_ranges 444560 444560 0 0.0
.debug_str 4067340 4067340 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106600 106600 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 598151 598151 0 0.0
.symtab 178896 178896 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
972304 972304 0 0.0
bl702+mfd (read/write) 1221187 1221187 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 32749 32749 0 0.0
.bss_psram 65728 65728 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1542167 1542167 0 0.0
.debug_aranges 139904 139904 0 0.0
.debug_frame 513740 513740 0 0.0
.debug_info 41499383 41499383 0 0.0
.debug_line 5477578 5477578 0 0.0
.debug_loc 3689691 3689691 0 0.0
.debug_ranges 446800 446800 0 0.0
.debug_str 4072871 4072871 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 148 148 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 105540 105540 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 601911 601911 0 0.0
.symtab 180656 180656 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
984248 984248 0 0.0
bl702+rpc (read/write) 1310427 1310427 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41037 41037 0 0.0
.bss_psram 65712 65712 0 0.0
.comment 48 48 0 0.0
.data 4128 4128 0 0.0
.debug_abbrev 1721048 1721048 0 0.0
.debug_aranges 147336 147336 0 0.0
.debug_frame 537348 537348 0 0.0
.debug_info 46602425 46602425 0 0.0
.debug_line 5867678 5867678 0 0.0
.debug_loc 3859103 3859103 0 0.0
.debug_ranges 472112 472112 0 0.0
.debug_str 4495180 4495180 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 164 164 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121500 121500 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 662108 662108 0 0.0
.symtab 198016 198016 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
1048110 1048110 0 0.0
bl706-eth (read only) 3318 3318 0 0.0
(read/write) 1037315 1037315 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 30006 30006 0 0.0
.bss_psram 97671 97671 0 0.0
.comment 48 48 0 0.0
.data 3248 3248 0 0.0
.debug_abbrev 1082038 1082038 0 0.0
.debug_aranges 115112 115112 0 0.0
.debug_frame 424972 424972 0 0.0
.debug_info 22576536 22576536 0 0.0
.debug_line 4291928 4291928 0 0.0
.debug_loc 3147619 3147619 0 0.0
.debug_ranges 380680 380680 0 0.0
.debug_str 3639691 3639691 0 0.0
.hbn 184 184 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 156 156 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 96124 96124 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 464952 464952 0 0.0
.symtab 139936 139936 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3318 3318 0 0.0
.text 0 0 0 0.0
784932 784932 0 0.0
bl706-wifi (read only) 3846 3846 0 0.0
(read/write) 1205646 1205646 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 14597 14597 0 0.0
.bss_psram 98439 98439 0 0.0
.comment 48 48 0 0.0
.data 3560 3560 0 0.0
.debug_abbrev 1174427 1174427 0 0.0
.debug_aranges 119288 119288 0 0.0
.debug_frame 617056 617056 0 0.0
.debug_info 23741972 23741972 0 0.0
.debug_line 4535967 4535967 0 0.0
.debug_loc 3247588 3247588 0 0.0
.debug_ranges 390736 390736 0 0.0
.debug_str 3711982 3711982 0 0.0
.hbn 468 468 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.ocram_bss 8416 8416 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 109252 109252 0 0.0
.rsvd 4 4 0 0.0
.shstrtab 297 297 0 0.0
.stack 2048 2048 0 0.0
.strtab 505679 505679 0 0.0
.symtab 152800 152800 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3846 3846 0 0.0
.text 0 0 0 0.0
953328 953328 0 0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1171792 1171792 0 0.0
.boot2 328 328 0 0.0
.bss 20464 20464 0 0.0
.bss_psram 78848 78848 0 0.0
.comment 48 48 0 0.0
.data 4528 4528 0 0.0
.debug_abbrev 1538608 1538608 0 0.0
.debug_aranges 133784 133784 0 0.0
.debug_frame 489528 489528 0 0.0
.debug_info 41252821 41252821 0 0.0
.debug_line 5351449 5351449 0 0.0
.debug_loc 3597983 3597983 0 0.0
.debug_ranges 451552 451552 0 0.0
.debug_str 4094091 4094091 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100580 100580 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 600464 600464 0 0.0
.symtab 178512 178512 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
956790 956790 0 0.0
bl702l+mfd (read only) 278 278 0 0.0
(read/write) 1182912 1182912 0 0.0
.boot2 328 328 0 0.0
.bss 20640 20640 0 0.0
.bss_psram 78848 78848 0 0.0
.comment 48 48 0 0.0
.data 4496 4496 0 0.0
.debug_abbrev 1540699 1540699 0 0.0
.debug_aranges 134952 134952 0 0.0
.debug_frame 494928 494928 0 0.0
.debug_info 41295870 41295870 0 0.0
.debug_line 5391499 5391499 0 0.0
.debug_loc 3636068 3636068 0 0.0
.debug_ranges 453792 453792 0 0.0
.debug_str 4099612 4099612 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 148 148 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 99520 99520 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 604292 604292 0 0.0
.symtab 180304 180304 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
968826 968826 0 0.0
k32w contact k32w0+release (read only) 588660 588660 0 0.0
(read/write) 87492 87492 0 0.0
.bss 70736 70736 0 0.0
.data 2132 2132 0 0.0
.text 588124 588124 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 683852 683852 0 0.0
.bss 66952 66952 0 0.0
.data 2716 2716 0 0.0
.text 570704 570704 0 0.0
light k32w0+release (read only) 588380 588380 0 0.0
(read/write) 87176 87176 0 0.0
.bss 70432 70432 0 0.0
.data 2120 2120 0 0.0
.text 587844 587844 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 775672 775672 0 0.0
.bss 76620 76620 0 0.0
.data 1928 1928 0 0.0
.text 653664 653664 0 0.0
lock k32w0+release (read only) 560196 560196 0 0.0
(read/write) 85004 85004 0 0.0
.bss 68320 68320 0 0.0
.data 2060 2060 0 0.0
.text 559660 559660 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2522104 2522104 0 0.0
.bss 219048 219048 0 0.0
.data 5136 5136 0 0.0
.text 1484788 1484788 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1220928 1220928 0 0.0
bss 154069 154069 0 0.0
rodata 140204 140204 0 0.0
text 847700 847700 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1342680 1342680 0 0.0
bss 140079 140079 0 0.0
rodata 135648 135648 0 0.0
text 776304 776304 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160444 1160444 0 0.0
bss 153994 153994 0 0.0
rodata 113712 113712 0 0.0
text 813720 813720 0 0.0
telink air-quality-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 856136 856136 0 0.0
bss 77996 77996 0 0.0
text 603762 603762 0 0.0
all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1122940 1122940 0 0.0
bss 112724 112724 0 0.0
text 780402 780402 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 1076136 1076136 0 0.0
bss 122236 122236 0 0.0
text 743904 743904 0 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931432 931432 0 0.0
bss 106876 106876 0 0.0
text 640958 640958 0 0.0
contact-sensor-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 859488 859488 0 0.0
bss 78120 78120 0 0.0
text 606828 606828 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 4 4 0 0.0
(read/write) 961672 961672 0 0.0
bss 88184 88184 0 0.0
text 683308 683308 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1087388 1087388 0 0.0
bss 112384 112384 0 0.0
text 761600 761600 0 0.0
lock-app-dfu tlsr9528a (read only) 4 4 0 0.0
(read/write) 918012 918012 0 0.0
bss 78812 78812 0 0.0
text 637760 637760 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944760 944760 0 0.0
bss 104976 104976 0 0.0
text 656730 656730 0 0.0
pump-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 863364 863364 0 0.0
bss 78228 78228 0 0.0
text 611034 611034 0 0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 804232 804232 0 0.0
bss 66248 66248 0 0.0
text 578070 578070 0 0.0
resource-monitoring-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 819888 819888 0 0.0
bss 66652 66652 0 0.0
text 588650 588650 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 708928 708928 0 0.0
bss 86424 86424 0 0.0
text 461962 461962 0 0.0
smoke_co_alarm-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 861880 861880 0 0.0
bss 78204 78204 0 0.0
text 610152 610152 0 0.0
temperature-measurement-app tlsr9528a (read only) 4 4 0 0.0
(read/write) 847176 847176 0 0.0
bss 77932 77932 0 0.0
text 597568 597568 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 825276 825276 0 0.0
bss 66536 66536 0 0.0
text 593394 593394 0 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 822740 822740 0 0.0
bss 66888 66888 0 0.0
text 590442 590442 0 0.0

HunsupJung pushed a commit to HunsupJung/connectedhomeip that referenced this pull request Oct 23, 2023
@woody-apple @HunsupJung
Revert "Ensure that MTRDevice invokes provide a timed invoke timeout …
ee126ee 
…when needed." (project-chip#29869)
shripad621git pushed a commit to shripad621git/connectedhomeip that referenced this pull request Oct 31, 2023
@woody-apple @shripad621git
Revert "Ensure that MTRDevice invokes provide a timed invoke timeout …
637b60b 
…when needed." (project-chip#29869)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
darwin review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@woody-apple