-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors in sending messages during commissioning. #30068
Merged
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:handle-commissioning-send-errors
Nov 1, 2023
Merged
Handle errors in sending messages during commissioning. #30068
mergify
merged 1 commit into
project-chip:master
from
bzbarsky-apple:handle-commissioning-send-errors
Nov 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mhazley
October 27, 2023 17:38
pullapprove
bot
requested review from
tecimovic,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
October 27, 2023 17:38
andy31415
approved these changes
Oct 27, 2023
PR #30068: Size comparison from 9656351 to b05cfe6 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pidarped
approved these changes
Oct 27, 2023
bzbarsky-apple
force-pushed
the
handle-commissioning-send-errors
branch
from
October 31, 2023 17:13
b05cfe6
to
4942c5e
Compare
PR #30068: Size comparison from 5c9d8e8 to 4942c5e Increases above 0.2%:
Increases (3 builds for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Oct 31, 2023
bzbarsky-apple
force-pushed
the
handle-commissioning-send-errors
branch
from
October 31, 2023 20:12
4942c5e
to
0391c5f
Compare
PR #30068: Size comparison from e68186f to 0391c5f Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Oct 31, 2023
The commissioning state machine, when handling a state, needs to either queue up an async process that will eventually push the state machine along or needs to fail out and stop the commissioning process. We had a number of state handlers that could fail to do both if the attempt to send the message failed, which would leave the commissioner in a stuck state where it thought it was waiting for the async work, while the async work was not queued. This change adds the relevant error checks to ensure we never wait for work that has not started. Fixes project-chip#30041
bzbarsky-apple
force-pushed
the
handle-commissioning-send-errors
branch
from
November 1, 2023 13:32
0391c5f
to
c872f19
Compare
PR #30068: Size comparison from 6ec33d4 to c872f19 Increases above 0.2%:
Increases (3 builds for linux)
Decreases (1 build for linux)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commissioning state machine, when handling a state, needs to either queue up an async process that will eventually push the state machine along or needs to fail out and stop the commissioning process. We had a number of state handlers that could fail to do both if the attempt to send the message failed, which would leave the commissioner in a stuck state where it thought it was waiting for the async work, while the async work was not queued.
This change adds the relevant error checks to ensure we never wait for work that has not started.
Fixes #30041