Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in sending messages during commissioning. #30068

Merged

Commits on Nov 1, 2023

  1. Handle errors in sending messages during commissioning.

    The commissioning state machine, when handling a state, needs to either queue up
    an async process that will eventually push the state machine along or needs to
    fail out and stop the commissioning process.  We had a number of state handlers
    that could fail to do both if the attempt to send the message failed, which
    would leave the commissioner in a stuck state where it thought it was waiting
    for the async work, while the async work was not queued.
    
    This change adds the relevant error checks to ensure we never wait for work that
    has not started.
    
    Fixes project-chip#30041
    bzbarsky-apple committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c872f19 View commit details
    Browse the repository at this point in the history