TC_DISHM_1_2
TC_DISHM_2_1
TC_DISHM_3_1
TC_DISHM_3_3
TC_LWM_1_1
TC_LWM_1_2
TC_OTCCM_1_1
TC_OTCCM_1_2
TC_OTCCM_2_1
TC_OTCCM_3_1
TC_OTCCM_3_3
TC_TCCM_1_1
TC_TCCM_1_2

TC-LWM-1.1
TC_TCCM-1.1
TC-OTCCM-1.1

TC-CNET-4.1
TC-CONTENTLAUNCHER-10.4
TC-DRYERCTRL-2.1
TC-MEDIAPLAYBACK-6.8
TC-MEDIAPLAYBACK-6.9
TC-MEDIAPLAYBACK-6.10
TC-OTCCM-1.2

…23_new

TC_DISHM_1_2
TC_DISHM_2_1
TC_DISHM_3_1
TC_DISHM_3_3
TC_LWM_1_1
TC_LWM_1_2
TC_OTCCM_1_1
TC_OTCCM_1_2
TC_OTCCM_2_1
TC_OTCCM_3_1
TC_OTCCM_3_3
TC_TCCM_1_1
TC_TCCM_1_2

TC-LWM-1.1
TC_TCCM-1.1
TC-OTCCM-1.1

TC-CNET-4.1
TC-CONTENTLAUNCHER-10.4
TC-DRYERCTRL-2.1
TC-MEDIAPLAYBACK-6.8
TC-MEDIAPLAYBACK-6.9
TC-MEDIAPLAYBACK-6.10
TC-OTCCM-1.2

…sa/connectedhomeip into Modified_tests_Jan_23_new

TC_DISHM_1_2
TC_DISHM_2_1
TC_DISHM_3_1
TC_DISHM_3_3
TC_LWM_1_1
TC_LWM_1_2
TC_OTCCM_1_1
TC_OTCCM_1_2
TC_OTCCM_2_1
TC_OTCCM_3_1
TC_OTCCM_3_3
TC_TCCM_1_1
TC_TCCM_1_2

TC-LWM-1.1
TC_TCCM-1.1
TC-OTCCM-1.1

TC-CNET-4.1
TC-CONTENTLAUNCHER-10.4
TC-DRYERCTRL-2.1
TC-MEDIAPLAYBACK-6.8
TC-MEDIAPLAYBACK-6.9
TC-MEDIAPLAYBACK-6.10
TC-OTCCM-1.2

…or the reboot cause so different stacks can obtain it (project-chip#31891)

…#31917)

Bumps [third_party/imgui/repo](https://github.com/ocornut/imgui) from `96839b4` to `f50ddc4`.
- [Release notes](https://github.com/ocornut/imgui/releases)
- [Commits](ocornut/imgui@96839b4...f50ddc4)

---
updated-dependencies:
- dependency-name: third_party/imgui/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…p#31915)

Bumps [third_party/nanopb/repo](https://github.com/nanopb/nanopb) from `f8724ee` to `1f0c2e1`.
- [Commits](nanopb/nanopb@f8724ee...1f0c2e1)

---
updated-dependencies:
- dependency-name: third_party/nanopb/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…-chip#31912)

Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `bf587dd` to `cf357d7`.
- [Release notes](https://github.com/openthread/openthread/releases)
- [Commits](openthread/openthread@bf587dd...cf357d7)

---
updated-dependencies:
- dependency-name: third_party/openthread/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [github/issue-labeler](https://github.com/github/issue-labeler) from 3.3 to 3.4.
- [Release notes](https://github.com/github/issue-labeler/releases)
- [Commits](github/issue-labeler@v3.3...v3.4)

---
updated-dependencies:
- dependency-name: github/issue-labeler
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…31919)

Bumps [natiginfo/action-detekt-all](https://github.com/natiginfo/action-detekt-all) from 1.23.4 to 1.23.5.
- [Release notes](https://github.com/natiginfo/action-detekt-all/releases)
- [Commits](natiginfo/action-detekt-all@1.23.4...1.23.5)

---
updated-dependencies:
- dependency-name: natiginfo/action-detekt-all
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add "orphan" files from bdx to gn

This should help layer enforcement.

* Restyle

…t-chip#31893)

We seem to be hitting the 4-retry cap a lot.  The question is whether waiting an
extra few seconds would help or not.

Co-authored-by: Andrei Litvin <andy314@gmail.com>

…p#31846)

* Add missing function to set delegate in Door Lock Server

* Restyled by clang-format (project-chip#31847)

Co-authored-by: Restyled.io <commits@restyled.io>

---------

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>

…ip#31913)

Bumps [third_party/mbedtls/repo](https://github.com/ARMmbed/mbedtls) from `1b9cea3` to `6b36a5d`.
- [Release notes](https://github.com/ARMmbed/mbedtls/releases)
- [Commits](Mbed-TLS/mbedtls@1b9cea3...6b36a5d)

---
updated-dependencies:
- dependency-name: third_party/mbedtls/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Updated PICS and server yamls Test_TC_... to fit test plan

* Apply suggestions convert hex to dec base

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>

* Updated remaining transition times and added delay for Darwin CI test

* Added verification for steps 4b and 4c in TC_S_2_5

* Restyled by whitespace

* Restyled by prettier-yaml

* Removed Un-necessary PICS, added verification where it was missing in TC_S_2_5 and TC_S_2_6

---------

Co-authored-by: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>

…t-chip#31914)

Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `13d583e` to `9326cc3`.
- [Release notes](https://github.com/openthread/ot-br-posix/releases)
- [Commits](openthread/ot-br-posix@13d583e...9326cc3)

---
updated-dependencies:
- dependency-name: third_party/ot-br-posix/repo
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

)

* [Tizen] Use spec complaint BLE advertising intervals

* Transition from fast adv to slow after timeout

* Refactor Tizen specific BLE initialization function

* Use ScheduleLambda instead of ScheduleWork

* Wrap C callbacks with lambda to make methods non-static

* Define BLE_CONNECTION_OBJECT for Tizen platform

* Get rid of another static method

* Update name to align with convention

* Do not use sInstance directly if possible

…t-chip#31866)

* Added the --app-pid flag to the python matter testing support to provide a way for test scripts to get the PID of the app they are running against.

* fixed typo.

Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com>

---------

Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com>

* TC-ACE-2.1/2: Update default timeout

* Fix default timeout

Hey, you know what helps? Committing changes in the correct
branch before uploading.

* python testing: Add PICS parser for xml

Code blatently stolen from Jon Rhees.

* Restyled by isort

* remove some debug

---------

Co-authored-by: Restyled.io <commits@restyled.io>

* [Linux] Do not reuse cancellable object

Per documentation for g_cancellable_reset():

> Note that it is generally not a good idea to reuse an existing
> cancellable for more operations after it has been cancelled once, as
> this function might tempt you to do. The recommended practice is to
> drop the reference to a cancellable after cancelling it, and let it
> die with the outstanding async operations.

* Update cancellable in ChipDeviceScanner

)

* Refactor time members

* add using namespace

* Fix ActiveModeThreshold type and cast

project-chip#31792)

…ect-chip#31932)

* Handle Aliro credential in door lock server

* Restyled by clang-format (project-chip#31933)

Co-authored-by: Restyled.io <commits@restyled.io>

* Update src/app/clusters/door-lock-server/door-lock-server.cpp

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* Restyled by clang-format (project-chip#31935)

Co-authored-by: Restyled.io <commits@restyled.io>

* Update constant name from git chage

* Update to use SupportsAliroProvisioning API

---------

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

…amework. (project-chip#31814)

* Implement support for more configurable server endpoints in Matter.framework.

* Public APIs on MTRDeviceController to add/remove an endpoint.
* Internal APIs on MTRDeviceController to query the access grants for a cluster
  path and the declared "minimum privilege needed" to read a given attribute.
* Changes to the controller factory to stop using app/dynamic_server and instead
  use the new infrastructure to expose OTA Provider on endpoint 0.
* Internal APIs on the controller factory to query access grants and declared
  privileges.
* An implemenation of AccessControl::Delegate to do ACL checks using the
  above-mentioned APIs.
* A fix to MTRServerAttribute's setValue for arrays: it was not expecting the
  correct data-value structure for an array.  This requires fixing some tests
  too, to provide the right structures.
* Changes to the MTRServer* data structures to allow passing nil to
  associateWithController, to support the OTA endpoint which is not associated
  with any controller.
* Changes to MTRServerCluster to create an AttributeAccessInterface, the set of
  EmberAfAttributeMetadata needed to represent its attributes, and various other
  things needed to register a cluster with the "ember" bits.
* Changes to MTRServerEndpoint to create an EmberAfEndpointType, a list of
  EmberAfCluster, and various other things needed to register an endpoint with
  the "ember" bits.
* (Re-)addition of MTRIMDispatch to handle command dispatch for OTA and host a
  few other functions the "ember" bits expect to exist.
* Addition of some headers that the "ember" bits expect to exist at specific
  paths and with some specific content: "app/PluginApplicationCallbacks.h" and
  "zap-generated/endpoint_config.h".  Importantly, the latter sets
  FIXED_ENDPOINT_COUNT to 0.
* Addition of unit tests that exercise the non-OTA bits of the above (OTA is
  covered by existing tests), including the ACL checks and so on.
* Including a bunch of src/app and src/app/util files needed for the "ember"
  stuff to work in the framework.
* Turning off the chip_build_controller_dynamic_server bit that we are no longer
  using (and which conflicts with the above bits).
* Configure Darwin to support 254 dynamic endpoints (the maximum that makes
  sense) by default.
* Adjusting include paths for the Xcode darwin-framework-tool project, so that
  it sees the new headers that were added.

* Address review comments.

* Fix test timeout due to resolving IPv4 non-locahost addresses.

* Remove stale comment.

…mplementation (project-chip#31939)

…#31940)

)

* Add strong guarantee on monotonicity of system clock

- It was observed some platforms have decrementing values from
  `SystemClock::GetMonotonicMilliseconds64()` implementation
  which can violate the required invariant that they NEVER go back,
  since multiple deadlines are computed from this clock, which could
  then never hit. This was observed to break in the field in subtle
  ways after ~48 days (2^32 milliseconds).
- This change introduces a VerifyOrDie to allow crash/restart if
  the invariant is broken, since that leaves the stack in a possibly
  wedged state.
- The new invariant is constructed to be reentrant-safe to maintain
  the invariant, in a way that it will eventually be caught, even
  if there are many threads/cores calling `GetMonotonicTimestamp()`.
  This was done in a lock-free manner, and was added since the public
  API of SystemLayer is not guaranteed to only be called from Matter
  thread context.

Issue project-chip#31875

Testing done:

- All unit tests still pass.
- All integration tests still pass.
- When `mockClock.AdvanceMonotonic(200_ms);` is replaced with
  `mockClock.AdvanceMonotonic(0xffff'ffff'ffff'ffff_ms);` in
  `TestSystemTimer.cpp::CheckOrder()`, the test crashes as expected
  due to detection of wraparound.

* Fix review comments and move to intrinsics

* Restyled by clang-format

* Fix build and add warning

* Fix build

* Restyled by clang-format

* Address review comment, add new define instead of linux && darwin

* Restyled by clang-format

---------

Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>

* Initial XML for Power Topology cluster

* Regen

* Restyled really wants newlines at the end of every JSON file

* Rename LeafTopology to TreeTopology

* Use ScheduleLambda() instead of ScheduleWork

* Set min/max advertisement interval

* Matter BLE advertisement type shall be peripheral

* Allow intervals to be set after initialization

* Keep BlueZ default for adv slicing duration

* Allow to update intervals on the fly - fast/slow

* Transition to slow advertising after timeout

* Fix advertisement typos in all places in the codebase

* Do not specify advertisement timeout in BlueZ

* Add support for extended advertisement

* Post review changes - add manual how to enable experimental features in
BlueZ

* Restyled by prettier-markdown

* Assert that extended adv interval is >= fast adv interval

* Cancel HandleAdvertisingTimer timer in case of error

---------

Co-authored-by: Restyled.io <commits@restyled.io>

…project-chip#30889)

* ESP32: Add a menuconfig option to enable/disable persist subscription

* enable persistent subscription by default

…e list. (project-chip#31884)

project-chip#20413 changed the value
separator from comma to semicolon, but did not change the help text.

Fixes project-chip#31854

…ct-chip#31946)

The old logic had several bugs:

* For kYearDayScheduleUser users, there was no schedule enforcement at all,
  since the outer "if" never tested true.
* For kWeekDayScheduleUser users, there was no schedule enforcement at all,
  since the inner "if" never tested true.
* For kScheduleRestrictedUser users, access was allowed if there was any
  schedule, weekday or yearday, that granted access.  But the intent is that
  access should be disallowed if there are year day schedules and none of them
  grants access, no matter what's going on with weekday.  And vice versa.

…ue. (project-chip#31951)

Instead of hardcoding the returns via the ZAP template, just use the symbolic name.

* Spell out inet and lwip sources

Prepare to have some scripts that force all headers/sources to be known to GN.

* Fix some copy and paste issues

* Another copy and paste issue fixed

* Restyle

…were never used (project-chip#31929)

* Add silabs-specific lwip options to GN

* Make the lwipopts conditional

* Revert "Make the lwipopts conditional"

This reverts commit ff91e81.

* Add another dependency for lwip

…31949)

* Update SupportsAnyCredential function to include Aliro

* Restyled by clang-format (project-chip#31950)

Co-authored-by: Restyled.io <commits@restyled.io>

---------

Co-authored-by: restyled-io[bot] <32688539+restyled-io[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <commits@restyled.io>

* Add DataModelTest feature to general diagnostics

* Regen ZAP

* Fix TC-DGGEN-1.1

* Restyled by whitespace

* Restyled by clang-format

* Restyled by prettier-json

* Restyled by isort

* Fix integration tests

* Fix Java codegen

* Address review comments

* Fix Java codegen

* Fix Java codegen

* Fix Java codegen golden data

* Fix TC-DGGEN-1.1

* Fix removal of Commands.h

* Fix YAML test

---------

Co-authored-by: tennessee.carmelveilleux@gmail.com <tennessee@google.com>
Co-authored-by: Restyled.io <commits@restyled.io>

* Add files from src/controller to gn

* Add more orphaned files from controller itself

* Restyle

* Move more files into sources since CHIPCluster actually includes them. Seems VERY odd to have this header used but not actually have any implementation. This is a bug!

* Attempt to fix some of the include oddities. Controller is VERY broken and feels like a god object definition

* Move more headers ... CHIPDeviceController strongly pulls the entire world.

* Fix typo

* One more header

* Fix chef

* Add more includes that seem needed

* Add another dependency

* Add includes config to controller as it needs relative includes

* Restyle

* Fix clang-tidy logic

* Apply some clang-tidy fixes since I looked at controller. Minor nullptr usage and remove else after return

* Ensure no errors about unused assignments

* Yet another fix for logic to make sure all defined lists are used

* Include only headers as the special targets to force include errors

* Fix typo

* Fix typo

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>

* Adds MdnsDiscovery class

* Fix restyle/lint

* Fix restyle

* Adds zeroconf dependency in tests.yaml

* Relocates zeroconf dependency from tests.yaml to requirements.txt

* Addresses latest review comments

* Fixes typo

* Updates instantiation method and initial discovery

* Fix restyle/lint

* Addresses latest review comments

* Addresses latest review comments

* Fix restlye/lint

* Addresses review comments

* restore enum

* Refactor progress

* Major refactor to discover() and get_operational_service_info, pending other get methods

* Fix restyle

* Fix restyle/lint

* Updates descriptions and variables

* Major refactor #2

* Fix restyle

* Updates method descriptions

* Fix restyle

* Addresses review comments

* Fix restyle

* Fix lint

* Default parameters adjustment

---------

Co-authored-by: C Freeman <cecille@google.com>

…project-chip#31781)

* Allow chip-repl to know how many InvokeResponseMessages were recieved

* Restyled by autopep8

* Clean up callback to be test only specifically

* Restyled by clang-format

* Address PR comments

* Small edit to add line that shouldn't be removed in this PR

* Address PR comment

---------

Co-authored-by: Restyled.io <commits@restyled.io>

* Refactor ICD Check-In counter
Fix initial Check-In counter value

* Add basic integration tests to validate behavior

* Restyled by whitespace

* Restyled by prettier-yaml

* rename source_set

* Rename constant name

* Apply suggestions from code review

Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

* addres review comments

* Add init/shutdown unit-test for the ICDManager

* Fix Build.gn - multiple inclusion of CheckInMessage.cpp

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>

…1895)

…#31968)

Co-authored-by: Andrei Litvin <andreilitvin@google.com>

…an artifact. (project-chip#31964)

If there are crashes in the test, the crash logs should be in there, and we can
try to debug those.

…on 35 (project-chip#31762)

* add the board of tlsr9253b and tlsr9253b_retention

* riscv: telink: update board setting

- update the tlsr9253b setting .

Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>

* telink: b93: update the build sample and b93 platform

- update the light-switch and lighting-app .
- set the tlsr9253b and tlsr9253b_retention for the ci environment .

Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>

* telink: b93: fix the build environment

- set the tlsr9253b and tlsr9253b_retention for the ci environment .

Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>

* telink: b93: loopback to remote version

- change the github setting to telink .

Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>

* [Telink] Add B93 to Readme files

* [Telink] Fix CI builds

* [Telink] Reduce number of builds

* [Telink] Disable update Zephyr to specific revision

* Update builds to docker version 34

* [Telink] remove duplicated code

* revert k32w image update

* [Telink] rename B93 into B95

* Update builds to docker version 35

* fix doc build

---------

Signed-off-by: Haiwen Xia <haiwen.xia@telink-semi.com>
Co-authored-by: haiwen.xia <haiwen.xia@telink-semi.com>

project-chip#31960)

* Start creating a script

* Have much more functionality

* Restyle

* Add some doc comments ... this starts being usable

* Add workflow to validate that gn knows about files

* Remove controller from known exceptions: we fixed that one

* Fix flake8

* Add more known failures

* Better error reporting for gn reachability

* Remove the platform specific orphan file listing

* Force the "not failures anymore" to be fatal

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>

…p#31995)

* Added dummy implementations of the start and stop handler methods to the RvcOperationalState::Delegate class.

* Removed the start and stop handler methods defined in the all-clusters-app RvcOperationalStateDelegate.

* Removed the start and stop handler methods defined in the rvc-app RvcOperationalStateDelegate.

* Restyled by clang-format

* Apply typo fixes from code review

Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com>

---------

Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: Petru Lauric <81822411+plauric@users.noreply.github.com>

…in. (project-chip#31959)

…ject-chip#31930)

* Rearranged order of the pytest scripts alphbetically accordingly to the arguments

* Fixed 2 scripts alphabetically were not in line

* This changes reflect the sorting of the testing python scripts via machine runned .py script.

---------

Co-authored-by: Andrei Litvin <andy314@gmail.com>

…31890)

* Send Check-In message at boot

* Update reboot test

* update comment

* restyle

* refactor function so that it can be used outside of the reboot

* Remove unused define function

---------

Co-authored-by: Andrei Litvin <andy314@gmail.com>

* Resolve the cluster revision issues

* Restyled by whitespace

* Restyled by clang-format

* Update per comments

* Restyled by whitespace

* Restyled by clang-format

* Update Content Launcher

* Restyled by whitespace

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <commits@restyled.io>

…roject-chip#31983)

* Use DecodeChipCert instead of LoadCert in chip-cert print-cert

LoadCert performs additional checks (only relevant to operational certs)
that prevent PDC identities from being printed.

* Simplify CHIPCert test vector code

* Add ConvertECDSAKeypairRawToDER to CHIPCert

* Linux: Make WiFiNetwork struct private, add helpers

- Make WiFiNetwork struct private
- Move static_asserts to where the fields are defined
- Add Empty() and Match() helpers to WiFiNetwork
- Validate index parameter in ReorderNetwork()
- Use CHIP_ERROR_FORMAT

* Linux: Implement PDC support in WiFiDriver / ConnectivityManagerImpl

* Address review comments

* Clear handled err before the next call

…ct-chip#31279)

- Extended the OperationalKeystore API by mechanism for migration of
operational keys stored in one Operational Keystore implementation
to another.

- Extended the OperationalKeystore API by exporting keypair for Fabric.

- Added Unit tests to PersistentStorageOpKeyStore and PSAOpKeystore regarding
the new OperationalKeystore for migration and exporting OpKeys.

Added first unit tests, created export method

…project-chip#32004)

* Completely remove all references to CHIPClusters.h

* Restyle

* Remove references to CHIPClusters.zapt as well

* Use BaseCluster instead of specific clusters

* Fix names and includes

…1977)

* Add 2 java files to be known to gn

* Add python files

* Fix commas and format

* Mark a set of files handled

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>

…ct-chip#31976)

* Make sure dnssd constants and browsedelegate is tracked by gn

* Add more minmdns sources to be known to gn

* Move more things into Types to make sure that platform Dnssd knows about them

* Fix system layer dependency in linux dnssd impl

* Remove dnssd files from lint

* Add Delegate to Types as well ... it seems required for platform

* Remove duplicate source

* Restyle

---------

Co-authored-by: Andrei Litvin <andreilitvin@google.com>