Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add excetpion try-catch in getConnectedPointer #32237

Conversation

joonhaengHeo
Copy link
Contributor

Fix #28430

For avoid crash, I added try-catch in getConnectedPointer methods.

@joonhaengHeo joonhaengHeo force-pushed the add_exception_try_catch_in_android_chiptool branch from 19a1862 to 5f0d663 Compare February 21, 2024 11:41
Copy link

github-actions bot commented Feb 21, 2024

PR #32237: Size comparison from b8de5cc to 5f0d663

Decreases (2 builds for efr32)
platform target config section b8de5cc 5f0d663 change % change
efr32 lighting-app BRD4187C (read/write) 1107200 1107192 -8 -0.0
.text 908620 908612 -8 -0.0
window-app BRD4187C (read/write) 1153816 1153808 -8 -0.0
.text 983084 983076 -8 -0.0
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
platform target config section b8de5cc 5f0d663 change % change
bl602 lighting-app bl602 (read/write) 1432978 1432978 0 0.0
.bss 85328 85328 0 0.0
.data 9496 9496 0 0.0
.rodata 157532 157532 0 0.0
.text 1099972 1099972 0 0.0
bl602+mfd (read/write) 1447378 1447378 0 0.0
.bss 85488 85488 0 0.0
.data 9472 9472 0 0.0
.rodata 156492 156492 0 0.0
.text 1115282 1115282 0 0.0
bl602+rpc (read/write) 1480346 1480346 0 0.0
.bss 93360 93360 0 0.0
.data 9872 9872 0 0.0
.rodata 165100 165100 0 0.0
.text 1131354 1131354 0 0.0
bl702 lighting-app bl702 (read only) 3478 3478 0 0.0
(read/write) 1197735 1197735 0 0.0
.bss 11121 11121 0 0.0
.data 3680 3680 0 0.0
.rodata 106872 106872 0 0.0
.text 969194 969194 0 0.0
bl702+mfd (read only) 3478 3478 0 0.0
(read/write) 1208787 1208787 0 0.0
.bss 11297 11297 0 0.0
.data 3656 3656 0 0.0
.rodata 105812 105812 0 0.0
.text 981204 981204 0 0.0
bl702+rpc (read only) 3478 3478 0 0.0
(read/write) 1289459 1289459 0 0.0
.bss 19589 19589 0 0.0
.data 4224 4224 0 0.0
.rodata 122244 122244 0 0.0
.text 1044138 1044138 0 0.0
bl706-eth (read/write) 1015349 1015349 0 0.0
.bss 23680 23680 0 0.0
.data 3248 3248 0 0.0
.rodata 100216 100216 0 0.0
.text 760250 760250 0 0.0
bl706-wifi (read/write) 1249390 1249390 0 0.0
.bss 10565 10565 0 0.0
.data 3688 3688 0 0.0
.rodata 121216 121216 0 0.0
.text 991514 991514 0 0.0
bl702l lighting-app bl702l (read only) 512 512 0 0.0
(read/write) 1167308 1167308 0 0.0
.bss 16316 16316 0 0.0
.data 5040 5040 0 0.0
.rodata 100876 100876 0 0.0
.text 962292 962292 0 0.0
bl702l+mfd (read only) 512 512 0 0.0
(read/write) 1178716 1178716 0 0.0
.bss 16492 16492 0 0.0
.data 5024 5024 0 0.0
.rodata 99816 99816 0 0.0
.text 974614 974614 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 771508 771508 0 0.0
(read/write) 168600 168600 0 0.0
.bss 90604 90604 0 0.0
.data 3560 3560 0 0.0
.rodata 81652 81652 0 0.0
.text 689588 689588 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 788292 788292 0 0.0
(read/write) 178848 178848 0 0.0
.bss 100852 100852 0 0.0
.data 3560 3560 0 0.0
.rodata 75940 75940 0 0.0
.text 712084 712084 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 776964 776964 0 0.0
(read/write) 173288 173288 0 0.0
.bss 95292 95292 0 0.0
.data 3560 3560 0 0.0
.rodata 102700 102700 0 0.0
.text 673996 673996 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 729132 729132 0 0.0
(read/write) 167568 167568 0 0.0
.bss 89336 89336 0 0.0
.data 3552 3552 0 0.0
.rodata 77372 77372 0 0.0
.text 651492 651492 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 714756 714756 0 0.0
(read/write) 167776 167776 0 0.0
.bss 89560 89560 0 0.0
.data 3544 3544 0 0.0
.rodata 73212 73212 0 0.0
.text 641276 641276 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 581274 581274 0 0.0
(read/write) 207968 207968 0 0.0
.bss 201204 201204 0 0.0
.data 1640 1640 0 0.0
.rodata 86522 86522 0 0.0
.text 492628 492628 0 0.0
lock CC3235SF_LAUNCHXL (read only) 626570 626570 0 0.0
(read/write) 208312 208312 0 0.0
.bss 201696 201696 0 0.0
.data 1496 1496 0 0.0
.rodata 106978 106978 0 0.0
.text 517468 517468 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 566731 566731 0 0.0
.app_xip_area 456517 456517 0 0.0
.bss 65048 65048 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 549707 549707 0 0.0
.app_xip_area 434733 434733 0 0.0
.bss 69800 69800 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 568483 568483 0 0.0
.app_xip_area 459773 459773 0 0.0
.bss 63584 63584 0 0.0
.data 704 704 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 562971 562971 0 0.0
.app_xip_area 450981 450981 0 0.0
.bss 66784 66784 0 0.0
.data 784 784 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 929792 929792 0 0.0
.bss 197912 197912 0 0.0
.data 1388 1388 0 0.0
.text 730468 730468 0 0.0
BRD4187C (read/write) 1107200 1107192 -8 -0.0
.bss 195152 195152 0 0.0
.data 3408 3408 0 0.0
.text 908620 908612 -8 -0.0
lock-app BRD4161A+wf200 (read/write) 1120564 1120564 0 0.0
.bss 186764 186764 0 0.0
.data 2792 2792 0 0.0
.text 930988 930988 0 0.0
window-app BRD4187C (read/write) 1153816 1153808 -8 -0.0
.bss 167392 167392 0 0.0
.data 3320 3320 0 0.0
.text 983084 983076 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1208572 1208572 0 0.0
(read/write) 1748656 1748656 0 0.0
.dram0.bss 74296 74296 0 0.0
.dram0.data 13620 13620 0 0.0
.flash.rodata 251200 251200 0 0.0
.flash.text 1208572 1208572 0 0.0
.iram0.text 75530 75530 0 0.0
m5stack (read only) 1250707 1250707 0 0.0
(read/write) 534140 534140 0 0.0
.dram0.bss 81208 81208 0 0.0
.dram0.data 35164 35164 0 0.0
.flash.rodata 281848 281848 0 0.0
.flash.text 1244543 1244543 0 0.0
.iram0.text 125403 125403 0 0.0
k32w contact k32w0+release (read only) 611008 611008 0 0.0
(read/write) 80036 80036 0 0.0
.bss 67828 67828 0 0.0
.data 2224 2224 0 0.0
.text 610472 610472 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 746148 746148 0 0.0
.bss 79188 79188 0 0.0
.data 2816 2816 0 0.0
.text 624776 624776 0 0.0
light k32w0+release (read only) 602632 602632 0 0.0
(read/write) 79492 79492 0 0.0
.bss 67308 67308 0 0.0
.data 2200 2200 0 0.0
.text 602096 602096 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 788264 788264 0 0.0
.bss 80580 80580 0 0.0
.data 2032 2032 0 0.0
.text 666296 666296 0 0.0
lock k32w0+release (read only) 581384 581384 0 0.0
(read/write) 77480 77480 0 0.0
.bss 65348 65348 0 0.0
.data 2148 2148 0 0.0
.text 580848 580848 0 0.0
linux air-purifier-app debug (read only) 2634149 2634149 0 0.0
(read/write) 129416 129416 0 0.0
.bss 46896 46896 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 74328 74328 0 0.0
.dynamic 608 608 0 0.0
.got 4568 4568 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 185104 185104 0 0.0
.text 2271061 2271061 0 0.0
all-clusters-app debug (read only) 5928601 5928601 0 0.0
(read/write) 480856 480856 0 0.0
.bss 135232 135232 0 0.0
.data 4464 4464 0 0.0
.data.rel.ro 333720 333720 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1392 1392 0 0.0
.rodata 349296 349296 0 0.0
.text 5145459 5145459 0 0.0
all-clusters-minimal-app debug (read only) 5209553 5209553 0 0.0
(read/write) 236808 236808 0 0.0
.bss 128032 128032 0 0.0
.data 4368 4368 0 0.0
.data.rel.ro 97320 97320 0 0.0
.dynamic 624 624 0 0.0
.got 5304 5304 0 0.0
.init 27 27 0 0.0
.init_array 1120 1120 0 0.0
.rodata 288322 288322 0 0.0
.text 4686003 4686003 0 0.0
bridge-app debug (read only) 4606953 4606953 0 0.0
(read/write) 217680 217680 0 0.0
.bss 118560 118560 0 0.0
.data 6176 6176 0 0.0
.data.rel.ro 86224 86224 0 0.0
.dynamic 624 624 0 0.0
.got 5272 5272 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 228930 228930 0 0.0
.text 4157235 4157235 0 0.0
chip-tool debug (read only) 11986801 11986801 0 0.0
(read/write) 521232 521232 0 0.0
.bss 94264 94264 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 414656 414656 0 0.0
.dynamic 624 624 0 0.0
.got 5776 5776 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 447705 447705 0 0.0
.text 10833427 10833427 0 0.0
chip-tool-ipv6only arm64 (read only) 11484208 11484208 0 0.0
(read/write) 588568 588568 0 0.0
.bss 103352 103352 0 0.0
.data 4488 4488 0 0.0
.data.rel.ro 454416 454416 0 0.0
.dynamic 512 512 0 0.0
.got 20336 20336 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 352988 352988 0 0.0
.text 10243356 10243356 0 0.0
lighting-app debug+rpc+ui (read only) 5529185 5529185 0 0.0
(read/write) 226448 226448 0 0.0
.bss 119496 119496 0 0.0
.data 4832 4832 0 0.0
.data.rel.ro 94608 94608 0 0.0
.dynamic 672 672 0 0.0
.got 5888 5888 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 353780 353780 0 0.0
.text 4928515 4928515 0 0.0
lock-app debug (read only) 4675089 4675089 0 0.0
(read/write) 205336 205336 0 0.0
.bss 114016 114016 0 0.0
.data 4128 4128 0 0.0
.data.rel.ro 80472 80472 0 0.0
.dynamic 624 624 0 0.0
.got 5224 5224 0 0.0
.init 27 27 0 0.0
.init_array 848 848 0 0.0
.rodata 254978 254978 0 0.0
.text 4207939 4207939 0 0.0
ota-provider-app debug (read only) 4307817 4307817 0 0.0
(read/write) 193896 193896 0 0.0
.bss 113792 113792 0 0.0
.data 4336 4336 0 0.0
.data.rel.ro 69856 69856 0 0.0
.dynamic 624 624 0 0.0
.got 4560 4560 0 0.0
.init 27 27 0 0.0
.init_array 704 704 0 0.0
.rodata 207618 207618 0 0.0
.text 3906739 3906739 0 0.0
ota-requestor-app debug (read only) 4433977 4433977 0 0.0
(read/write) 198272 198272 0 0.0
.bss 114688 114688 0 0.0
.data 4736 4736 0 0.0
.data.rel.ro 72960 72960 0 0.0
.dynamic 624 624 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 760 760 0 0.0
.rodata 213794 213794 0 0.0
.text 4022147 4022147 0 0.0
shell debug (read only) 2878769 2878769 0 0.0
(read/write) 156104 156104 0 0.0
.bss 62544 62544 0 0.0
.data 1392 1392 0 0.0
.data.rel.ro 86384 86384 0 0.0
.dynamic 592 592 0 0.0
.got 4080 4080 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 186528 186528 0 0.0
.text 2518978 2518978 0 0.0
thermostat-no-ble arm64 (read only) 4487448 4487448 0 0.0
(read/write) 249736 249736 0 0.0
.bss 122360 122360 0 0.0
.data 3360 3360 0 0.0
.data.rel.ro 103816 103816 0 0.0
.dynamic 512 512 0 0.0
.got 12080 12080 0 0.0
.init 24 24 0 0.0
.init_array 416 416 0 0.0
.rodata 159356 159356 0 0.0
.text 3982892 3982892 0 0.0
tv-app debug (read only) 5683369 5683369 0 0.0
(read/write) 352080 352080 0 0.0
.bss 243824 243824 0 0.0
.data 6496 6496 0 0.0
.data.rel.ro 94472 94472 0 0.0
.dynamic 624 624 0 0.0
.got 5512 5512 0 0.0
.init 27 27 0 0.0
.init_array 1144 1144 0 0.0
.rodata 288098 288098 0 0.0
.text 5152915 5152915 0 0.0
tv-casting-app debug (read only) 9868889 9868889 0 0.0
(read/write) 340680 340680 0 0.0
.bss 156560 156560 0 0.0
.data 2944 2944 0 0.0
.data.rel.ro 174264 174264 0 0.0
.dynamic 624 624 0 0.0
.got 5088 5088 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 382672 382672 0 0.0
.text 9020083 9020083 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2530760 2530760 0 0.0
.bss 220448 220448 0 0.0
.data 5200 5200 0 0.0
.text 1493444 1493444 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1099952 1099952 0 0.0
bss 130831 130831 0 0.0
rodata 112024 112024 0 0.0
text 809244 809244 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1219976 1219976 0 0.0
bss 122921 122921 0 0.0
rodata 141768 141768 0 0.0
text 804768 804768 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1048260 1048260 0 0.0
bss 129689 129689 0 0.0
rodata 99396 99396 0 0.0
text 771340 771340 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 834464 834464 0 0.0
(read/write) 1794076 1794076 0 0.0
.bss 196212 196212 0 0.0
.data 2664 2664 0 0.0
.text 1586812 1586812 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 837616 837616 0 0.0
(read/write) 1716212 1716212 0 0.0
.bss 193092 193092 0 0.0
.data 2632 2632 0 0.0
.text 1512100 1512100 0 0.0
light cy8ckit_062s2_43012 (read only) 844344 844344 0 0.0
(read/write) 1635540 1635540 0 0.0
.bss 186556 186556 0 0.0
.data 2440 2440 0 0.0
.text 1438156 1438156 0 0.0
lock cy8ckit_062s2_43012 (read only) 817184 817184 0 0.0
(read/write) 1665532 1665532 0 0.0
.bss 213716 213716 0 0.0
.data 2440 2440 0 0.0
.text 1440988 1440988 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1126752 1126752 0 0.0
.bss 102456 102456 0 0.0
.data 820 820 0 0.0
.text 639136 639136 0 0.0
lock-app qpg6105+debug (read/write) 1086712 1086712 0 0.0
.bss 97200 97200 0 0.0
.data 840 840 0 0.0
.text 599092 599092 0 0.0
stm32 light STM32WB5MM-DK (read/write) 598149 598149 0 0.0
.bss 128320 128320 0 0.0
.data 668 668 0 0.0
.rodata 78772 78772 0 0.0
.text 380664 380664 0 0.0
telink air-quality-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 820970 820970 0 0.0
bss 49660 49660 0 0.0
text 614776 614776 0 0.0
all-clusters-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 1089180 1089180 0 0.0
bss 101780 101780 0 0.0
text 791282 791282 0 0.0
all-clusters-minimal-app tlsr9528a (read only) 47960 47960 0 0.0
(read/write) 1046764 1046764 0 0.0
bss 110084 110084 0 0.0
text 762716 762716 0 0.0
bridge-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 908004 908004 0 0.0
bss 93116 93116 0 0.0
text 650674 650674 0 0.0
contact-sensor-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 822594 822594 0 0.0
bss 49708 49708 0 0.0
text 616454 616454 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 928112 928112 0 0.0
bss 77708 77708 0 0.0
text 696406 696406 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d (read only) 29122 29122 0 0.0
(read/write) 1070276 1070276 0 0.0
bss 100196 100196 0 0.0
text 775188 775188 0 0.0
lock-app-dfu tlsr9528a (read only) 51584 51584 0 0.0
(read/write) 900696 900696 0 0.0
bss 69172 69172 0 0.0
text 651864 651864 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 926332 926332 0 0.0
bss 92696 92696 0 0.0
text 669040 669040 0 0.0
pump-app tlsr9258a_retention (read only) 51774 51774 0 0.0
(read/write) 825202 825202 0 0.0
bss 49816 49816 0 0.0
text 619468 619468 0 0.0
pump-controller-app tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 788916 788916 0 0.0
bss 56016 56016 0 0.0
text 590218 590218 0 0.0
shell tlsr9518adk80d (read only) 29042 29042 0 0.0
(read/write) 676816 676816 0 0.0
bss 73672 73672 0 0.0
text 462298 462298 0 0.0
smoke_co_alarm-app tlsr9528a_retention (read only) 51774 51774 0 0.0
(read/write) 829622 829622 0 0.0
bss 51340 51340 0 0.0
text 622516 622516 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d (read only) 32220 32220 0 0.0
(read/write) 848077 848077 0 0.0
bss 59492 59492 0 0.0
text 634128 634128 0 0.0
thermostat tlsr9518adk80d (read only) 31872 31872 0 0.0
(read/write) 814520 814520 0 0.0
bss 56304 56304 0 0.0
text 609866 609866 0 0.0
window-covering tlsr9258a (read only) 51584 51584 0 0.0
(read/write) 832624 832624 0 0.0
bss 68080 68080 0 0.0
text 625124 625124 0 0.0

@yunhanw-google yunhanw-google enabled auto-merge (squash) February 21, 2024 16:52
@yunhanw-google yunhanw-google merged commit 4158d55 into project-chip:master Feb 21, 2024
60 checks passed
huangxuyong pushed a commit to huangxuyong/connectedhomeip that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android][CHIPTool][Crash] crash occured when connect matter device using getConnectedDevicePointer
3 participants