Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add darwin test for general diagnostics cluster, and fix incorrect reinterpret_cast that got added #6804

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

General diagnostics did not get added to our various chip-tools (darwin and example).

Summary of Changes

Add it to the tools, fix it to compile correctly and pass the tests.

Fixes #6801

@todo
Copy link

todo bot commented May 14, 2021

CHAR_STRING not supported yet in structs.

// TODO: CHAR_STRING not supported yet in structs.
<item name="Name" type="OCTET_STRING" length="32"/>
<item name="FabricConnected" type="BOOLEAN"/>
<item name="OffPremiseServicesReachableIPv4" type="BOOLEAN"/>
<item name="OffPremiseServicesReachableIPv6" type="BOOLEAN"/>


This comment was generated by todo based on a TODO comment in 8de069c in #6804. cc @bzbarsky-apple.

@bzbarsky-apple bzbarsky-apple force-pushed the add-darwin-test-for-general-diagnostics branch 2 times, most recently from 75fa695 to 65c68f9 Compare May 14, 2021 07:21
@woody-apple
Copy link
Contributor

@bzbarsky-apple ?

Some notes:

1) This cluster appears on endpoint 0 on all-clusters-app, so we have to add
   it to the list in src/darwin/Framework/CHIP/templates/helper.js.

2) CHAR_STRING is not supported in structs yet.  Hence switch
   NetworkInterfaceType to using OCTET_STRING.

3) Remove the incorrect reinterpret_cast that was added to
   src/app/zap-templates/templates/app/attribute-size-src.zapt.
@bzbarsky-apple bzbarsky-apple force-pushed the add-darwin-test-for-general-diagnostics branch from 65c68f9 to bc6df36 Compare May 14, 2021 22:49
@github-actions
Copy link

Size increase report for "esp32-example-build" from f4b00be

File Section File VM
chip-all-clusters-app.elf .flash.text -4 -4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,3891
.debug_loc,0,1945
.debug_line,0,1937
.debug_str,0,480
.debug_frame,0,96
.debug_aranges,0,32
.debug_ranges,0,32
.xt.prop._ZTVN4chip11DeviceLayer37DeviceNetworkProvisioningDelegateImplE,0,-1
.flash.text,-4,-4

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit e5cb796 into project-chip:master May 14, 2021
@bzbarsky-apple bzbarsky-apple deleted the add-darwin-test-for-general-diagnostics branch May 14, 2021 23:42
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request May 17, 2021
There was a merge conflict that was not detected by automatic merge
between project-chip#6822 and
project-chip#6804 that caused
files removed by the former to be re-created by the latter.  Those
files should not exist.
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request May 17, 2021
There was a merge conflict that was not detected by automatic merge
between project-chip#6822 and
project-chip#6804 that caused
files removed by the former to be re-created by the latter.  Those
files should not exist.
woody-apple pushed a commit that referenced this pull request May 18, 2021
There was a merge conflict that was not detected by automatic merge
between #6822 and
#6804 that caused
files removed by the former to be re-created by the latter.  Those
files should not exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bogus cast introduced in PR 6690
5 participants