Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add darwin test for general diagnostics cluster, and fix incorrect reinterpret_cast that got added #6804

Merged
merged 2 commits into from
May 14, 2021
Merged

Add darwin test for general diagnostics cluster, and fix incorrect reinterpret_cast that got added #6804

merged 2 commits into from
May 14, 2021

Commits on May 14, 2021

  1. Add basic attribute read tests for general diagnostics cluster. 

    Some notes:

1) This cluster appears on endpoint 0 on all-clusters-app, so we have to add
   it to the list in src/darwin/Framework/CHIP/templates/helper.js.

2) CHAR_STRING is not supported in structs yet.  Hence switch
   NetworkInterfaceType to using OCTET_STRING.

3) Remove the incorrect reinterpret_cast that was added to
   src/app/zap-templates/templates/app/attribute-size-src.zapt.
    @bzbarsky-apple
    bzbarsky-apple committed May 14, 2021
    Configuration menu
    Copy the full SHA
    2965c18 View commit details
    Browse the repository at this point in the history

  2. Regenerate generated files

    @bzbarsky-apple
    bzbarsky-apple committed May 14, 2021
    Configuration menu
    Copy the full SHA
    bc6df36 View commit details
    Browse the repository at this point in the history