Skip to content
This repository has been archived by the owner on Dec 1, 2020. It is now read-only.

Set the paused argument in the gazebo empty_world.launch to False #54

Merged
merged 2 commits into from
May 5, 2020

Conversation

JorisWeeda
Copy link
Contributor

Description

In order to properly launch the moveit package the simulation time must be active otherwise the movegroups will not be initialized. If the movegroups are not initialised the init of the gait selection is not finished causing the state machine to be stuck waiting for the gait selection which will not be finished. Therefore the paused argument must be false. This will not cause any weird behavior of the simulation because the physics are loaded after the state machine is initialized.

Changes

  • Set paused argument to false

…ause the time is necessary to launch moveit with the corresponding move_groups
@JorisWeeda JorisWeeda requested a review from Olavhaasie as a code owner May 1, 2020 13:50
RutgerVanBeek
RutgerVanBeek previously approved these changes May 1, 2020
Copy link
Contributor

@RutgerVanBeek RutgerVanBeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitively approve this.

Copy link
Contributor

@Roelemans Roelemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make a paused argument that is set to $(arg not balanced) in march.launch?

@JorisWeeda
Copy link
Contributor Author

Perhaps make a paused argument that is set to $(arg not balanced) in march.launch?

We could add an argument but Rutger and I tested the normal simulation launch and the argument change did not degrade the functionalities of the simulation so maybe not necessary?

@JorisWeeda JorisWeeda requested a review from Roelemans May 4, 2020 07:57
@Roelemans
Copy link
Contributor

The simulation is started paused to avoid the issue of feet flapping after startup (though you may have noticed that this does not always work). I am not sure how big that problem currently is. I do have a preference for starting it paused when possible, because I don't wanna look into the flappin feet again 🙃

@RutgerVanBeek
Copy link
Contributor

The simulation is started paused to avoid the issue of feet flapping after startup (though you may have noticed that this does not always work). I am not sure how big that problem currently is. I do have a preference for starting it paused when possible, because I don't wanna look into the flappin feet again

The physics are only turned on when the state machine is finished initializing, right?
This just make the gazebo publish on /clock.

@Roelemans
Copy link
Contributor

Roelemans commented May 4, 2020

EDIT: Just realised that the "unpause physics" at the end of the state machine unpauses the simulation. But that only works if it is started paused, which is what you are turning off here. i.e. if you set paused to false as you propose in this PR, the physics will start unpaused and the unpausee at the end of the state machine will do nothing.

@Roelemans Roelemans merged commit 24a6c60 into develop May 5, 2020
@Roelemans Roelemans deleted the fix/launch_moveit_with_simulation branch May 5, 2020 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants