examples: move tests to be integration tests #1154
Conversation
| @@ -6,7 +6,7 @@ edition = "2018" | |||
| license = "Apache-2.0" | |||
|
|
|||
| [lib] | |||
| crate-type = ["cdylib"] | |||
| crate-type = ["cdylib", "rlib"] | |||
There was a problem hiding this comment.
Is rlib added to make the modules available to the integration tests? How is oak/server/rust/oak_runtime/tests/integration_test.rs working without it? What is its magic?
Not so important, but perhaps oak/server/rust/oak_runtime/tests/integration_test.rs could be renamed to integration_tests.rs as well, to be consistent :)
There was a problem hiding this comment.
Oh! Just saw your description!
There was a problem hiding this comment.
I think the magic is that rlib is the default (and so not mentioned in oak_runtime/Cargo.toml; however, the examples need to be built for the Wasm target and that (I think) needs cdylib crate type.
Also, it looks like integration_test.rs is more canonical so I'll move to that in the examples.
Most of the tests for example Oak Applications just use the external gRPC service definition for testing, and so can be external integration tests rather than unit tests. This does require an "rlib" target for the modules though, because of rust-lang/cargo#6659 The trusted_information_retrieval example's tests included both unit tests and integration tests, so is split. Along the way, make the floating comparisons in the unit tests a bit more robust. Fixes #1054.
Most of the tests for example Oak Applications just use the external
gRPC service definition for testing, and so can be external integration
tests rather than unit tests.
This does require an "rlib" target for the modules though, because of
rust-lang/cargo#6659
The trusted_information_retrieval example's tests included both unit
tests and integration tests, so is split. Along the way, make the
floating comparisons in the unit tests a bit more robust.
Fixes #1054.
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.